New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 775603 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 630771

Blocking:
issue 747117



Sign in to add a comment

Unify "tab needs attention" indication

Project Member Reported by a...@chromium.org, Oct 17 2017

Issue description

Chrome has disparate "this tab needs your attention" indicators.

- If a pinned background tab has a name change, Views shows a blue dot until the tab is activated, while the Mac pulses the tab once.
- If a background tab has a tab-modal dialog, with Views it pulses continuously, while with the Mac there is no appearance change.

I need an indication for background alert dialogs ( bug 747117 ) so that will be a third requirement.

My plan is to clean up and unify the platform behaviors. The plan:

- For pinned background tab name changes, do what Views does, and dot the tab until the tab is activated.
- For background tabs with dialogs, have them display a dot.

Note that this means that when a tab has a dialog, while it is in the background it shows a dot, which disappears when the tab is moved to the front, but it regains the dot when backgrounded. This seems less obtrusive than dotting the tab the whole time.
 

Comment 1 by a...@chromium.org, Oct 17 2017

Blocking: 747117

Comment 2 by a...@chromium.org, Oct 17 2017

Blockedon: 630771
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1e77b103a28eec4f63b52724d4bbba4a175e30c

commit b1e77b103a28eec4f63b52724d4bbba4a175e30c
Author: Avi Drissman <avi@chromium.org>
Date: Tue Oct 24 23:55:51 2017

Unify the "needs attention" indicator across desktop platforms.

This unifies the appearance as a blue dot and unifies function
as that dot for pinned tab title changes, tab-modal dialogs, and
soon-to-come background alert dialogs.

BUG= 775603 , 630771 , 473898 

Change-Id: I2e96db1c98455b8a9c0c896a95ad38482d79e3c2
Reviewed-on: https://chromium-review.googlesource.com/728719
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Sidney San Martín <sdy@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511310}
[modify] https://crrev.com/b1e77b103a28eec4f63b52724d4bbba4a175e30c/chrome/browser/ui/cocoa/tabs/tab_controller.h
[modify] https://crrev.com/b1e77b103a28eec4f63b52724d4bbba4a175e30c/chrome/browser/ui/cocoa/tabs/tab_controller.mm
[modify] https://crrev.com/b1e77b103a28eec4f63b52724d4bbba4a175e30c/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm
[modify] https://crrev.com/b1e77b103a28eec4f63b52724d4bbba4a175e30c/chrome/browser/ui/cocoa/tabs/tab_strip_model_observer_bridge.h
[modify] https://crrev.com/b1e77b103a28eec4f63b52724d4bbba4a175e30c/chrome/browser/ui/cocoa/tabs/tab_strip_model_observer_bridge.mm
[modify] https://crrev.com/b1e77b103a28eec4f63b52724d4bbba4a175e30c/chrome/browser/ui/cocoa/tabs/tab_view.h
[modify] https://crrev.com/b1e77b103a28eec4f63b52724d4bbba4a175e30c/chrome/browser/ui/cocoa/tabs/tab_view.mm
[modify] https://crrev.com/b1e77b103a28eec4f63b52724d4bbba4a175e30c/chrome/browser/ui/cocoa/tabs/tab_view_unittest.mm
[modify] https://crrev.com/b1e77b103a28eec4f63b52724d4bbba4a175e30c/chrome/browser/ui/tabs/tab_strip_model.cc
[modify] https://crrev.com/b1e77b103a28eec4f63b52724d4bbba4a175e30c/chrome/browser/ui/tabs/tab_strip_model.h
[modify] https://crrev.com/b1e77b103a28eec4f63b52724d4bbba4a175e30c/chrome/browser/ui/tabs/tab_strip_model_observer.cc
[modify] https://crrev.com/b1e77b103a28eec4f63b52724d4bbba4a175e30c/chrome/browser/ui/tabs/tab_strip_model_observer.h
[modify] https://crrev.com/b1e77b103a28eec4f63b52724d4bbba4a175e30c/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
[modify] https://crrev.com/b1e77b103a28eec4f63b52724d4bbba4a175e30c/chrome/browser/ui/views/tabs/browser_tab_strip_controller.h
[modify] https://crrev.com/b1e77b103a28eec4f63b52724d4bbba4a175e30c/chrome/browser/ui/views/tabs/tab.cc
[modify] https://crrev.com/b1e77b103a28eec4f63b52724d4bbba4a175e30c/chrome/browser/ui/views/tabs/tab.h
[modify] https://crrev.com/b1e77b103a28eec4f63b52724d4bbba4a175e30c/chrome/browser/ui/views/tabs/tab_strip.cc
[modify] https://crrev.com/b1e77b103a28eec4f63b52724d4bbba4a175e30c/chrome/browser/ui/views/tabs/tab_strip.h
[modify] https://crrev.com/b1e77b103a28eec4f63b52724d4bbba4a175e30c/chrome/browser/ui/views/tabs/tab_strip_unittest.cc

Comment 4 by a...@chromium.org, Oct 25 2017

Status: Fixed (was: Started)

Sign in to add a comment