New issue
Advanced search Search tips

Issue 775595 link

Starred by 1 user
Status: Fixed
Owner:
ryansturm@chromium.org
Closed: Oct 2017
Cc:
bengr@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , Windows
Pri: 3
Type: Bug



Sign in to add a comment

Allowed reason is being reported as blacklist unavailable on interventions internals

Project Member Reported by ryansturm@chromium.org, Oct 17 2017 
When a previews navigation is allowed, the reason is being reported as blacklist unavailable on interventions internals. This is due to a missing break statement.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96e03c9bb46af844dbd0d90b4c1607ec17cc49c6

commit 96e03c9bb46af844dbd0d90b4c1607ec17cc49c6
Author: Ryan Sturm <ryansturm@chromium.org>
Date: Tue Oct 17 23:35:28 2017

Restructuring a previews switch statment due to implicit fallthrough

There was a missing break statement in a switch statements, so this code
was refactored to have a return in each case statment.

Bug:  775595 
Change-Id: Iec1671d5946804190d7d747bec9f17183586eff5
Reviewed-on: https://chromium-review.googlesource.com/723729
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509594}
[modify] https://crrev.com/96e03c9bb46af844dbd0d90b4c1607ec17cc49c6/components/previews/core/previews_logger.cc
[modify] https://crrev.com/96e03c9bb46af844dbd0d90b4c1607ec17cc49c6/components/previews/core/previews_logger_unittest.cc

Comment 2 by ryansturm@chromium.org, Oct 25 2017

Status: Fixed (was: Started)

Comment 3 by efoo@chromium.org, Dec 5 2017

Components: Blink>Previews

Comment 4 by efoo@chromium.org, Dec 5 2017

Components: -UI>Browser>Previews
►

Sign in to add a comment