[MaterialDesign] [macOS] The hover buttons in the Omnibox have a quicker fade-in and fade-out animation time than the Toolbar Buttons |
|||||||||||
Issue descriptionChrome Version: 64.0.3242.0 Canary OS: macOS 10.12.6 What steps will reproduce the problem? (1) Compare the fade-in and fade-out animation of the Toolbar Buttons with the Buttons in the Omnibox What is the expected result? The Omnibox fade-in and fade-out animation should be smooth like the Toolbar buttons. What happens instead? The Omnibox fade-in and fade-out animation are quicker. A screencast is attached. Please feel free to close this issue, if this is intentional. Thanks. Mehmet
,
Oct 17 2017
It looks like the omnibox items don't do any fading but instead snap right to their new state. Seems like they should match the toolbar but I'm not sure.
,
Oct 17 2017
+maxwalker for his thoughts Yes, there's no fading implemented for the omnibox items. This is different behavior from Windows, which do have some fading.
,
Oct 18 2017
Yes, this is already the case on Windows and CrOS. It would be great to match the toolbar on macOS, too. (Please note that there should be no ripple effects on macOS). Thanks for bringing this up!
,
Oct 18 2017
I recently added a class for the MD download shelf (MDHoverButton) that implements this behavior. I'm planning to use it for issue 648729, and it should work in other cases too.
,
Oct 18 2017
Sounds good!
,
Oct 18 2017
Thank you, sdy@. I noticed that the Bookmarks Items on Bookmarks Bar have a fade in, but not a fade out animation. Should I file a separate report for it or do you want to combine it with this report?
,
Oct 18 2017
Actually, a separate bug might be good. Could you cc me and lgrey@ (who's done a bit of bookmarks work recently)? Much appreciated!
,
Oct 18 2017
Of course. Done: Issue 776094
,
Oct 18 2017
Not sure, if it's helpful: Fixed issue 593531 for the Toolbar Buttons, Comment 15 says 250 ms is used for both fade-in and fade-out.
,
May 30 2018
,
Aug 7
Not sure, but I think this is fixed under MdRefresh.
,
Aug 14
Agreed.
,
Aug 14
(FYI: This is not an issue under MacViews/MdRefresh.)
,
Aug 14
Thanks. I tagged it Hotlist-CocoaBrowser so that we can revisit it (and probably close it) in a post-MacViews world :-).
,
Aug 14
Okay, thank you.
,
Nov 23
**UI Mass Triage** As per c#15, adding labels for expert review.
,
Nov 23
Old Cocoa Bug. Can't reproduce under MacViews. Closing. |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by meh...@chromium.org
, Oct 17 2017