New issue
Advanced search Search tips

Issue 775582 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Disable website promo for google.com users.

Project Member Reported by jamiewa...@chromium.org, Oct 17 2017

Issue description

We don't want to display the website promo butter-bar for google.com users.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4bb86111bba9ab367e20f30e0404d0231945d3f9

commit 4bb86111bba9ab367e20f30e0404d0231945d3f9
Author: Jamie Walch <jamiewalch@chromium.org>
Date: Tue Oct 17 21:30:09 2017

Disable website promo for google.com users.

Bug:  775582 
Change-Id: I838b3bedf596f9df38668746f1bc6b8235831a6c
Reviewed-on: https://chromium-review.googlesource.com/723750
Commit-Queue: Jamie Walch <jamiewalch@chromium.org>
Reviewed-by: Zijie He <zijiehe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509542}
[modify] https://crrev.com/4bb86111bba9ab367e20f30e0404d0231945d3f9/remoting/webapp/crd/js/butter_bar.js
[modify] https://crrev.com/4bb86111bba9ab367e20f30e0404d0231945d3f9/remoting/webapp/crd/js/butter_bar_unittest.js

Components: Services>Chromoting
Labels: Merge-Request-63 OS-Chrome OS-Linux OS-Mac OS-Windows
This change affects the Chrome Remote Desktop app only, not Chrome browser.
Project Member

Comment 3 by sheriffbot@chromium.org, Oct 18 2017

Labels: -Merge-Request-63 Hotlist-Merge-Approved Merge-Approved-63
Your change meets the bar and is auto-approved for M63. Please go ahead and merge the CL to branch 3239 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by gov...@chromium.org, Oct 18 2017

Please merge your change to M63 branch 3239 by 4:00 PM PT tomorrow, Thursday so we can take it in for next M63 dev release. Thank you.
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 19 2017

Labels: -merge-approved-63 merge-merged-3239
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0c1547320c877f46165f024951836bd8988b403

commit a0c1547320c877f46165f024951836bd8988b403
Author: Jamie Walch <jamiewalch@chromium.org>
Date: Thu Oct 19 00:45:38 2017

Disable website promo for google.com users.

Bug:  775582 
Change-Id: I838b3bedf596f9df38668746f1bc6b8235831a6c
Reviewed-on: https://chromium-review.googlesource.com/723750
Commit-Queue: Jamie Walch <jamiewalch@chromium.org>
Reviewed-by: Zijie He <zijiehe@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#509542}(cherry picked from commit 4bb86111bba9ab367e20f30e0404d0231945d3f9)
Reviewed-on: https://chromium-review.googlesource.com/726753
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#58}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[modify] https://crrev.com/a0c1547320c877f46165f024951836bd8988b403/remoting/webapp/crd/js/butter_bar.js
[modify] https://crrev.com/a0c1547320c877f46165f024951836bd8988b403/remoting/webapp/crd/js/butter_bar_unittest.js

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Verified Fixed in 63.0.3239.17

Sign in to add a comment