New issue
Advanced search Search tips

Issue 775580 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 863026
Owner:
Closed: Sep 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Task

Blocking:
issue 734150



Sign in to add a comment

TabModelTest.AddWithLinkTransitionAndIndex fails CHECK with WKBasedNavigationManager

Project Member Reported by danyao@chromium.org, Oct 17 2017

Issue description

The test fails DCHECK on line 38 because WKBackForwardList is empty when CommitPendingItem() is called:
FATAL:wk_based_navigation_manager_impl.mm(38)] Check failed: wk_item. 

This is because the navigation manager used in test is not associated with a real WKWebView.

0   ios_chrome_unittests                0x000000010399022d base::debug::StackTrace::StackTrace(unsigned long) + 157
1   ios_chrome_unittests                0x000000010399026d base::debug::StackTrace::StackTrace(unsigned long) + 29
2   ios_chrome_unittests                0x000000010398ed2c base::debug::StackTrace::StackTrace() + 28
3   ios_chrome_unittests                0x00000001039ee90f logging::LogMessage::~LogMessage() + 479
4   ios_chrome_unittests                0x00000001039ec465 logging::LogMessage::~LogMessage() + 21
5   ios_chrome_unittests                0x000000010242c994 (anonymous namespace)::SetNavigationItemInWKItem(WKBackForwardListItem*, std::__1::unique_ptr<web::NavigationItemImpl, std::__1::default_delete<web::NavigationItemImpl> >) + 276
6   ios_chrome_unittests                0x000000010242d1ae web::WKBasedNavigationManagerImpl::CommitPendingItem() + 830
7   ios_chrome_unittests                0x0000000101c524e5 (anonymous namespace)::TabModelTest_AddWithLinkTransitionAndIndex_Test::TestBody() + 1157





 

Comment 1 by danyao@chromium.org, Oct 17 2017

Status: Available (was: Unconfirmed)

Comment 2 by danyao@chromium.org, Oct 17 2017

TabModelTest.AddWithOrderControllerAndGrouping failure is for the same reason.

Comment 3 by danyao@chromium.org, Nov 27 2017

Owner: danyao@chromium.org
Status: Started (was: Available)

Comment 4 by danyao@chromium.org, Nov 28 2017

Talked to euegenebut@ and we agreed that the right fix for this test would be to use TestNavigationManager instead.
Mergedinto: 863026
Status: Duplicate (was: Started)

Sign in to add a comment