Issue metadata
Sign in to add a comment
|
browser_tests failing on chromium.mac/Mac10.11 Tests |
||||||||||||||||||||
Issue descriptionbrowser_tests failing on chromium.mac/Mac10.11 Tests Builders failed on: - Mac10.11 Tests: https://build.chromium.org/p/chromium.mac/builders/Mac10.11%20Tests Failing run: https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.11%20Tests/builds/19324 Stack trace of the failure: [ RUN ] DiceBrowserTest.Signin [7888:14375:1017/101543.353034:WARNING:notification_platform_bridge_mac.mm(522)] AlertNotificationService: XPC connection invalidated. ../../chrome/browser/signin/dice_browsertest.cc:364: Failure Value of: GetTokenService()->AreAllCredentialsLoaded() Actual: false Expected: true ../../chrome/browser/signin/dice_browsertest.cc:413: Failure Expected: signin::IsAccountConsistencyDiceEnabled() Which is: true To be equal to: IsReconcilorBlocked() Which is: false ../../chrome/browser/signin/dice_browsertest.cc:425: Failure Expected: signin::IsAccountConsistencyDiceEnabled() Which is: true To be equal to: IsReconcilorBlocked() Which is: false Hey msarda@ I saw that you recently made some changes to dice_browsertest which is failing on mac. Could you take a look at this failure? This could be a flake after your changes. A suspected failure range is https://chromium.googlesource.com/chromium/src/+log/0fce6417f83080af204e28390c52012047dea71c%5E..c320900e1f204c1b3cc038dbffbf6bc851f72d9a?pretty=fuller&n=
,
Oct 20 2017
,
Oct 20 2017
Looking into it. This is not the same failure as the bug mentionned in comment 1.
,
Oct 20 2017
The failure happens during the test setup: // The token service should have loaded all its credentials by the time // |SetUpOnMainThread| is called. Check that here as all tests depend on // the token service being in a stable state. ASSERT_TRUE(GetTokenService()->AreAllCredentialsLoaded()); As a side note, it seems that ASSERT_TRUE did not actually interrupt the test. It probably only interrupted the test setup instead.
,
Oct 20 2017
I now think that this is indeed the same root cause as bug 765093 . That assertion was added recently, and that's why it is not showing up in the older logs.
,
Oct 20 2017
I could repro the issue, and I have a fix: https://chromium-review.googlesource.com/c/chromium/src/+/730732
,
Oct 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d3dbe89043efb0d13ecff8b562d5899eadbb04ae commit d3dbe89043efb0d13ecff8b562d5899eadbb04ae Author: David Roger <droger@chromium.org> Date: Fri Oct 20 19:12:06 2017 [Dice] Fix flakiness in DiceBrowserTest The test now waits for the tokens to be loaded, rather than failing when they are not loaded. Bug: 765093 , 775578 Change-Id: I8dbbae389dd4a60a420a3a58bd4a5fa6d043c4d0 Reviewed-on: https://chromium-review.googlesource.com/730732 Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#510513} [modify] https://crrev.com/d3dbe89043efb0d13ecff8b562d5899eadbb04ae/chrome/browser/signin/dice_browsertest.cc
,
Oct 23 2017
can we close this bug?
,
Oct 23 2017
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by msarda@chromium.org
, Oct 18 2017Owner: droger@chromium.org