Update expected result from osc-sweep-snr-sawtooth.html |
||
Issue descriptionActual result from OSX 10.12.6 (16G29) --- CONSOLE WARNING: line 78: GainNode.gain.value setter smoothing is deprecated and will be removed in M64, around January 2018. Please use setTargetAtTime() instead if smoothing is needed. See https://www.chromestatus.com/features/5287995770929152 for more details. CONSOLE WARNING: line 85: Oscillator.frequency.exponentialRampToValue value 24050 outside nominal range [-22050, 22050]; value will be clamped. This is a testharness.js-based test. PASS # AUDIT TASK RUNNER STARTED. PASS > [test] FAIL X SNR is not greater than or equal to 134.45. Got 134.41635171553918. assert_true: expected true got false PASS Maximum difference is less than or equal to 0.0000010878. FAIL < [test] 1 out of 2 assertions were failed. assert_true: expected true got false FAIL # AUDIT TASK RUNNER FINISHED: 1 out of 1 tasks were failed. assert_true: expected true got false Harness: the test ran to completion. --- Seems like it needs to be rebased.
,
Oct 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/01c19fbe8f63bc84645919bc17ad9d9f2ab25c3b commit 01c19fbe8f63bc84645919bc17ad9d9f2ab25c3b Author: Hongchan Choi <hongchan@chromium.org> Date: Tue Oct 17 20:09:08 2017 Update expected SNR from osc-sweep-snr-sawtooth.html The test has been failing on OSX 10.12.6 (16G29) because of the change in SNR. (134.45 -> 134.41635171553918). This CL fixes the SNR value to pass the test. Bug: 775565 Test: webaudio/Oscillator/osc-sweep-snr-sawtooth.html Change-Id: I9b41e917cab7cb6e36fb5fdc59e0a726e228481d Reviewed-on: https://chromium-review.googlesource.com/723743 Reviewed-by: Raymond Toy <rtoy@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#509498} [modify] https://crrev.com/01c19fbe8f63bc84645919bc17ad9d9f2ab25c3b/third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-sweep-snr-sawtooth.html
,
Oct 18 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by rtoy@chromium.org
, Oct 17 2017