New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 775564 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: 1
NextAction: ----
OS: iOS
Pri: 1
Type: Bug

Blocking:
issue 768876



Sign in to add a comment

[Cronet] Change Cronet builders to explicitly target iOS 9

Project Member Reported by mef@chromium.org, Oct 17 2017

Issue description

Chromium is changing iOS target version to iOS 10, but some Cronet consumers still target iOS 9.

We need to change Cronet build bots (ToTT and official) to explicitly target iOS 9.

See https://crbug.com/768876 for details.
 

Comment 1 by mef@chromium.org, Oct 17 2017

Blocking: 768876
Labels: M-64
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 8 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/0f00deb253886a6a6bd9767dfd0952572a4fa671

commit 0f00deb253886a6a6bd9767dfd0952572a4fa671
Author: Misha Efimov <mef@chromium.org>
Date: Wed Nov 08 22:57:09 2017

Comment 3 by mef@chromium.org, Nov 9 2017

Cc: smut@chromium.org
Owner: mef@chromium.org
Status: Started (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 9 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/9b8b082388b0781459bd7e947081537cb6022981

commit 9b8b082388b0781459bd7e947081537cb6022981
Author: Misha Efimov <mef@chromium.org>
Date: Thu Nov 09 23:16:51 2017

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8cf92945174b57160605052823595578a34f1ab0

commit 8cf92945174b57160605052823595578a34f1ab0
Author: Misha Efimov <mef@chromium.org>
Date: Fri Nov 10 02:15:11 2017

[Cronet] Explicitly set ios_deployment_target = "9.0" in Cronet builds.

Bug:  775564 
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ia042509d3686d501f2b459c1fe03956422b5af4a
Reviewed-on: https://chromium-review.googlesource.com/760487
Commit-Queue: Misha Efimov <mef@chromium.org>
Reviewed-by: smut <smut@google.com>
Cr-Commit-Position: refs/heads/master@{#515422}
[modify] https://crrev.com/8cf92945174b57160605052823595578a34f1ab0/components/cronet/tools/cr_cronet.py
[modify] https://crrev.com/8cf92945174b57160605052823595578a34f1ab0/components/cronet/tools/package_ios.py
[modify] https://crrev.com/8cf92945174b57160605052823595578a34f1ab0/ios/build/bots/chromium.fyi/ios-simulator-cronet.json
[modify] https://crrev.com/8cf92945174b57160605052823595578a34f1ab0/ios/build/bots/chromium.mac/ios-simulator-cronet.json

Comment 6 by mef@chromium.org, Nov 10 2017

Status: Fixed (was: Started)

Sign in to add a comment