New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 775561 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

use lld to build Chrome in ChromeOS

Project Member Reported by yunlian@chromium.org, Oct 17 2017

Issue description

Be want to link Chrome with lld because it is better supported. 
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/8a31a3084740a054e3c522de4a6735f50541cb54

commit 8a31a3084740a054e3c522de4a6735f50541cb54
Author: Yunlian Jiang <yunlian@google.com>
Date: Thu Oct 19 02:08:28 2017

chromeos-chrome: add USE flag lld.

This adds a USE flag 'lld' to enable to use lld as the linker.

BUG= chromium:775561 
TEST=USE="lld -gold" emerge-terra chromeos-chrome.

Change-Id: Ia5eec03a6380c98a11fd9ee2e38219d39ff9630b
Reviewed-on: https://chromium-review.googlesource.com/726267
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/8a31a3084740a054e3c522de4a6735f50541cb54/chromeos-base/chromeos-chrome/metadata.xml
[modify] https://crrev.com/8a31a3084740a054e3c522de4a6735f50541cb54/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/a547e1fb944d4437535f97e84bc445848f723483

commit a547e1fb944d4437535f97e84bc445848f723483
Author: Yunlian Jiang <yunlian@google.com>
Date: Tue Oct 31 08:44:39 2017

lld: update git hash for llvm-next.

We need to update git hash of lld to have it match with llvm. Otherwise,
it fails to build.

BUG= chromium:775561 
TEST=sudo USE="llvm-next" llvm lld

Change-Id: I9a6f9b9d3ce8f477a2c53c5a0d633cb7e6a5576f
Reviewed-on: https://chromium-review.googlesource.com/744595
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Yunlian Jiang <yunlian@chromium.org>

[rename] https://crrev.com/a547e1fb944d4437535f97e84bc445848f723483/sys-devel/lld/lld-5.0_pre305631-r2.ebuild

Status: Fixed (was: Untriaged)
Build the recovery image from scratch and it does the job.
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/18ae998f25f2837859a451bc1e6e3d63a6ea4b86

commit 18ae998f25f2837859a451bc1e6e3d63a6ea4b86
Author: Yunlian Jiang <yunlian@google.com>
Date: Tue Nov 07 01:26:21 2017

Remove lld from NEW_PACKAGES.

The lastest chromiumos-sdk contains lld, so we can remove it from
NEW_PACKAGES. It also adds lld to MANUAL_PKGS, so that lld can be
included in standalone toolchain.

BUG= chromium:775561 
TEST=None

Change-Id: I0ed65443161f5f975efcd4707e251c780a57af63
Reviewed-on: https://chromium-review.googlesource.com/753981
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>

[modify] https://crrev.com/18ae998f25f2837859a451bc1e6e3d63a6ea4b86/scripts/cros_setup_toolchains.py

Comment 5 by dchan@chromium.org, Jan 22 2018

Status: archived (was: Fixed)

Comment 6 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment