Catapult Roll failing Oct. 17th 2017 |
||
Issue descriptionTwo primary causes of the failures: The first is my CL here: https://chromium.googlesource.com/catapult.git/+/28b488dd0fc649d618725c6742b747aeadca5ea0 Which will be fixed with: https://chromium-review.googlesource.com/c/chromium/src/+/723641 The second failure is caused by a failure to import a metric: Traceback (most recent call last): File "/usr/lib/python2.7/unittest/loader.py", line 254, in _find_tests module = self._get_module_from_name(name) File "/usr/lib/python2.7/unittest/loader.py", line 232, in _get_module_from_name __import__(name) File "/b/s/w/ir/tools/perf/measurements/thread_times_unittest.py", line 11, in <module> from measurements import thread_times File "/b/s/w/ir/tools/perf/measurements/thread_times.py", line 7, in <module> from telemetry.web_perf.metrics i which seems likely to be caused by: https://chromium-review.googlesource.com/c/catapult/+/721772 Since my fix is inbound, adding Ned as owner for his CL.
,
Oct 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/27dcb11f0d137172a169fd27b6df14aa21f6f7eb commit 27dcb11f0d137172a169fd27b6df14aa21f6f7eb Author: rnephew <rnephew@chromium.org> Date: Tue Oct 17 19:20:37 2017 [Telemetry] Remove reference to ShouldDisable from telemetry system health smoke test. Bug: 713222, 775560 Change-Id: I720321450eff6bf27c7f0648d9b777a46fb301b7 Reviewed-on: https://chromium-review.googlesource.com/723641 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: rnephew <rnephew@chromium.org> Cr-Commit-Position: refs/heads/master@{#509481} [modify] https://crrev.com/27dcb11f0d137172a169fd27b6df14aa21f6f7eb/tools/perf/benchmarks/system_health_smoke_test.py
,
Oct 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0137a99f3733b43b3708452c406ae3feab5b0da3 commit 0137a99f3733b43b3708452c406ae3feab5b0da3 Author: Ned Nguyen <nednguyen@google.com> Date: Tue Oct 17 20:35:22 2017 Remove layout metrics in thread_times benchmarks These metrics were added a long time ago and seem not very useful. They are also using the legacy TBMv1 metrics structure in a not well supported way. Bug: 775560 , 760553 Change-Id: Iaa824a1fd8bcf9b24214904b33d9e4d730f63a42 Reviewed-on: https://chromium-review.googlesource.com/723919 Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by: Ben Hayden <benjhayden@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#509507} [modify] https://crrev.com/0137a99f3733b43b3708452c406ae3feab5b0da3/tools/perf/measurements/thread_times.py
,
Oct 17 2017
Should be fixed now. Feel free to reopen. |
||
►
Sign in to add a comment |
||
Comment 1 by nedngu...@google.com
, Oct 17 2017