ForceBrowserSignin+RestrictSigninToPattern lockout |
||||||
Issue descriptionWhat steps will reproduce the problem? (1) Start Chrome with fresh user data directory (2) Log into Chrome (3) Exit Chrome (4) Enable ForceBrowserSignin+RestrictSigninToPattern with a non-matching pattern (5) Start Chrome (6) Try to sign into existing profile What is the expected result? There should be a user-understandable message why this failed and how to re-gain access to profile data (talk to your admin to change the policy) and how to delete the profile data. What happens instead? A lapidary message is shown: "Signing in with this username has been disabled by your administrator."
,
Nov 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1dca14a652a24f44247ba4e8c67b04a339850508 commit 1dca14a652a24f44247ba4e8c67b04a339850508 Author: Owen Min <zmin@chromium.org> Date: Fri Nov 03 20:13:18 2017 Blocked used profile when force-sign-in is enabled When force-sign-in is enabled, any profile has been used before can not be used anymore but only deleted. This behavior is used to avoid privacy issue caused by profile merge. Bug: 775546 Change-Id: I37e475407d0f1807500060f550aa9ec97b09c4e0 Reviewed-on: https://chromium-review.googlesource.com/751297 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by: Georges Khalil <georgesak@chromium.org> Reviewed-by: Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#513890} [modify] https://crrev.com/1dca14a652a24f44247ba4e8c67b04a339850508/chrome/browser/ui/webui/signin/login_ui_service.h [modify] https://crrev.com/1dca14a652a24f44247ba4e8c67b04a339850508/chrome/browser/ui/webui/signin/user_manager_screen_handler.cc [modify] https://crrev.com/1dca14a652a24f44247ba4e8c67b04a339850508/chrome/browser/ui/webui/signin/user_manager_ui_browsertest.cc
,
Nov 6 2017
I'd like to merge the above CL to 63 as it address the privacy concern of force-sign-in policy.
,
Nov 6 2017
This bug requires manual review: M63 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 6 2017
Before we approve merge to M63, could you pls confirm followings? Is this M63 regression and critical to merge? Is the change well baked/verified in Canary, having enough automation tests coverage and safe to merge? Any other imp details to justify the merge (probably same answer as comment #3).
,
Nov 7 2017
We're going to extend this feature to anyone who want to try on M63. The CL above address a critical privacy concern. Also, this is a small CL that only affects users with policy enabled. Yes, I have verified it on Canary and the CL comes with a browser test.
,
Nov 7 2017
Approving merge to M63 branch 3239 based on comments #3 and #6. Please merge ASAP so we can take it in for tomorrow's beta release. Thank you.
,
Nov 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3f230e61e6d0e5daaa84f944ac8f22347fbd50d3 commit 3f230e61e6d0e5daaa84f944ac8f22347fbd50d3 Author: Owen Min <zmin@chromium.org> Date: Tue Nov 07 16:21:04 2017 Blocked used profile when force-sign-in is enabled When force-sign-in is enabled, any profile has been used before can not be used anymore but only deleted. This behavior is used to avoid privacy issue caused by profile merge. TBR=zmin@chromium.org (cherry picked from commit 1dca14a652a24f44247ba4e8c67b04a339850508) Bug: 775546 Change-Id: I37e475407d0f1807500060f550aa9ec97b09c4e0 Reviewed-on: https://chromium-review.googlesource.com/751297 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by: Georges Khalil <georgesak@chromium.org> Reviewed-by: Roger Tawa <rogerta@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#513890} Reviewed-on: https://chromium-review.googlesource.com/757179 Reviewed-by: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#406} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/3f230e61e6d0e5daaa84f944ac8f22347fbd50d3/chrome/browser/ui/webui/signin/login_ui_service.h [modify] https://crrev.com/3f230e61e6d0e5daaa84f944ac8f22347fbd50d3/chrome/browser/ui/webui/signin/user_manager_screen_handler.cc [modify] https://crrev.com/3f230e61e6d0e5daaa84f944ac8f22347fbd50d3/chrome/browser/ui/webui/signin/user_manager_ui_browsertest.cc
,
Nov 7 2017
To test team: The error message of profile blocking is "Profile is blocked by enterprise policy" in M63.
,
Nov 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/de3ab0912363a78ed30b355e92c591fb9b12f729 commit de3ab0912363a78ed30b355e92c591fb9b12f729 Author: Owen Min <zmin@chromium.org> Date: Thu Nov 09 22:08:33 2017 Improving error message when a profile is blocked. Bug: 775546 Change-Id: I9573567aeabed8ae6ac28f4538480fa78f32c238 Reviewed-on: https://chromium-review.googlesource.com/761503 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by: Georges Khalil <georgesak@chromium.org> Reviewed-by: Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#515309} [modify] https://crrev.com/de3ab0912363a78ed30b355e92c591fb9b12f729/chrome/app/generated_resources.grd [modify] https://crrev.com/de3ab0912363a78ed30b355e92c591fb9b12f729/chrome/browser/ui/webui/signin/user_manager_screen_handler.cc
,
Nov 17 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by georgesak@chromium.org
, Nov 3 2017Labels: Enterprise-Triaged OS-Linux OS-Windows
Status: Started (was: Untriaged)