Can/should we support 'zero-touch' whitelabel devices |
|||||||||
Issue descriptionAt present with coral we rely on sku id to indicate the model. For whitelabel devices this requires us to have them in the master config in the image that ships with them. Otherwise they boot up and don't know what they are. We could consider putting information in the VPD to allow us to support generic 'whitelabel' devices all with the same SKU ID. We could differentiate among them with keys. I will write up a short doc at some point to discuss the pros and cons of each approach.
,
Oct 17 2017
I'd guess that "partner setting wrong VPD" is equally likely to "partner setting wrong straps", but is easier to fix. Straps have the same issue as cr50-flags - can't be fixed easily if they are inadvertently set wrong.
,
Oct 17 2017
Agreed. But another way to look at that is with VPD someone can potentially wipe it out and put in something different, and this will be harder if strapping is used instead?
,
Oct 17 2017
We can see how Coral goes, but I'd rather think it's easier for partner to set wrong VPD than straps, because they do know it is harder to fix straps. One problem in VPD is that they usually won't provision VPD in the first boot, so you'll need to make your system "able to boot even without VPD set" - and this leads to the result partners are more easily left VPD empty or not set to very end of the manufacturing process (for example only set it in finalization). And, I think the security team did suggest that different OEMs should have a hardware based root-of-trust so we won't provision / allow wrong keys...
,
Oct 17 2017
,
Oct 23 2017
,
Oct 23 2017
After some more discussions, we do need to be able to support this 'zero touch' feature.
,
Oct 25 2017
Hi Simon, please don't commit any changes on this until we've all agreed on a path.
,
Oct 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/firmware/+/82aa3c042c4977e038ea5872a3c0facd847288bd commit 82aa3c042c4977e038ea5872a3c0facd847288bd Author: Simon Glass <sjg@chromium.org> Date: Wed Oct 25 22:44:12 2017 pack_firmware: Refactor a few functions Adjust the implementation of a few functions to make them more flexible. This will make it easier to implement zero-touch whitelabel. BUG= chromium:775543 TEST=PYTHONPATH=~/c python pack_firmware_functest.py Change-Id: I18bd029a3becfa855a3679ed2cd7cc75f75bf787 Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/735333 Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/82aa3c042c4977e038ea5872a3c0facd847288bd/pack_firmware_functest.py
,
Oct 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/b1732aab82b432a02177f1050513390583175609 commit b1732aab82b432a02177f1050513390583175609 Author: Simon Glass <sjg@chromium.org> Date: Fri Oct 27 01:09:23 2017 chromeos-config: Add support for zero-touch whitelabels It seems that we will likely not want to use SKU ID to distinguish whitelabel boards, but instead will write the key ID or other information into the VPD. Add support for this in the binding and validator. BUG= chromium:775543 TEST=FEATURES=test emerge-reef-uni --nodeps chromeos-config-tools Change-Id: I8e1457d164cdea7998f4a8da1dd92a14b4292393 Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/739395 Reviewed-by: Jason Clinton <jclinton@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/b1732aab82b432a02177f1050513390583175609/chromeos-config/README.md [modify] https://crrev.com/b1732aab82b432a02177f1050513390583175609/chromeos-config/validate_config_unittest.py [modify] https://crrev.com/b1732aab82b432a02177f1050513390583175609/chromeos-config/validate_config.py
,
Nov 4 2017
,
Nov 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/firmware/+/b50aa13a2838f6ab017186bf2a9110e5f35408ef commit b50aa13a2838f6ab017186bf2a9110e5f35408ef Author: Simon Glass <sjg@chromium.org> Date: Sat Nov 11 23:52:12 2017 pack_firmware: Implement zero-touch whitelabel support With unified builds the firmware updater currently obtains the signature ID from the setvars.sh script. This requires that the device can determine its model name and use that to run the correct correct script. For zero-touch whitelabel, lots of whitelabel models identify as the same model. In this case we must check VPD customization_id to get the signature ID that was used for signing. Add this feature to the firmware updater and also add a functional test. This should require no changes to mosys. BUG= chromium:775543 TEST=PYTHONPATH=~/c python pack_firmware_functest.py Change-Id: I7a97719d29de8b2cb3aed9a979b71eb8c256acf8 Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/735334 Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/b50aa13a2838f6ab017186bf2a9110e5f35408ef/pack_dist/updater4.sh [modify] https://crrev.com/b50aa13a2838f6ab017186bf2a9110e5f35408ef/functest/vpd [add] https://crrev.com/b50aa13a2838f6ab017186bf2a9110e5f35408ef/functest/vblock_A.ZT2.gz [add] https://crrev.com/b50aa13a2838f6ab017186bf2a9110e5f35408ef/functest/vblock_A.ZT1.gz [add] https://crrev.com/b50aa13a2838f6ab017186bf2a9110e5f35408ef/functest/vblock_B.ZT2.gz [add] https://crrev.com/b50aa13a2838f6ab017186bf2a9110e5f35408ef/functest/rootkey.ZT2 [add] https://crrev.com/b50aa13a2838f6ab017186bf2a9110e5f35408ef/functest/rootkey.ZT1 [modify] https://crrev.com/b50aa13a2838f6ab017186bf2a9110e5f35408ef/pack_firmware.py [modify] https://crrev.com/b50aa13a2838f6ab017186bf2a9110e5f35408ef/test/config_base.dtsi [modify] https://crrev.com/b50aa13a2838f6ab017186bf2a9110e5f35408ef/pack_firmware_functest.py [add] https://crrev.com/b50aa13a2838f6ab017186bf2a9110e5f35408ef/functest/vblock_B.ZT1.gz
,
Nov 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/firmware/+/709a1e472d22fc8a4545ce4fa67cff7f968c86b6 commit 709a1e472d22fc8a4545ce4fa67cff7f968c86b6 Author: Simon Glass <sjg@chromium.org> Date: Tue Nov 14 11:22:32 2017 pack_firmware_functest: Correct signature IDs for whitelabel Unfortunately these names were changed to upper case in the review process due to my getting confused. Change the names back to signature IDs instead of key IDs. BUG= chromium:775543 TEST=PYTHONPATH=~/c python pack_firmware_functest.py Change-Id: I19ddcdbf9a25cb3e3017a7d3d83a9fa42cd54acc Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/766520 Reviewed-by: Jason Clinton <jclinton@chromium.org> [rename] https://crrev.com/709a1e472d22fc8a4545ce4fa67cff7f968c86b6/functest/vblock_A.zt2.gz [rename] https://crrev.com/709a1e472d22fc8a4545ce4fa67cff7f968c86b6/functest/vblock_A.zt1.gz [rename] https://crrev.com/709a1e472d22fc8a4545ce4fa67cff7f968c86b6/functest/vblock_B.zt2.gz [rename] https://crrev.com/709a1e472d22fc8a4545ce4fa67cff7f968c86b6/functest/rootkey.zt2 [rename] https://crrev.com/709a1e472d22fc8a4545ce4fa67cff7f968c86b6/functest/rootkey.zt1 [modify] https://crrev.com/709a1e472d22fc8a4545ce4fa67cff7f968c86b6/pack_firmware_functest.py [rename] https://crrev.com/709a1e472d22fc8a4545ce4fa67cff7f968c86b6/functest/vblock_B.zt1.gz
,
Nov 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/firmware/+/fbe159b2336249f738511087eaf44917d95d43eb commit fbe159b2336249f738511087eaf44917d95d43eb Author: Simon Glass <sjg@chromium.org> Date: Tue Nov 14 11:22:32 2017 pack_firmware_functest: Refactor whitelabel test Move the code into a function and add the model names as parameters. This will allow us to use the same code for the alternative-schema test. BUG= chromium:775543 TEST=PYTHONPATH=~/c python pack_firmware_functest.py Change-Id: Idf43c785862c8f05cfaf8e895bc6c41c7892912f Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/766521 Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/fbe159b2336249f738511087eaf44917d95d43eb/pack_firmware_functest.py
,
Nov 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/mosys/+/d68bc7481f2e087e99590b18171c5ff61406062b commit d68bc7481f2e087e99590b18171c5ff61406062b Author: Simon Glass <sjg@chromium.org> Date: Sat Nov 18 04:18:23 2017 mosys: Use lprintf() instead of lperror() This is actually the correct thing function for printing. This fixes the annoying errno messages displayed. BUG= chromium:775543 BRANCH=none TEST=FEATURES=test emerge-coral mosys Change-Id: I100f14562ffa530064870d706d26bd1611f84280 Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/770650 Reviewed-by: Jason Clinton <jclinton@chromium.org> Reviewed-by: YH Lin <yueherngl@chromium.org> [modify] https://crrev.com/d68bc7481f2e087e99590b18171c5ff61406062b/lib/cros_config/cros_config.c
,
Nov 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/mosys/+/b93209aaaf30e41ce2b5b00ed9c000b669f0d384 commit b93209aaaf30e41ce2b5b00ed9c000b669f0d384 Author: Simon Glass <sjg@chromium.org> Date: Sat Nov 18 04:18:23 2017 mosys: Format the test output properly At present the tests are hard to read, Add a clean message indicating pass or fail after each test, along with a blank line. BUG= chromium:775543 BRANCH=none TEST=manual on robo Change-Id: I99fb3fedb2c4c5c1f643a6a73017d708d376096e Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/770651 Reviewed-by: Jason Clinton <jclinton@chromium.org> Reviewed-by: YH Lin <yueherngl@chromium.org> [modify] https://crrev.com/b93209aaaf30e41ce2b5b00ed9c000b669f0d384/tests/simple_tests.c
,
Nov 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/mosys/+/9e51fcfdd0ac0d197a9cf104af51793557c43e6b commit 9e51fcfdd0ac0d197a9cf104af51793557c43e6b Author: Simon Glass <sjg@chromium.org> Date: Mon Nov 20 16:01:08 2017 mosys: Add a new command to look up the signature ID Currently in the unibuild firmware updater we call 'vpd' to get access to the signature ID. A request was made to use mosys instead. Add a 'mosys platform signature' command to access this. The signature is will be set by the cros_config identity lookup (in the next CL). BUG= chromium:775543 BRANCH=none TEST=manual on robo Change-Id: Ie70c2cd4e0cfc3e4e3b60292ef01c4d6f47f5fdf Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/770652 Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/9e51fcfdd0ac0d197a9cf104af51793557c43e6b/lib/misc/sku.c [modify] https://crrev.com/9e51fcfdd0ac0d197a9cf104af51793557c43e6b/include/lib/sku.h [modify] https://crrev.com/9e51fcfdd0ac0d197a9cf104af51793557c43e6b/platform/reef/sys.c [modify] https://crrev.com/9e51fcfdd0ac0d197a9cf104af51793557c43e6b/include/mosys/platform.h [modify] https://crrev.com/9e51fcfdd0ac0d197a9cf104af51793557c43e6b/core/command/platform.c [modify] https://crrev.com/9e51fcfdd0ac0d197a9cf104af51793557c43e6b/platform/kahlee/sys.c [modify] https://crrev.com/9e51fcfdd0ac0d197a9cf104af51793557c43e6b/platform/fizz/sys.c
,
Nov 20 2017
This is basically complete. Remaining it to use 'mosys platform signature' in the firmware updater.
,
Dec 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/firmware/+/29d4889e1bced1de9c5d5d9ae9ee83ebef5ce40a commit 29d4889e1bced1de9c5d5d9ae9ee83ebef5ce40a Author: Simon Glass <sjg@chromium.org> Date: Mon Dec 11 08:31:46 2017 pack_firmware: Use 'mosys platform signature' to get sig ID We now support reading the signature ID in mosys. Update the firmware updater to use this path for unified builds. This means that vpd is not directly used anymore, but we keep it around to match normal usage of the updater. BUG= chromium:775543 TEST=python pack_firmware_functest.py && python pack_firmware_unittest.py Change-Id: I3fbc6055c3164390a741b2eddcabc7516cb29048 Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/791534 [modify] https://crrev.com/29d4889e1bced1de9c5d5d9ae9ee83ebef5ce40a/functest/bin/mosys [modify] https://crrev.com/29d4889e1bced1de9c5d5d9ae9ee83ebef5ce40a/pack_dist/updater4.sh [modify] https://crrev.com/29d4889e1bced1de9c5d5d9ae9ee83ebef5ce40a/pack_firmware_functest.py [modify] https://crrev.com/29d4889e1bced1de9c5d5d9ae9ee83ebef5ce40a/pack_dist/common.sh [modify] https://crrev.com/29d4889e1bced1de9c5d5d9ae9ee83ebef5ce40a/functest/bin/vpd
,
Dec 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/firmware/+/134c07a8e42e653232102dc63cd6035ebfe965e5 commit 134c07a8e42e653232102dc63cd6035ebfe965e5 Author: Simon Glass <sjg@chromium.org> Date: Mon Dec 11 09:06:29 2017 pack_firmware_functest: Correct signature IDs for whitelabel Unfortunately these names were changed to upper case in the review process due to my getting confused. Change the names back to signature IDs instead of key IDs. BUG= chromium:775543 TEST=PYTHONPATH=~/c python pack_firmware_functest.py Change-Id: I19ddcdbf9a25cb3e3017a7d3d83a9fa42cd54acc Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/766520 Reviewed-by: Jason Clinton <jclinton@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/794607 Commit-Queue: Marco Chen <marcochen@chromium.org> Tested-by: Marco Chen <marcochen@chromium.org> [rename] https://crrev.com/134c07a8e42e653232102dc63cd6035ebfe965e5/functest/vblock_A.zt2.gz [rename] https://crrev.com/134c07a8e42e653232102dc63cd6035ebfe965e5/functest/vblock_A.zt1.gz [rename] https://crrev.com/134c07a8e42e653232102dc63cd6035ebfe965e5/functest/vblock_B.zt2.gz [rename] https://crrev.com/134c07a8e42e653232102dc63cd6035ebfe965e5/functest/rootkey.zt2 [rename] https://crrev.com/134c07a8e42e653232102dc63cd6035ebfe965e5/functest/rootkey.zt1 [modify] https://crrev.com/134c07a8e42e653232102dc63cd6035ebfe965e5/pack_firmware_functest.py [rename] https://crrev.com/134c07a8e42e653232102dc63cd6035ebfe965e5/functest/vblock_B.zt1.gz
,
Dec 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/firmware/+/d119fd0cb9a6695d1825082a4ea91f6426cb98b7 commit d119fd0cb9a6695d1825082a4ea91f6426cb98b7 Author: Simon Glass <sjg@chromium.org> Date: Mon Dec 11 09:06:32 2017 pack_firmware_functest: Refactor whitelabel test Move the code into a function and add the model names as parameters. This will allow us to use the same code for the alternative-schema test. BUG= chromium:775543 TEST=PYTHONPATH=~/c python pack_firmware_functest.py Change-Id: Idf43c785862c8f05cfaf8e895bc6c41c7892912f Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/766521 Reviewed-by: Jason Clinton <jclinton@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/794608 Commit-Queue: Marco Chen <marcochen@chromium.org> Tested-by: Marco Chen <marcochen@chromium.org> [modify] https://crrev.com/d119fd0cb9a6695d1825082a4ea91f6426cb98b7/pack_firmware_functest.py
,
Dec 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/mosys/+/aab695b14dbc4b3e9f52eb4973ea93762376387f commit aab695b14dbc4b3e9f52eb4973ea93762376387f Author: Simon Glass <sjg@chromium.org> Date: Mon Dec 11 09:11:03 2017 mosys: Use lprintf() instead of lperror() This is actually the correct thing function for printing. This fixes the annoying errno messages displayed. BUG= chromium:775543 BRANCH=none TEST=FEATURES=test emerge-coral mosys Change-Id: I100f14562ffa530064870d706d26bd1611f84280 Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/770650 Reviewed-by: Jason Clinton <jclinton@chromium.org> Reviewed-by: YH Lin <yueherngl@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/801476 Commit-Queue: Marco Chen <marcochen@chromium.org> Tested-by: Marco Chen <marcochen@chromium.org> [modify] https://crrev.com/aab695b14dbc4b3e9f52eb4973ea93762376387f/lib/cros_config/cros_config.c
,
Dec 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/mosys/+/3e08863fc07a50c3f3cfb8a6b89d605c3f138b8b commit 3e08863fc07a50c3f3cfb8a6b89d605c3f138b8b Author: Simon Glass <sjg@chromium.org> Date: Mon Dec 11 09:11:06 2017 mosys: Format the test output properly At present the tests are hard to read, Add a clean message indicating pass or fail after each test, along with a blank line. BUG= chromium:775543 BRANCH=none TEST=manual on robo Change-Id: I99fb3fedb2c4c5c1f643a6a73017d708d376096e Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/770651 Reviewed-by: Jason Clinton <jclinton@chromium.org> Reviewed-by: YH Lin <yueherngl@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/801477 Commit-Queue: Marco Chen <marcochen@chromium.org> Tested-by: Marco Chen <marcochen@chromium.org> [modify] https://crrev.com/3e08863fc07a50c3f3cfb8a6b89d605c3f138b8b/tests/simple_tests.c
,
Dec 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/mosys/+/8d95b69b3eeb7119affdd92f996907df76e06da5 commit 8d95b69b3eeb7119affdd92f996907df76e06da5 Author: Simon Glass <sjg@chromium.org> Date: Mon Dec 11 09:11:09 2017 mosys: Add a new command to look up the signature ID Currently in the unibuild firmware updater we call 'vpd' to get access to the signature ID. A request was made to use mosys instead. Add a 'mosys platform signature' command to access this. The signature is will be set by the cros_config identity lookup (in the next CL). BUG= chromium:775543 BRANCH=none TEST=manual on robo Change-Id: Ie70c2cd4e0cfc3e4e3b60292ef01c4d6f47f5fdf Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/770652 Reviewed-by: Jason Clinton <jclinton@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/801478 Commit-Queue: Marco Chen <marcochen@chromium.org> Tested-by: Marco Chen <marcochen@chromium.org> [modify] https://crrev.com/8d95b69b3eeb7119affdd92f996907df76e06da5/lib/misc/sku.c [modify] https://crrev.com/8d95b69b3eeb7119affdd92f996907df76e06da5/include/lib/sku.h [modify] https://crrev.com/8d95b69b3eeb7119affdd92f996907df76e06da5/platform/reef/sys.c [modify] https://crrev.com/8d95b69b3eeb7119affdd92f996907df76e06da5/include/mosys/platform.h [modify] https://crrev.com/8d95b69b3eeb7119affdd92f996907df76e06da5/core/command/platform.c [modify] https://crrev.com/8d95b69b3eeb7119affdd92f996907df76e06da5/platform/kahlee/sys.c [modify] https://crrev.com/8d95b69b3eeb7119affdd92f996907df76e06da5/platform/fizz/sys.c
,
Dec 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/firmware/+/61681646ee4202b29bb83e9e6d3c7d91bc8718d8 commit 61681646ee4202b29bb83e9e6d3c7d91bc8718d8 Author: Simon Glass <sjg@chromium.org> Date: Tue Dec 12 03:51:51 2017 pack_firmware: Use 'mosys platform signature' to get sig ID We now support reading the signature ID in mosys. Update the firmware updater to use this path for unified builds. This means that vpd is not directly used anymore, but we keep it around to match normal usage of the updater. BUG= chromium:775543 TEST=python pack_firmware_functest.py && python pack_firmware_unittest.py Change-Id: I3fbc6055c3164390a741b2eddcabc7516cb29048 Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/791534 Reviewed-on: https://chromium-review.googlesource.com/819390 Reviewed-by: Marco Chen <marcochen@chromium.org> Commit-Queue: Marco Chen <marcochen@chromium.org> Tested-by: Marco Chen <marcochen@chromium.org> [modify] https://crrev.com/61681646ee4202b29bb83e9e6d3c7d91bc8718d8/pack_dist/updater4.sh [modify] https://crrev.com/61681646ee4202b29bb83e9e6d3c7d91bc8718d8/functest/mosys [modify] https://crrev.com/61681646ee4202b29bb83e9e6d3c7d91bc8718d8/pack_firmware_functest.py [modify] https://crrev.com/61681646ee4202b29bb83e9e6d3c7d91bc8718d8/functest/vpd [modify] https://crrev.com/61681646ee4202b29bb83e9e6d3c7d91bc8718d8/pack_dist/common.sh
,
Dec 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/firmware/+/23b403ad0c187fe10ab1afff61f699a07fd1b9e6 commit 23b403ad0c187fe10ab1afff61f699a07fd1b9e6 Author: Simon Glass <sjg@chromium.org> Date: Wed Dec 20 03:29:05 2017 pack_firmware: Use 'mosys platform signature' to get sig ID We now support reading the signature ID in mosys. Update the firmware updater to use this path for unified builds. This means that vpd is not directly used anymore, but we keep it around to match normal usage of the updater. BUG= chromium:775543 , chromium:793923 TEST=python pack_firmware_functest.py && python pack_firmware_unittest.py Reviewed-on: https://chromium-review.googlesource.com/791534 Change-Id: I3fbc6055c3164390a741b2eddcabc7516cb29048 Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/832950 Reviewed-by: Marco Chen <marcochen@chromium.org> Commit-Queue: Marco Chen <marcochen@chromium.org> Tested-by: Marco Chen <marcochen@chromium.org> [modify] https://crrev.com/23b403ad0c187fe10ab1afff61f699a07fd1b9e6/pack_dist/updater4.sh [modify] https://crrev.com/23b403ad0c187fe10ab1afff61f699a07fd1b9e6/functest/mosys [modify] https://crrev.com/23b403ad0c187fe10ab1afff61f699a07fd1b9e6/pack_firmware_functest.py [modify] https://crrev.com/23b403ad0c187fe10ab1afff61f699a07fd1b9e6/functest/vpd [modify] https://crrev.com/23b403ad0c187fe10ab1afff61f699a07fd1b9e6/pack_dist/common.sh
,
Jan 2 2018
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by hungte@chromium.org
, Oct 17 2017