This bug requires manual review: DEPS changes referenced in bugdroid comments.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)
For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
This ***also*** breaks on Windows. Win7 Tests (dbg)(1) is failing on media/video-controls-focus-movement-on-hide.html
I'm going to disable this. Please address this.
The virtual/new-remote-playback-pipeline/media/controls/closed-captions-dynamic-update.html flavor is failing too. Since the previous attempt at marking it as failing didn't work, I'm marking it as "skip". Hope that works.
The CL that needs to be merged is the one in comment #7. It's a large CL but that's because we needed to update a large amount of tests. The CL is otherwise safe as it's turning on by default a feature that has been running 50/50 on Canary and Dev for a while now.
govind@, no we don't. Usually, turning on the feature doesn't require approval even if keeping it in Beta will require approval. It may be hard to merge it later but I'm happy to only turn it on via Finch if needed.
As follow up, you may want to consider addressing issue 842900 soon after (or preferably, before) the new player controls reach Stable.
Reason being that an age-old bug introduced years ago in Chrome is made worse by the new controls being considerably bigger than before, and bigger than most other browsers' controls.
Details at 842900, but in a nut shell: The media player in Chrome has a bug that makes it exceed the HTML element's boundary box. It both honours and ignores the dimensions and overflow settings at the same time, which is a problem. It honors 'height' and 'overflow hidden' for the element's own box, but then ignores it when rendering the player. The end result is that the player can overlap other content, causing accessibility and UX problems.
Other browsers, including Safari, do not suffer from this bug. They either resize/crop the player to match the box's real dimensions, or they grow the box's dimensions to match the player. Either way, there mustn't be a situation where it renders controls outside the box in a way that overlaps other content on the page.
Comment 1 by beccahughes@chromium.org
, Dec 19 2017