New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 775526 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug

Blocking:
issue 751556



Sign in to add a comment

ForceBrowserSignin crashes on "create new profile" choice

Project Member Reported by tnagel@chromium.org, Oct 17 2017

Issue description

Chrome Version: 0a5db00071313bb4b74d95b4e4f441f520123b8b-refs/heads/master@{#509375}

What steps will reproduce the problem?
(1) Set ForceBrowserSignin: false
(2) Start Chrome with fresh profile directory and close it again
(3) Set ForceBrowserSignin: true
(4) Start Chrome and log into the existing profile with a managed account
(5) On the "Link your Chrome data" screen, select "create a new profile"
(6) On the profile picker screen, click on the new profile and sign in
(7) Click "Link data"

--> crash

[9808:9808:1017/173339.316078:FATAL:user_cloud_policy_manager.cc(66)] Check failed: !core()->client(). 
#0 0x7f13b7fa8ce7 base::debug::StackTrace::StackTrace()
#1 0x7f13b7fc7a31 logging::LogMessage::~LogMessage()
#2 0x7f13b416eb66 policy::UserCloudPolicyManager::Connect()
#3 0x559bddcf4755 policy::UserPolicySigninServiceBase::InitializeUserCloudPolicyManager()
#4 0x559bddcf3871 policy::UserPolicySigninService::InitializeUserCloudPolicyManager()
#5 0x559bddcf41ab policy::UserPolicySigninServiceBase::FetchPolicyForSignedInUser()
#6 0x559bde91c19e OneClickSigninSyncStarter::LoadPolicyWithCachedCredentials()
#7 0x559bde91c07c OneClickSigninSyncStarter::SigninDialogDelegate::OnContinueSignin()
#8 0x559bdea1455a ProfileSigninConfirmationDialogViews::ButtonPressed()
#9 0x7f13b3c35025 views::Button::OnMouseReleased()
#10 0x7f13b3c248b1 views::InkDropHostView::OnMouseEvent()
#11 0x7f13b45ce563 ui::EventDispatcher::ProcessEvent()
#12 0x7f13b45ce30a ui::EventDispatcherDelegate::DispatchEvent()
#13 0x7f13b3c9932a views::internal::RootView::OnMouseReleased()
#14 0x7f13b3c9e644 views::Widget::OnMouseEvent()
#15 0x7f13b45ce563 ui::EventDispatcher::ProcessEvent()
#16 0x7f13b45ce30a ui::EventDispatcherDelegate::DispatchEvent()
#17 0x7f13b45cf1be ui::EventProcessor::OnEventFromSource()
#18 0x7f13b45cf4d6 ui::EventSource::SendEventToSink()
#19 0x7f13b3cc4219 views::DesktopWindowTreeHostX11::DispatchMouseEvent()
#20 0x7f13b3cc5363 views::DesktopWindowTreeHostX11::DispatchEvent()
#21 0x7f13b3cc557d views::DesktopWindowTreeHostX11::DispatchEvent()
#22 0x7f13b73d6a75 ui::PlatformEventSource::DispatchEvent()
#23 0x7f13acc952fc ui::X11EventSource::ExtractCookieDataDispatchEvent()
#24 0x7f13acc952ad ui::X11EventSource::DispatchXEvents()
#25 0x7f13acc98179 ui::(anonymous namespace)::XSourceDispatch()
#26 0x7f13af543ce5 g_main_context_dispatch
#27 0x7f13af544048 <unknown>
#28 0x7f13af5440ec g_main_context_iteration
#29 0x7f13b7fd1063 base::MessagePumpGlib::Run()
#30 0x7f13b7ff64d5 base::RunLoop::Run()
#31 0x559bddb10382 ChromeBrowserMainParts::MainMessageLoopRun()
#32 0x7f13b5d9da92 content::BrowserMainLoop::RunMainMessageLoopParts()
#33 0x7f13b5da086d content::BrowserMainRunnerImpl::Run()
#34 0x7f13b5d99958 content::BrowserMain()
#35 0x7f13b6462422 content::ContentMainRunnerImpl::Run()
#36 0x7f13b847b444 service_manager::Main()
#37 0x7f13b6460f62 content::ContentMain()
#38 0x559bdd7661c4 ChromeMain
#39 0x7f13aced4f45 __libc_start_main
#40 0x559bdd766029 <unknown>

Received signal 6
#0 0x7f13b7fa8ce7 base::debug::StackTrace::StackTrace()
#1 0x7f13b7fa884f base::debug::(anonymous namespace)::StackDumpSignalHandler()
#2 0x7f13b80b2330 <unknown>
#3 0x7f13acee9c37 gsignal
#4 0x7f13aceed028 abort
#5 0x7f13b7fa63f2 base::debug::BreakDebugger()
#6 0x7f13b7fc7e23 logging::LogMessage::~LogMessage()
#7 0x7f13b416eb66 policy::UserCloudPolicyManager::Connect()
#8 0x559bddcf4755 policy::UserPolicySigninServiceBase::InitializeUserCloudPolicyManager()
#9 0x559bddcf3871 policy::UserPolicySigninService::InitializeUserCloudPolicyManager()
#10 0x559bddcf41ab policy::UserPolicySigninServiceBase::FetchPolicyForSignedInUser()
#11 0x559bde91c19e OneClickSigninSyncStarter::LoadPolicyWithCachedCredentials()
#12 0x559bde91c07c OneClickSigninSyncStarter::SigninDialogDelegate::OnContinueSignin()
#13 0x559bdea1455a ProfileSigninConfirmationDialogViews::ButtonPressed()
#14 0x7f13b3c35025 views::Button::OnMouseReleased()
#15 0x7f13b3c248b1 views::InkDropHostView::OnMouseEvent()
#16 0x7f13b45ce563 ui::EventDispatcher::ProcessEvent()
#17 0x7f13b45ce30a ui::EventDispatcherDelegate::DispatchEvent()
#18 0x7f13b3c9932a views::internal::RootView::OnMouseReleased()
#19 0x7f13b3c9e644 views::Widget::OnMouseEvent()
#20 0x7f13b45ce563 ui::EventDispatcher::ProcessEvent()
#21 0x7f13b45ce30a ui::EventDispatcherDelegate::DispatchEvent()
#22 0x7f13b45cf1be ui::EventProcessor::OnEventFromSource()
#23 0x7f13b45cf4d6 ui::EventSource::SendEventToSink()
#24 0x7f13b3cc4219 views::DesktopWindowTreeHostX11::DispatchMouseEvent()
#25 0x7f13b3cc5363 views::DesktopWindowTreeHostX11::DispatchEvent()
#26 0x7f13b3cc557d views::DesktopWindowTreeHostX11::DispatchEvent()
#27 0x7f13b73d6a75 ui::PlatformEventSource::DispatchEvent()
#28 0x7f13acc952fc ui::X11EventSource::ExtractCookieDataDispatchEvent()
#29 0x7f13acc952ad ui::X11EventSource::DispatchXEvents()
#30 0x7f13acc98179 ui::(anonymous namespace)::XSourceDispatch()
#31 0x7f13af543ce5 g_main_context_dispatch
#32 0x7f13af544048 <unknown>
#33 0x7f13af5440ec g_main_context_iteration
#34 0x7f13b7fd1063 base::MessagePumpGlib::Run()
#35 0x7f13b7ff64d5 base::RunLoop::Run()
#36 0x559bddb10382 ChromeBrowserMainParts::MainMessageLoopRun()
#37 0x7f13b5d9da92 content::BrowserMainLoop::RunMainMessageLoopParts()
#38 0x7f13b5da086d content::BrowserMainRunnerImpl::Run()
#39 0x7f13b5d99958 content::BrowserMain()
#40 0x7f13b6462422 content::ContentMainRunnerImpl::Run()
#41 0x7f13b847b444 service_manager::Main()
#42 0x7f13b6460f62 content::ContentMain()
#43 0x559bdd7661c4 ChromeMain
#44 0x7f13aced4f45 __libc_start_main
#45 0x559bdd766029 <unknown>
  r8: ffffa8098a5fc9f0  r9: ffffa8098a5fc9e0 r10: 0000000000000008 r11: 0000000000000206
 r12: 00007fffaaed8aa0 r13: 0000000000000067 r14: 00007fffaaed8a98 r15: 00007fffaaed8a90
  di: 0000000000002650  si: 0000000000002650  bp: 00007fffaaed8630  bx: 00007fffaaed8630
  dx: 0000000000000006  ax: 0000000000000000  cx: 00007f13acee9c37  sp: 00007fffaaed8488
  ip: 00007f13acee9c37 efl: 0000000000000206 cgf: 0000000000000033 erf: 0000000000000000
 trp: 0000000000000000 msk: 0000000000000000 cr2: 0000000000000000

 

Comment 1 by zmin@chromium.org, Nov 6 2017

This is not an issue for now after https://chromium.googlesource.com/chromium/src/+/1dca14a652a24f44247ba4e8c67b04a339850508

As all sign in with force-sign-in enabled will be done on a fresh profile without 'create new profile' option.

I'll leave the issue open as I still want to fix this issue.
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53078c4b7a340af06b08927a4bb0727901aff622

commit 53078c4b7a340af06b08927a4bb0727901aff622
Author: Owen Min <zmin@chromium.org>
Date: Thu Nov 09 18:13:24 2017

Revert of "Sign out user if it's not sign in during profile loaded"

This is the revert of crrev.com/b77864ad82e7b7a5dc0c547aa2ab879d311db98e
Turns out that fix causes  crbug.com/775526 .
In the mean time, revert won't re-trigger the  crbug.com/759007  as it's
fixed by crrev.com/9990e87e486cceef3914bcbb82979190315bad3a.

Bug:  759007 
Bug:  775526 
Change-Id: I2cd5acefb3d8588613629a99dde592f648650a93
Reviewed-on: https://chromium-review.googlesource.com/757718
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515211}
[modify] https://crrev.com/53078c4b7a340af06b08927a4bb0727901aff622/chrome/browser/profiles/profile_manager.cc

Comment 3 by zmin@chromium.org, Nov 13 2017

I have verified the fixed on Canary.

Now, after user click ""create a new profile", the creds will be automatically 
transfer into the new profile, the old profile will be locked.

Comment 4 by zmin@chromium.org, Nov 13 2017

Cc: georgesak@chromium.org
Labels: Merge-Request-63 OS-Windows
I'd like to merge this CL to 63 as it will affects anyone who want to try out the force-sign-in policy on 63.

Comment 5 by zmin@chromium.org, Nov 13 2017

Cc: blumberg@chromium.org
Project Member

Comment 6 by sheriffbot@chromium.org, Nov 13 2017

Labels: -Merge-Request-63 Merge-Review-63 Hotlist-Merge-Review
This bug requires manual review: Reverts referenced in bugdroid comments after merge request.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by gov...@chromium.org, Nov 13 2017

Labels: -Merge-Review-63 Merge-Approved-63
Approving merge to M63 branch 3239 based on comments #3 and #4. Please merge ASAP so we can take it in for this week beta release. Thank you.
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 14 2017

Labels: -merge-approved-63 merge-merged-3239
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/529510efa03236c73784fe51e73cb984e41ddd1e

commit 529510efa03236c73784fe51e73cb984e41ddd1e
Author: Owen Min <zmin@chromium.org>
Date: Tue Nov 14 00:42:24 2017

[Merge 63]Revert of "Sign out user if it's not sign in during profile loaded"

This is the revert of crrev.com/b77864ad82e7b7a5dc0c547aa2ab879d311db98e
Turns out that fix causes  crbug.com/775526 .
In the mean time, revert won't re-trigger the  crbug.com/759007  as it's
fixed by crrev.com/9990e87e486cceef3914bcbb82979190315bad3a.

TBR=zmin@chromium.org

(cherry picked from commit 53078c4b7a340af06b08927a4bb0727901aff622)

Bug:  759007 
Bug:  775526 
Change-Id: I2cd5acefb3d8588613629a99dde592f648650a93
Reviewed-on: https://chromium-review.googlesource.com/757718
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#515211}
Reviewed-on: https://chromium-review.googlesource.com/767907
Reviewed-by: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#476}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[modify] https://crrev.com/529510efa03236c73784fe51e73cb984e41ddd1e/chrome/browser/profiles/profile_manager.cc

Comment 9 by zmin@chromium.org, Nov 14 2017

Status: Fixed (was: Untriaged)

Sign in to add a comment