Issue metadata
Sign in to add a comment
|
Regression: Magic Trackpad 2 Pinch to Zoom is resistant to triggering
Reported by
liqu...@gmail.com,
Oct 17 2017
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3242.0 Safari/537.36 Steps to reproduce the problem: KEY Detail: This only occurs with Magic Trackpad 2 (bluetooth). It does not occur with the MBP builtin trackpad. I have not tested with Magic Trackpad 1 or other. 1. Go to any website. 2. Attempt to pinch to zoom in a relatively 'lazy' way such as: - using the second and 4th fingers, or - putting the second finger down slightly after the first, or - doing a slight rotation motion as you zoom. 3. Zoom does not trigger in Canary 63-64 (also 62 I think), but does easily trigger in Chrome 61 and below. What is the expected behavior? Zoom should trigger easily, as it does in Chrome 61 and below, and as it does in all other apps. What went wrong? Zoom does not trigger in Canary 63-64, but does easily trigger in Chrome 61 and below. Did this work before? Yes 61.0.3163.100 Chrome version: 64.0.3242.0 Channel: canary OS Version: OS X 10.12.6 Flash Version: I have tried adjusting many trackpad settings including resetting all to the default, and I have tried A/B testing on many web pages, and the problem is consistently reproducible and nothing fixes it. It is also isolated to Chrome Canary and to the Magic Trackpad 2 only.
,
Oct 17 2017
,
Oct 18 2017
@MTV Team-- Requesting someone from MTV team to look into this as inhouse team doesn't have the Magic Trackpad 2 (bluetooth). Thanks!
,
Oct 18 2017
Note: My Chrome just updated to 62 and 62 DOES have this defect. So, in order to see the desired behavior, you will have to roll back to 61 or earlier.
,
Nov 1 2017
+erikchen@ who's touched some input stuff recently and might also know how to route.
,
Nov 2 2017
It would be very helpful if TEs could get a bisect for this problem.
,
Nov 6 2017
I can verify this on my MacBook Pro (Retina, 15-inch, Mid 2015), so probably it's not isolated on Magic Trackpad 2.
Got the update for version 62.0.3202.75 on 26/10 and I find it difficult triggering zoom.
Chrome Version : 62.0.3202.75
Other browsers tested:
Safari 11: OK
Firefox 56.0.2: OK
macOS Version: 10.12.6 (16G29)
,
Nov 6 2017
Thanks, yes it may be an issue beyond Magic Trackpad 2, but it seems to be even significantly worse on Magic Trackpad 2.
,
Nov 22 2017
Able to reproduce the issue on the latest canary(64.0.3275.0) and the latest stable: 62.0.3202.94 on Mac OS 10.12.6. Test steps followed: ====================== 1. Opened yahoo.com 2. Scrolled and while page is scrolling tried pinch zooming. 3. Pinch zoom is stuck. Regressed in M-62. Last good build: 62.0.3187.0 First bad build: 62.0.3188.0 Changelog: ========== https://chromium.googlesource.com/chromium/src/+log/5babdbfc2c14ba67a3890e6a0da88cfe13683b7c..1baa30bc4249c61e4f08907fcfdf09ba2a7a8a99 Erik@: Could you please take a look at this. Note: Tagging with M-63 stable blocker as this stops pinch to zoom working on Mac and if possible get the fix(when available) merged to M-63 branch.
,
Nov 27 2017
Gentle Ping, Request you to please take a look into as issue is tagged with a stable blocker and M63 is set to be pushed to stable soon. Thanks.!
,
Nov 28 2017
cc'ing Jayson since Erik is OOO.
,
Nov 28 2017
Hm. I was able to confirm this, just need a new MBP device to calibrate the settings. I won't have access to one until I get back next week. Will that be too late?
,
Nov 28 2017
We're cutting M63 stable RC this Friday, 12/01. As this was regressed in M62, I'm not going to block M63 for this. Please let me know ASAP if there is any concern here. Thank you.
,
Nov 28 2017
I think that's the right call.
,
Dec 4 2017
Friendly ping to get an update on this issue as it is marked as stable blocker.
,
Dec 11 2017
erikchen@ Gentle ping to get an update on this issue as it is marked as stable blocker. Thanks..!
,
Dec 18 2017
Friendly ping to get an update on this issue.
,
Dec 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/90bb84f64d90a32aee6f2d7534bdfe8c2000b7f1 commit 90bb84f64d90a32aee6f2d7534bdfe8c2000b7f1 Author: Erik Chen <erikchen@chromium.org> Date: Wed Dec 20 17:53:51 2017 macOS: Fix handling of end gesture events. Logic intended only to be run for magnify events was firing for scroll wheel events. This made it very difficult to magnify. Bug: 775522 Change-Id: I1b55c1ec2f6d86ff1c6c39c3f1361d9036f54adb Reviewed-on: https://chromium-review.googlesource.com/833498 Reviewed-by: Robert Sesek <rsesek@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#525367} [modify] https://crrev.com/90bb84f64d90a32aee6f2d7534bdfe8c2000b7f1/content/browser/renderer_host/render_widget_host_view_mac.mm [modify] https://crrev.com/90bb84f64d90a32aee6f2d7534bdfe8c2000b7f1/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm [modify] https://crrev.com/90bb84f64d90a32aee6f2d7534bdfe8c2000b7f1/content/browser/site_per_process_mac_browsertest.mm
,
Jan 4 2018
Can we please confirm if this has been fixed? If this has been fixed and verified in Canary/Dev and is a safe merge overall, we should consider merging to M64 as it's marked as a stable blocker.
,
Jan 4 2018
This is working fine on the latest canary(#65.0.3311.0) on Mac OS 10.12.6 as per the steps mentioned in C#9. Hence adding the verified label.
,
Jan 8 2018
+ Abdul for M64 merge review.
,
Jan 17 2018
erikchen@, can you please comment on c#19?
,
Jan 22 2018
erikchen@, Friendly ping to get an update on this issue as per C#19. Thanks..!
,
Jan 23 2018
I would avoid merges, as this isn't critical for functionality.
,
Jan 23 2018
[Auto-generated comment by a script] We noticed that this issue is targeted for M-64; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-64 label, otherwise remove Merge-TBD label. Thanks.
,
Jan 23 2018
Great, thanks! Removing Merge-TBD since seems like we should just aim for M65.
,
Jan 23 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by meh...@chromium.org
, Oct 17 2017