New issue
Advanced search Search tips

Issue 775519 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 768986
Owner:
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Add metrics for PDF forms

Project Member Reported by rharrison@chromium.org, Oct 17 2017

Issue description

Add metric collection for type of XFA forms being seen in PDFs.
 
Summary: Add metrics for PDF forms (was: Add metric for PDF XFA)
Mergedinto: 768986
Status: Duplicate (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 18 2017

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/854d71c1420eb80ec79755a6cdf829f3f39aead7

commit 854d71c1420eb80ec79755a6cdf829f3f39aead7
Author: Ryan Harrison <rharrison@chromium.org>
Date: Wed Oct 18 16:41:35 2017

Refactor HasXFAField into HasFormInfo

The existing API is too restrictive for collection the metrics
information that we want. Specifically it only tells us if there are
XFA forms in the document, but not AcroForms. This refactoring makes
the method more general, so that non-XFA information is provided
also. This change in semantics of the return value required some
changes at the call sites of the API.

BUG= chromium:775519 

Change-Id: Id421c66c09b47196c252c64cdc2c711ca1911de0
Reviewed-on: https://pdfium-review.googlesource.com/16210
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>

[modify] https://crrev.com/854d71c1420eb80ec79755a6cdf829f3f39aead7/fpdfsdk/cpdfsdk_widget.cpp
[modify] https://crrev.com/854d71c1420eb80ec79755a6cdf829f3f39aead7/fpdfsdk/fpdfformfill_embeddertest.cpp
[modify] https://crrev.com/854d71c1420eb80ec79755a6cdf829f3f39aead7/xfa/fxfa/cxfa_ffdocview.cpp
[modify] https://crrev.com/854d71c1420eb80ec79755a6cdf829f3f39aead7/fpdfsdk/fpdfformfill.cpp
[modify] https://crrev.com/854d71c1420eb80ec79755a6cdf829f3f39aead7/xfa/fxfa/cxfa_ffdoc.h
[modify] https://crrev.com/854d71c1420eb80ec79755a6cdf829f3f39aead7/samples/pdfium_test.cc
[modify] https://crrev.com/854d71c1420eb80ec79755a6cdf829f3f39aead7/fpdfsdk/fpdfxfa/cpdfxfa_context.cpp
[modify] https://crrev.com/854d71c1420eb80ec79755a6cdf829f3f39aead7/fpdfsdk/fpdfxfa/cpdfxfa_page.cpp
[modify] https://crrev.com/854d71c1420eb80ec79755a6cdf829f3f39aead7/testing/embedder_test.cpp
[modify] https://crrev.com/854d71c1420eb80ec79755a6cdf829f3f39aead7/public/fpdf_formfill.h
[modify] https://crrev.com/854d71c1420eb80ec79755a6cdf829f3f39aead7/fpdfsdk/cpdfsdk_widgethandler.cpp
[modify] https://crrev.com/854d71c1420eb80ec79755a6cdf829f3f39aead7/fpdfsdk/fpdfview_c_api_test.c
[modify] https://crrev.com/854d71c1420eb80ec79755a6cdf829f3f39aead7/fpdfsdk/fpdfsave.cpp
[modify] https://crrev.com/854d71c1420eb80ec79755a6cdf829f3f39aead7/xfa/fxfa/fxfa.h
[modify] https://crrev.com/854d71c1420eb80ec79755a6cdf829f3f39aead7/fpdfsdk/fpdfxfa/cpdfxfa_context.h
[modify] https://crrev.com/854d71c1420eb80ec79755a6cdf829f3f39aead7/fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.cpp
[modify] https://crrev.com/854d71c1420eb80ec79755a6cdf829f3f39aead7/fpdfsdk/javascript/app.cpp
[modify] https://crrev.com/854d71c1420eb80ec79755a6cdf829f3f39aead7/fpdfsdk/cpdfsdk_pageview.cpp
[modify] https://crrev.com/854d71c1420eb80ec79755a6cdf829f3f39aead7/fpdfsdk/fpdfview.cpp
[modify] https://crrev.com/854d71c1420eb80ec79755a6cdf829f3f39aead7/xfa/fxfa/cxfa_ffdoc.cpp

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 21 2017

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/0e568818249ff83d239b98cbb32dec94358da0c7

commit 0e568818249ff83d239b98cbb32dec94358da0c7
Author: Ryan Harrison <rharrison@chromium.org>
Date: Sat Oct 21 06:17:49 2017

Add in count value for form types

BUG= chromium:775519 , chromium:768986 

Adding metric form types

Change-Id: Ic99a5ac988998986f06cb79d08458afeda49a5d1
Reviewed-on: https://pdfium-review.googlesource.com/16392
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>

[modify] https://crrev.com/0e568818249ff83d239b98cbb32dec94358da0c7/xfa/fxfa/fxfa.h
[modify] https://crrev.com/0e568818249ff83d239b98cbb32dec94358da0c7/public/fpdf_formfill.h

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f356d15100553db7552f7e7906a88d13030d2976

commit f356d15100553db7552f7e7906a88d13030d2976
Author: pdfium-deps-roller@chromium.org <pdfium-deps-roller@chromium.org>
Date: Sat Oct 21 09:38:43 2017

Roll src/third_party/pdfium/ d78ef3b7c..0e5688182 (1 commit)

https://pdfium.googlesource.com/pdfium.git/+log/d78ef3b7c943..0e568818249f

$ git log d78ef3b7c..0e5688182 --date=short --no-merges --format='%ad %ae %s'
2017-10-21 rharrison Add in count value for form types

Created with:
  roll-dep src/third_party/pdfium
BUG= 775519 , 768986 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: I446b059876fac382f6dc439fdfa35312456abf41
Reviewed-on: https://chromium-review.googlesource.com/732149
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510676}
[modify] https://crrev.com/f356d15100553db7552f7e7906a88d13030d2976/DEPS

Sign in to add a comment