New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 775518 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Add flag to enable NTLMv2

Project Member Reported by zentaro@chromium.org, Oct 17 2017

Issue description

Add a flag and policy so that the NTLMv2 feature can be optionally enabled (ie. NTLMv1 disabled)

In future the the default will be made NTLMv2 and the flag will be removed.
 
Cc: robertshield@chromium.org pastarmovj@chromium.org georgesak@chromium.org blumberg@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bad511c1ebe2ab281d6260a1b1ac50c613236add

commit bad511c1ebe2ab281d6260a1b1ac50c613236add
Author: Zentaro Kavanagh <zentaro@google.com>
Date: Wed Oct 18 22:29:00 2017

Add policy and flag to control NTLMv2 status.

- The default is currently that NTLMv2 is disabled (ie. using NTLMv1)
- A future release will make the default NTLMv2 enabled.

Bug:  chromium:22532 , chromium:775518 
Change-Id: Icb554af932ef1d30b0e9a3cc8cedfea915bd2074
Reviewed-on: https://chromium-review.googlesource.com/673206
Commit-Queue: Zentaro Kavanagh <zentaro@google.com>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Drew Wilson <atwilson@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509897}
[modify] https://crrev.com/bad511c1ebe2ab281d6260a1b1ac50c613236add/chrome/browser/about_flags.cc
[modify] https://crrev.com/bad511c1ebe2ab281d6260a1b1ac50c613236add/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/bad511c1ebe2ab281d6260a1b1ac50c613236add/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/bad511c1ebe2ab281d6260a1b1ac50c613236add/chrome/browser/io_thread.cc
[modify] https://crrev.com/bad511c1ebe2ab281d6260a1b1ac50c613236add/chrome/browser/io_thread.h
[modify] https://crrev.com/bad511c1ebe2ab281d6260a1b1ac50c613236add/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/bad511c1ebe2ab281d6260a1b1ac50c613236add/chrome/common/chrome_features.cc
[modify] https://crrev.com/bad511c1ebe2ab281d6260a1b1ac50c613236add/chrome/common/chrome_features.h
[modify] https://crrev.com/bad511c1ebe2ab281d6260a1b1ac50c613236add/chrome/common/pref_names.cc
[modify] https://crrev.com/bad511c1ebe2ab281d6260a1b1ac50c613236add/chrome/common/pref_names.h
[modify] https://crrev.com/bad511c1ebe2ab281d6260a1b1ac50c613236add/chrome/test/data/policy/policy_test_cases.json
[modify] https://crrev.com/bad511c1ebe2ab281d6260a1b1ac50c613236add/components/policy/resources/policy_templates.json
[modify] https://crrev.com/bad511c1ebe2ab281d6260a1b1ac50c613236add/net/http/http_auth_handler_ntlm.cc
[modify] https://crrev.com/bad511c1ebe2ab281d6260a1b1ac50c613236add/net/http/http_auth_handler_ntlm.h
[modify] https://crrev.com/bad511c1ebe2ab281d6260a1b1ac50c613236add/net/http/http_auth_handler_ntlm_portable.cc
[modify] https://crrev.com/bad511c1ebe2ab281d6260a1b1ac50c613236add/net/http/http_auth_preferences.cc
[modify] https://crrev.com/bad511c1ebe2ab281d6260a1b1ac50c613236add/net/http/http_auth_preferences.h
[modify] https://crrev.com/bad511c1ebe2ab281d6260a1b1ac50c613236add/net/http/http_auth_preferences_unittest.cc
[modify] https://crrev.com/bad511c1ebe2ab281d6260a1b1ac50c613236add/tools/metrics/histograms/enums.xml

Hello, when can we expect this bug to be fixed in an official version? One of our customers has a number of Mac computers that are impacted by this bug. We would be happy to beta test this bug with you.

Thanks
As of right now in Chrome 64 you can enable NTLMv2 via chrome://flags though NTLMv1 is still the default. I'm currently looking to get the flag moved to Chrome 63 (the actual functionality is already in 63 but a user just can't enable it) but that is still TBD.

Labels: -M-63 M-64
Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/543aba0b33f022312ed3a9f0f20de94c123e6b95

commit 543aba0b33f022312ed3a9f0f20de94c123e6b95
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Thu Feb 15 01:58:57 2018

Update policy text for enabling NTLMv2.

- Remove the text that indicated that the default was false.
- The default was changed but the text was not updated.

BUG= chromium:775518 

Change-Id: I869b471a9b3772543c5e67824d41c9fcaa17eb8c
Reviewed-on: https://chromium-review.googlesource.com/917655
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536925}
[modify] https://crrev.com/543aba0b33f022312ed3a9f0f20de94c123e6b95/components/policy/resources/policy_templates.json

In M-64 I still can see the text that indicated that the default was false:

"The default value when this policy is not defined is currently false for backwards compatability, but will change to true in the future."

The same in M-65 and M-66 as well.

zentaro@:

Could you please clarify what is the expected text? "If this policy is not set, the default is true and NTLMv2 is enabled."?
The text was updating with the commit in comment #6. Unfortunately, I didn't see the incorrect text until later after the string's deadline. So the text is incorrect in M64 but correct in M65. ie. the 65 text should have been in 64.
Status: Verified (was: Fixed)
Verified fixed. The following text is present:

"If this policy is not set, the default is true and NTLMv2 is enabled."

The NTLMv2 policy flag can be changed via chrome://flags.

Chrome OS: 10452.1.0
Chrome: 66.0.3359.10
Device: Santa

Sign in to add a comment