New issue
Advanced search Search tips

Issue 775509 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Restrict generation context menu item only to non passphrase sync users

Project Member Reported by melandory@chromium.org, Oct 17 2017

Issue description

Generation fallback in the context menu shouldn't be shown for non Sync users.
 

Comment 1 Deleted

Labels: -M-64 M-63

Comment 4 Deleted

Labels: Merge-Request-63
Project Member

Comment 6 by sheriffbot@chromium.org, Oct 19 2017

Labels: -Merge-Request-63 Hotlist-Merge-Approved Merge-Approved-63
Your change meets the bar and is auto-approved for M63. Please go ahead and merge the CL to branch 3239 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 19 2017

Labels: -merge-approved-63 merge-merged-3239
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73d16270fac6f7660e867123abda9761da60981f

commit 73d16270fac6f7660e867123abda9761da60981f
Author: Tatiana Gornak <melandory@chromium.org>
Date: Thu Oct 19 09:48:08 2017

Restrict generation context menu item only to non passphrase sync users

BUG= 739343 ,  775509 
TBR=melandory@chromium.org

(cherry picked from commit 8c7026ba04c426e4f66d3e7b4f42203671c87570)

Change-Id: I7f9b42cadd63c55c5b59d9787f6a41ff0742a556
Reviewed-on: https://chromium-review.googlesource.com/707436
Commit-Queue: Tatiana Gornak <melandory@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#509459}
Reviewed-on: https://chromium-review.googlesource.com/727763
Reviewed-by: Tatiana Gornak <melandory@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#65}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[modify] https://crrev.com/73d16270fac6f7660e867123abda9761da60981f/chrome/browser/renderer_context_menu/render_view_context_menu.cc
[modify] https://crrev.com/73d16270fac6f7660e867123abda9761da60981f/components/password_manager/core/browser/password_manager_util.cc
[modify] https://crrev.com/73d16270fac6f7660e867123abda9761da60981f/components/password_manager/core/browser/password_manager_util.h
[modify] https://crrev.com/73d16270fac6f7660e867123abda9761da60981f/components/password_manager/core/common/experiments.cc
[modify] https://crrev.com/73d16270fac6f7660e867123abda9761da60981f/components/password_manager/core/common/experiments.h

Status: Fixed (was: Assigned)

Sign in to add a comment