New issue
Advanced search Search tips

Issue 775508 link

Starred by 1 user
Status: Fixed
Owner:
gambard@chromium.org
Closed: Oct 2017
Cc:
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Task



Sign in to add a comment

Use copy instead of assign for blocks in RecentTabsHandsetCoordinator

Project Member Reported by gambard@chromium.org, Oct 17 2017 
RecentTabsHandsetCoordinator as a block property with an assign memory attribute. It should be a copy.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51058e681025614621ca3c6cfb30e8e7c1dd8ab5

commit 51058e681025614621ca3c6cfb30e8e7c1dd8ab5
Author: Gauthier Ambard <gambard@chromium.org>
Date: Tue Oct 17 14:33:26 2017

Change assign to copy for block property

RecentTabsHandsetCoordinator should retain its block property.

Bug:  775508 
Change-Id: Ifd9bd829786592adde9057bec68bf3a73b6c9fc2
Reviewed-on: https://chromium-review.googlesource.com/723304
Reviewed-by: Jean-François Geyelin <jif@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509383}
[modify] https://crrev.com/51058e681025614621ca3c6cfb30e8e7c1dd8ab5/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_handset_coordinator.mm

Comment 2 by gambard@chromium.org, Oct 17 2017

Labels: Merge-Request-63
Status: Fixed (was: Assigned)

Comment 3 by gambard@chromium.org, Oct 17 2017

Labels: -Pri-3 Pri-1
Project Member

Comment 4 by sheriffbot@chromium.org, Oct 18 2017

Labels: -Merge-Request-63 Hotlist-Merge-Approved Merge-Approved-63
Your change meets the bar and is auto-approved for M63. Please go ahead and merge the CL to branch 3239 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 18 2017

Labels: -merge-approved-63 merge-merged-3239
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a80e60e678e872eb5fe8ed091b045f05be20eddd

commit a80e60e678e872eb5fe8ed091b045f05be20eddd
Author: Gauthier Ambard <gambard@chromium.org>
Date: Wed Oct 18 15:05:27 2017

Change assign to copy for block property

RecentTabsHandsetCoordinator should retain its block property.

Bug:  775508 
Change-Id: Ifd9bd829786592adde9057bec68bf3a73b6c9fc2
Reviewed-on: https://chromium-review.googlesource.com/723304
Reviewed-by: Jean-François Geyelin <jif@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#509383}(cherry picked from commit 51058e681025614621ca3c6cfb30e8e7c1dd8ab5)
Reviewed-on: https://chromium-review.googlesource.com/726119
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#51}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[modify] https://crrev.com/a80e60e678e872eb5fe8ed091b045f05be20eddd/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_handset_coordinator.mm
►

Sign in to add a comment