New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 775504 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
no longer active
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Mac
Pri: 1
Type: Bug



Sign in to add a comment

CHECK failure: frames <= frames_ in audio_buffer_queue.cc

Project Member Reported by ClusterFuzz, Oct 17 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5188817291313152

Fuzzer: inferno_flicker
Job Type: windows_asan_chrome
Platform Id: windows

Crash Type: CHECK failure
Crash Address: 
Crash State:
  frames <= frames_ in audio_buffer_queue.cc
  media::AudioBufferQueue::SeekFrames
  media::AudioRendererAlgorithm::RemoveOldInputFrames
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_chrome&range=509279:509282

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5188817291313152

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Oct 17 2017

Labels: OS-Mac OS-Android OS-Linux
Project Member

Comment 2 by ClusterFuzz, Oct 17 2017

Components: Internals>Media
Labels: Test-Predator-AutoComponents
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 3 by ClusterFuzz, Oct 17 2017

Labels: Test-Predator-AutoOwner
Owner: apaci...@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/12d98c254b1c715ec1bae498ac730b2b2fe5469e (Throw an exception if media playbackRate is out of range.).

If this is incorrect, please remove the owner and apply the Test-Predator-Wrong-CLs label.
Cc: apaci...@chromium.org sande...@chromium.org
Labels: M-64
Owner: dalecur...@chromium.org
This is probably my change to enable > 16x playback rates.
Err, > 4x audible playback rates :)
Project Member

Comment 6 by ClusterFuzz, Oct 17 2017

Labels: ClusterFuzz-Top-Crash ReleaseBlock-Beta
Testcase 5188817291313152 is a top crash on ClusterFuzz for windows platform. Please prioritize fixing this crash.

Marking this crash as a Beta release blocker.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Cc: -apaci...@chromium.org dalecur...@chromium.org
Owner: apaci...@chromium.org
Actually Jennifer this is yours. You're not clamping the playback rate if it exceeds the bounds we previously enforced. Can you fix HTMLMediaElement to clamp the values again?

This test case is allowing through a playbackRate of 2.35296e+19 :)
Status: Started (was: Assigned)
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e8640ef2559184ce1022caa134a2398a7a30c57

commit 9e8640ef2559184ce1022caa134a2398a7a30c57
Author: Jennifer Apacible <apacible@chromium.org>
Date: Fri Oct 20 03:20:34 2017

Clamp values for playbackRate in HTMLMediaElement.

Previous change removed clamping for non-experimental case.

Bug:  775504 ,  775504 ,  775829 ,  775501 ,  747082 
Change-Id: I90eec1b3e99b2370ccd05669c3160399ca235bbc
Reviewed-on: https://chromium-review.googlesource.com/727119
Commit-Queue: apacible <apacible@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510318}
[modify] https://crrev.com/9e8640ef2559184ce1022caa134a2398a7a30c57/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/9e8640ef2559184ce1022caa134a2398a7a30c57/third_party/WebKit/Source/core/html/media/HTMLMediaElement.cpp

Status: Fixed (was: Started)
Project Member

Comment 11 by ClusterFuzz, Oct 26 2017

ClusterFuzz has detected this issue as fixed in range 510178:511643.

Detailed report: https://clusterfuzz.com/testcase?key=5188817291313152

Fuzzer: inferno_flicker
Job Type: windows_asan_chrome
Platform Id: windows

Crash Type: CHECK failure
Crash Address: 
Crash State:
  frames <= frames_ in audio_buffer_queue.cc
  media::AudioBufferQueue::SeekFrames
  media::AudioRendererAlgorithm::RemoveOldInputFrames
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_chrome&range=509279:509282
Fixed: https://clusterfuzz.com/revisions?job=windows_asan_chrome&range=510178:511643

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5188817291313152

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 12 by ClusterFuzz, Oct 26 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5188817291313152 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Labels: -Test-Predator-AutoComponents Test-Predator-Auto-Components
Labels: -Test-Predator-AutoOwner Test-Predator-Auto-Owner

Sign in to add a comment