Issue metadata
Sign in to add a comment
|
40kb regression in resource_sizes (MonochromePublic.apk) at 508871:508871 |
||||||||||||||||||||
Issue descriptionCaused by v8 roll Commit: e37d0e2a9577f5ecf9d466f516b3b3ee4d3609e4
,
Oct 17 2017
diagnose_bloat.py results:
Diff Summary
+16384 bytes MonochromePublic.apk_Specifics normalized apk size for range: 6576495f3a7a07adece5f4689019c6f2f71dc439..1560988249c97c5cc1763aa364a0423f9e318c13
+8192 bytes MonochromePublic.apk_Specifics normalized apk size for range: 217de927fbe9dfd356f49d5ba8c1145d7b161f1f..b4deef6168bea22be807a9305540dcd4a630e4eb
+4096 bytes MonochromePublic.apk_Specifics normalized apk size for range: 18b8fbb528a8021e04a029e06eafee50b918bce0..ed6f00fb8e19c541f0a8927222be13eeee89a82c
+4096 bytes MonochromePublic.apk_Specifics normalized apk size for range: dde4cbb0b10450bb952bf07f88e40fb54e857561..6ff68255e9e74cd0e2ae51bcfc33002605851ba6
+4096 bytes MonochromePublic.apk_Specifics normalized apk size for range: 9d9048db536c19803d43130f88e13901d7051d44..183eb36b88bc7acff7b02f930db56c2c76acc3e6
+4096 bytes MonochromePublic.apk_Specifics normalized apk size for range: 14bfa18b4526454d78d94a2670eb330385b2ed20..1c5529993dfd0afd3545708a41896456c0d25d70
+4096 bytes MonochromePublic.apk_Specifics normalized apk size for range: 1117da834c8d29ea6e92a734d001fdeed1d4a61e..9fdb8c8255ea1c9d9867d5266fe433b9155c49da
+4096 bytes MonochromePublic.apk_Specifics normalized apk size for range: 28ef8dc7009d57de2782668ed00dff34e31dee2d..e34debaf2b27edb867d8058da1cff19f82c7225f
+4096 bytes MonochromePublic.apk_Specifics normalized apk size for range: d5b29f43dee50b31e7c895ba791b7cdcba3300a6..5ea95febb0fa5232f366784b555502f825a3f4dc
+4096 bytes MonochromePublic.apk_Specifics normalized apk size for range: b93406199853a8b79d8105a035ebe70773143c1d..b5acda73ff21a96eaef3bef1ab58945c6499ad5a
+4096 bytes MonochromePublic.apk_Specifics normalized apk size for range: efd7c5949b3a427a9ed4c14fc0e0f6914528db79..3384a793e0bcb495f5c2695ce3bf9d77be83e89b
+0 bytes MonochromePublic.apk_Specifics normalized apk size for range: a5565227f2a5eb3821570ab340999817c7d17e77..cc237d872b2e0533e97219d7a5aba7ae53e89386
1560988249c97c5cc1763aa364a0423f9e318c13 is "[bigint] Support BigInts in <<,>>,>>>,&,|,^ binary ops"
b4deef6168bea22be807a9305540dcd4a630e4eb is "[turbofan] Add deopt reason to CheckIf"
Symbol diff for 6576495f3a7a07adece5f4689019c6f2f71dc439..1560988249c97c5cc1763aa364a0423f9e318c13:
+ 0) 804 (18.7%) t@0x1198340 804 (0->804) v8/src/objects/bigint.cc
v8::internal::BigInt::BitwiseXor
+ 1) 1580 (36.7%) t@0x1198664 776 (0->776) v8/src/objects/bigint.cc
v8::internal::BigInt::BitwiseOr
+ 2) 2314 (53.7%) t@0x1197fc4 734 (0->732) v8/src/objects/bigint.cc
v8::internal::BigInt::BitwiseAnd
+ 3) 2822 (65.5%) t@0x1197b46 508 (0->508) v8/src/objects/bigint.cc
v8::internal::BigInt::RightShiftByAbsolute
+ 4) 3294 (76.4%) t@0x1197d42 472 (0->472) v8/src/objects/bigint.cc
v8::internal::BigInt::LeftShiftByAbsolute
+ 5) 3730 (86.5%) t@0x1198e54 436 (0->436) v8/src/objects/bigint.cc
v8::internal::BigInt::AbsoluteBitwiseOp
~ 6) 3528 (81.9%) t@Group -202 (0->0) {{no path}}
** symbol gaps (count=9)
+ 7) 3688 (85.6%) t@0x11982a0 160 (0->160) v8/src/objects/bigint.cc
v8::internal::BigInt::AbsoluteAddOne
~ 8) 3760 (87.2%) t@0x120bb90 72 (316->388) v8/src/runtime/runtime-bigint.cc
v8::internal::Runtime_BigIntBinaryOp
~ 9) 3812 (88.4%) t@0x120bd14 52 (564->616) v8/src/runtime/runtime-bigint.cc
v8::internal::Stats_Runtime_BigIntBinaryOp
+ 10) 3862 (89.6%) t@0x1197f48 50 (0->50) v8/src/objects/bigint.cc
v8::internal::BigInt::UnsignedRightShift
+ 11) 3908 (90.7%) t@0x1197b18 46 (0->46) v8/src/objects/bigint.cc
v8::internal::BigInt::LeftShift
+ 12) 3954 (91.7%) t@0x1197f1a 46 (0->46) v8/src/objects/bigint.cc
v8::internal::BigInt::SignedRightShift
+ 13) 3990 (92.6%) R@0x2c45280 36 (0->36) v8/src/objects/bigint.cc
std::__ndk1::__function::__func [vtable]
+ 14) 4026 (93.4%) R@0x2c452a4 36 (0->36) v8/src/objects/bigint.cc
std::__ndk1::__function::__func [vtable]
+ 15) 4062 (94.2%) R@0x2c452c8 36 (0->36) v8/src/objects/bigint.cc
std::__ndk1::__function::__func [vtable]
+ 16) 4098 (95.1%) R@0x2c452ec 36 (0->36) v8/src/objects/bigint.cc
std::__ndk1::__function::__func [vtable]
+ 17) 4124 (95.7%) t@0x119925c 26 (0->24) v8/src/objects/bigint.cc
std::__ndk1::__function::__func::__clone const
+ 18) 4148 (96.2%) t@0x11991f8 24 (0->24) v8/src/objects/bigint.cc
std::__ndk1::__function::__func::__clone const
+ 19) 4172 (96.8%) t@0x1199228 24 (0->24) v8/src/objects/bigint.cc
std::__ndk1::__function::__func::__clone const
Symbol diff for 217de927fbe9dfd356f49d5ba8c1145d7b161f1f..b4deef6168bea22be807a9305540dcd4a630e4eb:
~ 0) 2916 (49.1%) t@0x10493f8 2916 (11340->14256) v8/src/compiler/simplified-operator.cc
v8::internal::compiler::SimplifiedOperatorGlobalCache::SimplifiedOperatorGlobalCache
+ 1) 3628 (61.0%) t@0x10484b4 712 (0->712) v8/src/compiler/simplified-operator.cc
v8::internal::compiler::SimplifiedOperatorBuilder::CheckIf
~ 2) 3829 (64.4%) r@Group 201 (2901543->2901744) {{no path}}
** merge strings (count=7)
+ 3) 3884 (65.3%) r@0x0 55 (0->0) {{no path}}
** aggregate padding of diff'ed symbols
+ 4) 3934 (66.2%) t@0x104cbd8 50 (0->48) v8/src/compiler/simplified-operator.cc
v8::internal::compiler::Operator1::PrintParameter const
+ 5) 3966 (66.7%) R@0x2c33e4c 32 (0->32) v8/src/compiler/common-operator.cc
v8::internal::compiler::CommonOperatorGlobalCache::DeoptimizeIfOperator [vtable]
+ 6) 3998 (67.3%) R@0x2c33e6c 32 (0->32) v8/src/compiler/common-operator.cc
v8::internal::compiler::CommonOperatorGlobalCache::DeoptimizeIfOperator [vtable]
+ 7) 4030 (67.8%) R@0x2c33e8c 32 (0->32) v8/src/compiler/common-operator.cc
v8::internal::compiler::CommonOperatorGlobalCache::DeoptimizeIfOperator [vtable]
+ 8) 4062 (68.3%) R@0x2c33ecc 32 (0->32) v8/src/compiler/common-operator.cc
v8::internal::compiler::CommonOperatorGlobalCache::DeoptimizeIfOperator [vtable]
- 9) 4030 (67.8%) R@0x0 -32 (32->0) v8/src/compiler/common-operator.cc
v8::internal::compiler::CommonOperatorGlobalCache::DeoptimizeIfOperator [vtable]
- 10) 3998 (67.3%) R@0x0 -32 (32->0) v8/src/compiler/common-operator.cc
v8::internal::compiler::CommonOperatorGlobalCache::DeoptimizeIfOperator [vtable]
- 11) 3966 (66.7%) R@0x0 -32 (32->0) v8/src/compiler/common-operator.cc
v8::internal::compiler::CommonOperatorGlobalCache::DeoptimizeIfOperator [vtable]
- 12) 3934 (66.2%) R@0x0 -32 (32->0) v8/src/compiler/common-operator.cc
v8::internal::compiler::CommonOperatorGlobalCache::DeoptimizeIfOperator [vtable]
+ 13) 3966 (66.7%) R@0x2c33d8c 32 (0->32) v8/src/compiler/common-operator.cc
v8::internal::compiler::CommonOperatorGlobalCache::DeoptimizeOperator [vtable]
+ 14) 3998 (67.3%) R@0x2c33dec 32 (0->32) v8/src/compiler/common-operator.cc
v8::internal::compiler::CommonOperatorGlobalCache::DeoptimizeOperator [vtable]
+ 15) 4030 (67.8%) R@0x2c33e0c 32 (0->32) v8/src/compiler/common-operator.cc
v8::internal::compiler::CommonOperatorGlobalCache::DeoptimizeOperator [vtable]
+ 16) 4062 (68.3%) R@0x2c33e2c 32 (0->32) v8/src/compiler/common-operator.cc
v8::internal::compiler::CommonOperatorGlobalCache::DeoptimizeOperator [vtable]
- 17) 4030 (67.8%) R@0x0 -32 (32->0) v8/src/compiler/common-operator.cc
v8::internal::compiler::CommonOperatorGlobalCache::DeoptimizeOperator [vtable]
- 18) 3998 (67.3%) R@0x0 -32 (32->0) v8/src/compiler/common-operator.cc
v8::internal::compiler::CommonOperatorGlobalCache::DeoptimizeOperator [vtable]
- 19) 3966 (66.7%) R@0x0 -32 (32->0) v8/src/compiler/common-operator.cc
...
From what I can tell, the increase here is just due to a good amount of code being added. CC'ing CL authors as FYI, but closing as Won't Fix.
,
Oct 18 2017
Makes sense. It's a bit sad that it adds up to 40KB, but I guess that's just what happens when new features are added to the platform...
,
Oct 19 2017
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Oct 17 2017