New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 775501 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
no longer active
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Use-of-uninitialized-value in media::internal::DecimatedSearch

Project Member Reported by ClusterFuzz, Oct 17 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4509144219648000

Fuzzer: inferno_flicker
Job Type: linux_msan_chrome
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  media::internal::DecimatedSearch
  media::internal::OptimalIndex
  media::AudioRendererAlgorithm::GetOptimalBlock
  
Sanitizer: memory (MSAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=linux_msan_chrome&range=509280:509282

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4509144219648000

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Oct 17 2017

Components: Internals>Media
Labels: Test-Predator-AutoComponents
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Oct 17 2017

Labels: Test-Predator-AutoOwner
Owner: apaci...@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/12d98c254b1c715ec1bae498ac730b2b2fe5469e (Throw an exception if media playbackRate is out of range.).

If this is incorrect, please remove the owner and apply the Test-Predator-Wrong-CLs label.

Comment 3 by tsepez@chromium.org, Oct 17 2017

Labels: M-63
Project Member

Comment 4 by sheriffbot@chromium.org, Oct 18 2017

Labels: -Security_Impact-Head Security_Impact-Beta
Project Member

Comment 5 by sheriffbot@chromium.org, Oct 18 2017

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by sheriffbot@chromium.org, Oct 18 2017

Labels: Pri-1
Status: Started (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e8640ef2559184ce1022caa134a2398a7a30c57

commit 9e8640ef2559184ce1022caa134a2398a7a30c57
Author: Jennifer Apacible <apacible@chromium.org>
Date: Fri Oct 20 03:20:34 2017

Clamp values for playbackRate in HTMLMediaElement.

Previous change removed clamping for non-experimental case.

Bug:  775504 ,  775504 ,  775829 ,  775501 ,  747082 
Change-Id: I90eec1b3e99b2370ccd05669c3160399ca235bbc
Reviewed-on: https://chromium-review.googlesource.com/727119
Commit-Queue: apacible <apacible@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510318}
[modify] https://crrev.com/9e8640ef2559184ce1022caa134a2398a7a30c57/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/9e8640ef2559184ce1022caa134a2398a7a30c57/third_party/WebKit/Source/core/html/media/HTMLMediaElement.cpp

Project Member

Comment 9 by ClusterFuzz, Oct 20 2017

ClusterFuzz has detected this issue as fixed in range 510298:510324.

Detailed report: https://clusterfuzz.com/testcase?key=4509144219648000

Fuzzer: inferno_flicker
Job Type: linux_msan_chrome
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  media::internal::DecimatedSearch
  media::internal::OptimalIndex
  media::AudioRendererAlgorithm::GetOptimalBlock
  
Sanitizer: memory (MSAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=linux_msan_chrome&range=509280:509282
Fixed: https://clusterfuzz.com/revisions?job=linux_msan_chrome&range=510298:510324

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4509144219648000

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 10 by ClusterFuzz, Oct 20 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Started)
ClusterFuzz testcase 4509144219648000 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 11 by sheriffbot@chromium.org, Oct 22 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -ReleaseBlock-Stable M-64
Labels: -Test-Predator-AutoComponents Test-Predator-Auto-Components
Labels: -Test-Predator-AutoOwner Test-Predator-Auto-Owner
Project Member

Comment 15 by sheriffbot@chromium.org, Jan 27 2018

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 16 by sheriffbot@chromium.org, Mar 27 2018

Labels: -Security_Impact-Beta -M-64 -M-63 M-65 Security_Impact-Stable

Sign in to add a comment