[views::Combobox] OnComboboxModelChanged should trigger re-painting |
|||
Issue descriptionAt this point, Combobox::ModelChanged doesn't trigger any repainting. The model is a list of items in the combobox. Once the list changed, the combobox should be re-painted, shouldn't it? msw@: please explain whether I am wrong or not. Thx.
,
Oct 17 2017
We need it for issue 753806. When a user click on the eye icon, the passwords in the combobox become masked/revealed. The combobox may be closed, but the selected item changes appearance. Does it make sense? I have call repaint here https://chromium-review.googlesource.com/c/chromium/src/+/723319/5/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc#597
,
Oct 17 2017
Ah, you mean what's shown when the combobox is closed; sorry for misunderstanding. Yeah, I suppose Combobox::ModelChanged() could call SchedulePaint() internally.
,
Oct 17 2017
Will you have a chance to fix it?
,
Oct 17 2017
This seems simple enough to include in your existing patch set, I'll review.
,
Oct 18 2017
I am going to merge https://chromium-review.googlesource.com/c/chromium/src/+/723319 to M-63. To keep things safer, I will do in a separate CL that affects on all comboboxes.
,
Oct 19 2017
,
Nov 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/053f61ae949484a98b834541ffd51307ca678713 commit 053f61ae949484a98b834541ffd51307ca678713 Author: Maxim Kolosovskiy <kolos@chromium.org> Date: Fri Nov 03 16:39:36 2017 [Views][Combobox] Schedule re-paint once a combobox model has changed Bug: 775496 Change-Id: I0a1a6884f57cfa3a587a0b02da6cadb437a03fb8 Reviewed-on: https://chromium-review.googlesource.com/727886 Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#513801} [modify] https://crrev.com/053f61ae949484a98b834541ffd51307ca678713/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc [modify] https://crrev.com/053f61ae949484a98b834541ffd51307ca678713/ui/views/controls/combobox/combobox.cc
,
Nov 3 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by msw@chromium.org
, Oct 17 2017Owner: kolos@chromium.org