New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 775488 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Arrow pointer is seen for 'Rotate','Download','Print' & 'Bookmarks' options in 'General Info' page

Project Member Reported by mmanchala@chromium.org, Oct 17 2017

Issue description

Chrome Version:  63.0.3239.7/10032.4.0 dev-channel Daisy,Candy and Reks
OS: Chrome

What steps will reproduce the problem?
(1)Sign into User -> Download any PDF file
(2)Now go to Files App -> Select downloaded PDF 
(3)Right click on it and select 'Get info' option ->In Get Info page hover mouse at  'Rotate','Download','Print' & 'Bookmarks' options -> Observe Arrow pointer (Please refer Video and Screenshot)

Expected: On hovering mouse at 'Rotate','Download','Print' & 'Bookmarks' hand pointer should be seen
Actual: Instead Arrow pointer is seen

This is Regression Issue as same is working fine in M-61

@fukino : Please confirm the Issue

Note : Issue is seen on latest M-64 also
 
Actual_ArrowPointer.webm
1.2 MB View Download
Actual_Arrowpointer.jpg
291 KB View Download
Expected_Handpointer.jpg
370 KB View Download

Comment 1 by fukino@chromium.org, Nov 30 2017

Cc: fukino@chromium.org
Owner: yamaguchi@chromium.org
Cc: oka@chromium.org
Status: Started (was: Assigned)
I don't think this is a recent regression. This could also observed in M62.
It seems to be dependent on user's profile, but still unsure.

No repro on:
- Chromebook Pixel 2 / 62.0.3202.97 / 9901.77.0 / Google_Samus.6300.174.0 / regular user
- Chromebook Pixel 2 / 62.0.3202.97 / 9901.77.0 / Google_Samus.6300.174.0 / Guest Mode
- Chromebook Plus / 64.0.3281.0 / 10104.0.0 / Google_Kevin.8785.220.0 / regular user
- Chromebook Pixel / 62.0.3182.0 / 9692.0 / Google_Link.2695.1.169 / regular useruser
- Acer Chromebook R11 / 62.0.3202.97 / 9901.77.0 / Google_Cyan.7287.57.125 / regular user
- Acer Chromebook R11 / 62.0.3202.97 / 9901.77.0 / Google_Cyan.7287.57.125 / Guest Mode
Repro on:
- Chromebook Pixel / 62.0.3182.0 / 9692.0 / Google_Link.2695.1.169 / Guest Mode
- Chromebook Plus / 64.0.3281.0 / 10104.0.0 / Google_Kevin.8785.220.0 / Guest Mode
- chrome on ChromeOS (my Linux workstation) / 64.0.3280.0 / with login manager enabled

+oka@
Were there any related changes to QuickView that might affect this?
Components: -Platform>Apps>FileManager Internals>Plugins>PDF Internals>Skia>PDF
Routing to PDF component as the buttons are also hosted in the webview.
Components: Platform>Apps>FileManager
Components: -Internals>Plugins>PDF -Internals>Skia>PDF
My list in #2 seems all red herring. I will take a further look.
This happens after hovering mouse pointer above the padding around the webview area of the quick view.
When running on Linux, it looks like the webview appears slowly so that it's hovering on the blank part of the quick view once, thus it sometimes triggers without that movement.
By this reason I think this is likely to be related to Quick View in the Files app.
Screencast 2017-11-30 17:49:04.mp4
222 KB View Download
Cc: aval...@chromium.org
Components: -Platform>Apps>FileManager
Owner: lfg@chromium.org
Status: Assigned (was: Started)
I found this happens when cross-process-guests flag is enabled.
I confirmed this stops to happen when I disable cross-process-guests at about://flags.

It is happening since this commit point, which seems to have enabled the flag.
https://chromium.googlesource.com/chromium/src/+/a3fd83c8e17555d176368f36a7108ed3c2365691
Reviewed-on: https://chromium-review.googlesource.com/591628

To lfg@: Will you fill in the right Components value and take a look?
Components: Platform>Apps>FileManager Internals>Plugins>PDF
+Platform>Apps>FileManager to Components because this is causing regression of the app.
+Internals>Plugins>PDF as a tentative Components, because it sounded relevant to the issue.
Cc: weifangsun@chromium.org
Just a note - I don't think this qualifies as a release blocker?
Comment 2 says this is already happening in Chrome 62. I don't think this is RBS. The difference is fairly subtle so now many people will even notice.

Comment 13 by lfg@chromium.org, Dec 6 2017

Components: Platform>Apps>BrowserTag
Labels: -ReleaseBlock-Stable

Comment 14 by lfg@chromium.org, Dec 15 2017

Cc: lfg@chromium.org
Owner: wjmaclean@chromium.org
I won't have enough time to investigate this in the short term, assigning to James for triage.
Cc: creis@chromium.org
I noticed that the files app loads the PDF into the WebView via a blob:chrome-extension://... url, ... is this due to the fact that WebView doesn't allow loading file:// URLs directly?

It seems none of the mouseover cursor transitions work when the PDF is loaded this way, but they do work when the PDF is loaded (via a web URL) into a WebView (e.g. BrowserSample app).

+creis@ since the file:// issue seems relevant here too.
Labels: Needs-Feedback
fukino@ - Re c#15 ... would an appview tag make more sense for this use case?

https://developer.chrome.com/apps/tags/appview


Confirmed that disabling cross-process-frames-for-guests stops the regression from occurring.
Status: Started (was: Assigned)

Comment 19 by kenrb@chromium.org, Jan 23 2018

Cc: wjmaclean@chromium.org kenrb@chromium.org riajiang@chromium.org rbasuvula@chromium.org nyerramilli@chromium.org sadrul@chromium.org
 Issue 802197  has been merged into this issue.
Project Member

Comment 20 by bugdroid1@chromium.org, Jan 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9fc8f44f974c5103ef70c670e2b5e6d1a4160efc

commit 9fc8f44f974c5103ef70c670e2b5e6d1a4160efc
Author: W. James MacLean <wjmaclean@chromium.org>
Date: Tue Jan 23 21:23:40 2018

RenderWidgetHostViewGuest was never wired to CursorManager.

The CL updates RWHVG to use CursorManager when updating its
cursor.

Bug:  775488 
Change-Id: I5534aa04c78d27db2d22ccc4134c66fa1f9ea4af
Reviewed-on: https://chromium-review.googlesource.com/879322
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531351}
[modify] https://crrev.com/9fc8f44f974c5103ef70c670e2b5e6d1a4160efc/content/browser/browser_plugin/browser_plugin_guest.cc
[modify] https://crrev.com/9fc8f44f974c5103ef70c670e2b5e6d1a4160efc/content/browser/frame_host/render_widget_host_view_guest.cc
[modify] https://crrev.com/9fc8f44f974c5103ef70c670e2b5e6d1a4160efc/content/browser/frame_host/render_widget_host_view_guest.h

Status: Fixed (was: Started)
This should be fixed as of the CL in c#20 ... please reopen if this bug is observed after r531351.
After this bakes a day or two we'll request merge to M65. I suspect this is not critical enough to try and get into M64.
Labels: Merge-Request-65
Labels: -M-64 M-65
Project Member

Comment 25 by sheriffbot@chromium.org, Jan 25 2018

Labels: -Merge-Request-65 Hotlist-Merge-Approved Merge-Approved-65
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 26 by bugdroid1@chromium.org, Jan 26 2018

Labels: -merge-approved-65 merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe970f88cf8965b42c2601891cb2d7237d3bc122

commit fe970f88cf8965b42c2601891cb2d7237d3bc122
Author: W. James MacLean <wjmaclean@chromium.org>
Date: Fri Jan 26 15:47:47 2018

RenderWidgetHostViewGuest was never wired to CursorManager.

The CL updates RWHVG to use CursorManager when updating its
cursor.

TBR=wjmaclean@chromium.org

(cherry picked from commit 9fc8f44f974c5103ef70c670e2b5e6d1a4160efc)

Bug:  775488 
Change-Id: I5534aa04c78d27db2d22ccc4134c66fa1f9ea4af
Reviewed-on: https://chromium-review.googlesource.com/879322
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#531351}
Reviewed-on: https://chromium-review.googlesource.com/889180
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#115}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/fe970f88cf8965b42c2601891cb2d7237d3bc122/content/browser/browser_plugin/browser_plugin_guest.cc
[modify] https://crrev.com/fe970f88cf8965b42c2601891cb2d7237d3bc122/content/browser/frame_host/render_widget_host_view_guest.cc
[modify] https://crrev.com/fe970f88cf8965b42c2601891cb2d7237d3bc122/content/browser/frame_host/render_widget_host_view_guest.h

Sign in to add a comment