New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 775486 link

Starred by 22 users

Speakers POP on Chromebox after Latest Update

Reported by rtrema...@gmail.com, Oct 17 2017

Issue description

Chrome Version       : 61.0.3163.120
OS Version: 9765.81.0
URLs (if applicable) :
Other browsers tested:
  Add OK or FAIL after other browsers where you have tested this issue:
     Safari 5: Have not tested
  Firefox 4.x: Have not tested
     IE 7/8/9: Have not tested

What steps will reproduce the problem?
1. Open Chrome browser to Gmail
2. Speakers begin to "pop" loudly every @ 10 seconds
3.

What is the expected result?
 No sound should be coming from the speakers


What happens instead of that?

A loud popping noise comes from the speakers


Please provide any additional information below. Attach a screenshot if
possible.

UserAgentString: Mozilla/5.0 (X11; CrOS x86_64 9765.81.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.120 Safari/537.36



 
Showing comments 10 - 109 of 109 Older
Owner: chinyue@chromium.org
Labels: -Pri-3 Pri-1
Jimmy and I have reproduced this issue. There's a persistent noise coming out from speaker even when CRAS has stopped playback and closed the device.

The noise stops when there's audio playback, but came out soon after CRAS closed the device.

It's not likely a bug in CRAS. We're looking into if there're any kernel changes introduced such side-effect.

Status: Started (was: Unconfirmed)
The chromebox is guado.
This happens on one of the speaker model we tested.

Note that the noise is not played out by kernel or CRAS because when noise happens, device is not playing.
It also persists even if we stop CRAS.

There are two symptoms:
1. Noise happens 10 seconds after playback ends.
2. Noise happens after boot at login screen. After playback or unplug/plug, there will be no noise.

R61 9765.85.0: symptom 1

R60 9592.0.0: symptom 2

R60 9557.0.0: symptom 2

9546~9556: No image to test

R60 9545.0.0:  All good
R60 9535.0.0:  All good
R60 9500.0.0 All good

R59-9460.76.0 All good
R59-9460.0.0 All good


The change https://chromium-review.googlesource.com/503947 skipped one update update_supported_formats.
I think the calls in update_supported_formats suppressed the noise like plug/unplug.

I installed image 9557, and switch CRAS version on it with/without the CL, the behavior is different.

Another thing to notice is that touching controls, even reading it, will make difference.

1. Playback.
2. Unplug/plug
3. cat /proc/asound/card1/codec#0
4. switch "Master" scontrol.

By making difference I mean, for symptom 1, it will suppress noise temporarily, and noise shows up 10 seconds after that.
For symptom 2, it will suppress noise forever until reboot.


I think CL https://chromium-review.googlesource.com/503947 masked the symptom 2 issue for a long time until we really remove that unnecessary code.

But there are other changes that cause symptom 2 -> symptom 1 between 9592.0.0 and 9765.85.0.



I just went out and purchased a new speaker system hoping that would solve
this issue. Was I ever wrong. Now when the audio turns off there is a
horrible hum through my speakers, not just a thump. All is fine when audio
is playing back. What the heck is the problem here?

Thank you,

Larry

*Larry Doolittle*
<doolittle.larry@gmail.com>  <https://www.facebook.com/larry.doolittle>
<https://goo.gl/nqKfd>  <http://www.twitter.com>
Re 15,

update_supported_formats invokes some snd_pcm calls and probably one or some of them drive the audio bus and stopped the noise. 
We need to figure out which change caused symptom 2 -> symptom 1.
If we go back to symptom 2, maybe we can workaround the symptom by using UCM config?

just sent error report with issue number 775486
Re #16

Hi Larry, we are actively working on resolving this issue. If you want to use another speaker please use a USB speaker as USB speakers are not affected by this issue. Thanks!

It is noticed that for "symptom 2", there will be a brief humming from speaker before shutdown or reboot.
Identified that "symptom 2" -> "symptom 1" occurred between R61 9742.0.0 and R61 9743.0.0

https://crosland.corp.google.com/log/9742.0.0..9743.0.0

There's only one kernel (v3.14) change and doesn't look like the culprit. Looking through other changes...

OK we got some more clues now, it has something to do with power management.
On guado, hda power_save settings are:


localhost ~ # cat /sys/module/snd_hda_intel/parameters/power_save
10
localhost ~ # cat /sys/module/snd_hda_intel/parameters/power_save_controller 
Y


If I set the power_save to 0 and then toggle the playback switch, the hum noise will be gone and not come back.


localhost ~ # echo 0 > /sys/module/snd_hda_intel/parameters/power_save
localhost ~ # cat /sys/module/snd_hda_intel/parameters/power_save
0
localhost ~ # amixer -c1 cset numid=2 on
numid=2,iface=MIXER,name='Master Playback Switch'
  ; type=BOOLEAN,access=rw------,values=2
  : values=on,on

mka@ Is it possible to set /sys/module/snd_hda_intel/parameters/power_save to 0 on AC power? Since guado is a chromebox and always on AC.

I have not noticed a hum, just a popping as if the chromebox is being turned off and on, it only occurs when using the chrome browser. ??
Not sure Larry, I am using an "old" Dell speaker bar which mounts under the monitor. It is powered by a micro usb which plugs into the monitor and uses the headphone jack for audio. I have used it for years - since I bought the chromebox new - when it was first released with no issues. The trouble I have observed - when i initial posted this bug - was that the speaker would "pop" every 10 seconds or so as if the chromebox was being turned on. I have noticed that it only occurs when using the browser - for me anyway. It appears that this issue is being treated as a power management issue.
Thank you all for your help. It is greatly appreciated.

L

*Larry Doolittle*
<doolittle.larry@gmail.com>  <https://www.facebook.com/larry.doolittle>
<https://goo.gl/nqKfd>  <http://www.twitter.com>

Comment 31 by mka@chromium.org, Nov 1 2017

#26

> Is it possible to set /sys/module/snd_hda_intel/parameters/power_save to 0 on AC power?

Not with the just a udev rule as we have now, since on other devices power can change AC and battery.

If this problem is limited to guado/Chromeboxes an option would be to only enable power save mode on devices that have a battery.
Labels: M-63
Owner: mka@chromium.org
Status: Assigned (was: Started)
Re#31
Hi mka, I agree with you to only enable power save mode on device that has battery.
That should solve this case for our chromebox users since chromebox users are more likely to use analog speakers.
Plus, it is not meaningful to enable power save mode on chromebox.
We have seen more user complaints on it https://bugs.chromium.org/p/chromium/issues/detail?id=772463
Could you please fix that in M63?

Apart from chromebox, I think the issue will happen too for those devices using ALC283 audio.
We will create another issue to track why ALC283 output is not stable when power_save is turned on.
Thanks!
 Issue 772463  has been merged into this issue.

Comment 34 by mka@chromium.org, Nov 2 2017

Cc: derat@chromium.org diand...@chromium.org
I had a chat with some other folks about disabling power save mode, it is seen as a last resort. Even devices without battery are typically thermally constrained, power save mode helps to prevent/delay throttling. Also we want to keep the number of different configuration settings as limited as possible, to facilitate testing and bug fixing.

As cychiang@ pointed out this issue likely affects other devices with ALC283 audio, so we should try to fix this on the audio side.

Given the negative impact on users I suggest to disable audio power save mode on guado as a temporary workaround, to be reverted when the problem is addressed on the ALC283 side.
Project Member

Comment 35 by bugdroid1@chromium.org, Nov 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/4868303e316efdd6c8bc0ff2861cb0ee01ecba74

commit 4868303e316efdd6c8bc0ff2861cb0ee01ecba74
Author: Matthias Kaehlcke <mka@chromium.org>
Date: Fri Nov 03 23:28:57 2017

baseboard-jecht: Temporarily disable audio power save mode

With CL:565448 audio power save mode is enabled statically at boot time,
independently of the power source. This exposes an issue with unstable
output on the ALC283 audio when idle, which results in a popping or humming
noise on external speakers.

Temporarily disable audio power save mode on jecht devices while the
problem on the audio side is being investigated.

BUG= chromium:775486 
TEST=build and boot for guado
  cat /sys/module/snd_hda_intel/parameters/power_save_controller
    => N
CQ-DEPEND=CL:753979

Change-Id: I94da2a8282a121d0b3beeb46300ed85f32a39882
Reviewed-on: https://chromium-review.googlesource.com/752324
Commit-Ready: Matthias Kaehlcke <mka@chromium.org>
Tested-by: Matthias Kaehlcke <mka@chromium.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>

[modify] https://crrev.com/4868303e316efdd6c8bc0ff2861cb0ee01ecba74/baseboard-jecht/chromeos-base/chromeos-bsp-baseboard-jecht/chromeos-bsp-baseboard-jecht-0.0.1.ebuild
[rename] https://crrev.com/4868303e316efdd6c8bc0ff2861cb0ee01ecba74/baseboard-jecht/chromeos-base/chromeos-bsp-baseboard-jecht/chromeos-bsp-baseboard-jecht-0.0.1-r2.ebuild
[add] https://crrev.com/4868303e316efdd6c8bc0ff2861cb0ee01ecba74/baseboard-jecht/chromeos-base/chromeos-bsp-baseboard-jecht/files/99-powerknobs-jecht.rules

Project Member

Comment 36 by bugdroid1@chromium.org, Nov 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/ee2a477fe8e949435fdfcba54e643544fa2bc4bf

commit ee2a477fe8e949435fdfcba54e643544fa2bc4bf
Author: Matthias Kaehlcke <mka@chromium.org>
Date: Fri Nov 03 23:28:57 2017

power_manager: Run powerknobs udev rules slightly earlier

Rename powerknobs and autosuspend rules from 99-*.rules to 98-*.rules.
This allows to run board specific rules afterwards without relying on
alphabetical ordering of the rule file names.

BUG= chromium:775486 
TEST=build and boot on squawks
  cat /sys/module/snd_hda_intel/parameters/power_save_controller
    => Y
CQ-DEPEND=CL:754061

Change-Id: Id753a63f2ec63e637ecfc5e9ec21b321146c16e5
Reviewed-on: https://chromium-review.googlesource.com/753979
Commit-Ready: Matthias Kaehlcke <mka@chromium.org>
Tested-by: Matthias Kaehlcke <mka@chromium.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/ee2a477fe8e949435fdfcba54e643544fa2bc4bf/chromeos-base/power_manager/power_manager-9999.ebuild

Project Member

Comment 37 by bugdroid1@chromium.org, Nov 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/f05cfc2628dda13a6091b2db631c3332f43644ee

commit f05cfc2628dda13a6091b2db631c3332f43644ee
Author: Matthias Kaehlcke <mka@chromium.org>
Date: Fri Nov 03 23:28:57 2017

power: udev: Run powerknobs rules slightly earlier

Rename the udev rule file from 99-powerknobs.rules to 98-powerknobs.rules.
This allows to run board specific rules afterwards without relying on
alphabetical ordering of the rule file names.

BUG= chromium:775486 
TEST=build and boot on squawks
  cat /sys/module/snd_hda_intel/parameters/power_save_controller
    => Y
CQ-DEPEND=CL:753979

Change-Id: I457120249eb0494dbb716c9a41f39c44bda076fc
Reviewed-on: https://chromium-review.googlesource.com/754061
Commit-Ready: Matthias Kaehlcke <mka@chromium.org>
Tested-by: Matthias Kaehlcke <mka@chromium.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[rename] https://crrev.com/f05cfc2628dda13a6091b2db631c3332f43644ee/power_manager/udev/optional/98-powerknobs.rules

Comment 38 by mka@chromium.org, Nov 3 2017

Status: Fixed (was: Assigned)
cychiang@, could you add me to cc: of the issue for fixing the unstable ALC283 output with power save mode, so I will be notified when it is fixed and can revert CL:752324.

Thanks

Matthias
Cc: gkihumba@chromium.org bhthompson@chromium.org
Labels: Merge-Request-63 Merge-Request-62 M-62
Status: Assigned (was: Fixed)
Hi Matthias. Can you merge the fixes to M63 and M62? Is only "baseboard-jecht: Temporarily disable audio power save mode" needed? Or we need to merge all three CLs?
 
Grace and Bernie. Requesting a merge to M63 and M62.

I think it's too late for M61.
Project Member

Comment 40 by sheriffbot@chromium.org, Nov 4 2017

Labels: -Merge-Request-63 Merge-Review-63 Hotlist-Merge-Review
This bug requires manual review: M63 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Same problem here. Just bought an ASUS Chromebox and started using it today. I get annoying popping sounds from the external speakers when not playing audio.
P.S.On version Version 62.0.3202.82 (Official Build) (64-bit). Problem still exists.

Comment 43 by mka@chromium.org, Nov 4 2017

#39: All three CLs are needed to make sure the rules are executed in the right order.
Not sure if this is helpful, but I can confirm that this problem does not affect HDMI audio. Since #20 stated it also does not affect USB speakers, it seems the problem is only affecting audio when using the headphone jack.

So for most people, the best solution seems to be to use HDMI audio, if your monitor is HDMI and supports plugging speakers into it.
I can confirm this. I just added a USB DAC (Signstek) to my Chromebox
connecting to my Logitech Z906 speakers through Optical s/pdif and there is
no longer any thumping or popping. The other benefit is that the speakers
do not hum when they are turned up without an audio source selected through
the headphone jack.

*Larry Doolittle*
<doolittle.larry@gmail.com>  <https://www.facebook.com/larry.doolittle>
<https://goo.gl/nqKfd>  <http://www.twitter.com>

Comment 46 by rik...@gmail.com, Nov 6 2017

I have this issue for a while now, but after the update to version 61 the problem got worse. Before version 61 the problem could be solved in two ways:
- play music
- disconnect the minijack and connect it again
In both instances the ground hum stopped (until the Chromebox was reset)  

But now the ground hum comes back after doing the above. It stops for a moment and then the hum returns.

Now, since yesterday I have a workaround that should work for everybody who has grounded sockets. 
The Chromeboxes we have (G004U ASUS) have no ground cable attached to the powercable (it's a flat plug). Before, when we still had a Windows PC the speakers were grounded through the PC which had a euro plug with ground cable. There was no hum present in that setup. So this seems to cause the problem.

To solve the problem I disassembled a plug and removed the plus and minus contacts. The I attached a thin cable to the ground. Then on the other end I used only a few strands (3 to 4 strands otherwise it becomes to wide) and put it around the minijack plug on the first section of the plug (nearest to where you hold the plug). Then put the powerplug (which is only a ground plug now) in the socket and the minijack in the Chromebox and the hum is gone! :-)
It looks a little weird, but it works like a charm!
2017-11-02-PHOTO-00000268.jpg
100 KB View Download
2017-11-02-PHOTO-00000269.jpg
130 KB View Download
2017-11-02-PHOTO-00000270.jpg
134 KB View Download
2017-11-02-PHOTO-00000267.jpg
155 KB View Download
Labels: -Merge-Request-62 -Merge-Review-63 Merge-Approved-62 Merge-Approved-63
Too late for M61 but approving M-62 and M-63 
Project Member

Comment 48 by bugdroid1@chromium.org, Nov 6 2017

Labels: merge-merged-release-R62-9901.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/60208686f4529b379890448456841d0e81d10fa3

commit 60208686f4529b379890448456841d0e81d10fa3
Author: Matthias Kaehlcke <mka@chromium.org>
Date: Mon Nov 06 20:18:25 2017

power: udev: Run powerknobs rules slightly earlier

Rename the udev rule file from 99-powerknobs.rules to 98-powerknobs.rules.
This allows to run board specific rules afterwards without relying on
alphabetical ordering of the rule file names.

BUG= chromium:775486 
TEST=build and boot on squawks
  cat /sys/module/snd_hda_intel/parameters/power_save_controller
    => Y
CQ-DEPEND=CL:753979

Change-Id: I457120249eb0494dbb716c9a41f39c44bda076fc
Reviewed-on: https://chromium-review.googlesource.com/754061
Commit-Ready: Matthias Kaehlcke <mka@chromium.org>
Tested-by: Matthias Kaehlcke <mka@chromium.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
(cherry picked from commit f05cfc2628dda13a6091b2db631c3332f43644ee)
Reviewed-on: https://chromium-review.googlesource.com/755455
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
Commit-Queue: Matthias Kaehlcke <mka@chromium.org>

[rename] https://crrev.com/60208686f4529b379890448456841d0e81d10fa3/power_manager/udev/optional/98-powerknobs.rules

Project Member

Comment 49 by bugdroid1@chromium.org, Nov 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/3f33fb9a36ab5c41811e058c444c92c1de8b6445

commit 3f33fb9a36ab5c41811e058c444c92c1de8b6445
Author: Matthias Kaehlcke <mka@chromium.org>
Date: Mon Nov 06 20:18:25 2017

baseboard-jecht: Temporarily disable audio power save mode

With CL:565448 audio power save mode is enabled statically at boot time,
independently of the power source. This exposes an issue with unstable
output on the ALC283 audio when idle, which results in a popping or humming
noise on external speakers.

Temporarily disable audio power save mode on jecht devices while the
problem on the audio side is being investigated.

BUG= chromium:775486 
TEST=build and boot for guado
  cat /sys/module/snd_hda_intel/parameters/power_save_controller
    => N
CQ-DEPEND=CL:753979

Change-Id: I94da2a8282a121d0b3beeb46300ed85f32a39882
Reviewed-on: https://chromium-review.googlesource.com/752324
Commit-Ready: Matthias Kaehlcke <mka@chromium.org>
Tested-by: Matthias Kaehlcke <mka@chromium.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
(cherry picked from commit 4868303e316efdd6c8bc0ff2861cb0ee01ecba74)
Reviewed-on: https://chromium-review.googlesource.com/755456
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
Commit-Queue: Matthias Kaehlcke <mka@chromium.org>

[modify] https://crrev.com/3f33fb9a36ab5c41811e058c444c92c1de8b6445/baseboard-jecht/chromeos-base/chromeos-bsp-baseboard-jecht/chromeos-bsp-baseboard-jecht-0.0.1.ebuild
[rename] https://crrev.com/3f33fb9a36ab5c41811e058c444c92c1de8b6445/baseboard-jecht/chromeos-base/chromeos-bsp-baseboard-jecht/chromeos-bsp-baseboard-jecht-0.0.1-r2.ebuild
[add] https://crrev.com/3f33fb9a36ab5c41811e058c444c92c1de8b6445/baseboard-jecht/chromeos-base/chromeos-bsp-baseboard-jecht/files/99-powerknobs-jecht.rules

Project Member

Comment 50 by bugdroid1@chromium.org, Nov 6 2017

Labels: merge-merged-release-R63-10032.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/fa28f1260b0fa11d6d98d43d67130c5422180d1e

commit fa28f1260b0fa11d6d98d43d67130c5422180d1e
Author: Matthias Kaehlcke <mka@chromium.org>
Date: Mon Nov 06 20:18:25 2017

power_manager: Run powerknobs udev rules slightly earlier

Rename powerknobs and autosuspend rules from 99-*.rules to 98-*.rules.
This allows to run board specific rules afterwards without relying on
alphabetical ordering of the rule file names.

BUG= chromium:775486 
TEST=build and boot on squawks
  cat /sys/module/snd_hda_intel/parameters/power_save_controller
    => Y
CQ-DEPEND=CL:754061

Change-Id: Id753a63f2ec63e637ecfc5e9ec21b321146c16e5
Reviewed-on: https://chromium-review.googlesource.com/753979
Commit-Ready: Matthias Kaehlcke <mka@chromium.org>
Tested-by: Matthias Kaehlcke <mka@chromium.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
(cherry picked from commit ee2a477fe8e949435fdfcba54e643544fa2bc4bf)
Reviewed-on: https://chromium-review.googlesource.com/755494
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
Commit-Queue: Matthias Kaehlcke <mka@chromium.org>

[modify] https://crrev.com/fa28f1260b0fa11d6d98d43d67130c5422180d1e/chromeos-base/power_manager/power_manager-9999.ebuild

Project Member

Comment 51 by bugdroid1@chromium.org, Nov 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/16fa4d67ee8e5822471dec4c4bed75e14a92d81d

commit 16fa4d67ee8e5822471dec4c4bed75e14a92d81d
Author: Matthias Kaehlcke <mka@chromium.org>
Date: Mon Nov 06 20:18:28 2017

baseboard-jecht: Temporarily disable audio power save mode

With CL:565448 audio power save mode is enabled statically at boot time,
independently of the power source. This exposes an issue with unstable
output on the ALC283 audio when idle, which results in a popping or humming
noise on external speakers.

Temporarily disable audio power save mode on jecht devices while the
problem on the audio side is being investigated.

BUG= chromium:775486 
TEST=build and boot for guado
  cat /sys/module/snd_hda_intel/parameters/power_save_controller
    => N
CQ-DEPEND=CL:753979

Change-Id: I94da2a8282a121d0b3beeb46300ed85f32a39882
Reviewed-on: https://chromium-review.googlesource.com/752324
Commit-Ready: Matthias Kaehlcke <mka@chromium.org>
Tested-by: Matthias Kaehlcke <mka@chromium.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
(cherry picked from commit 4868303e316efdd6c8bc0ff2861cb0ee01ecba74)
Reviewed-on: https://chromium-review.googlesource.com/755454
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
Commit-Queue: Matthias Kaehlcke <mka@chromium.org>

[modify] https://crrev.com/16fa4d67ee8e5822471dec4c4bed75e14a92d81d/baseboard-jecht/chromeos-base/chromeos-bsp-baseboard-jecht/chromeos-bsp-baseboard-jecht-0.0.1.ebuild
[rename] https://crrev.com/16fa4d67ee8e5822471dec4c4bed75e14a92d81d/baseboard-jecht/chromeos-base/chromeos-bsp-baseboard-jecht/chromeos-bsp-baseboard-jecht-0.0.1-r2.ebuild
[add] https://crrev.com/16fa4d67ee8e5822471dec4c4bed75e14a92d81d/baseboard-jecht/chromeos-base/chromeos-bsp-baseboard-jecht/files/99-powerknobs-jecht.rules

Project Member

Comment 52 by bugdroid1@chromium.org, Nov 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/2598d9bf5954c861ca86e5159e87f8615b06f750

commit 2598d9bf5954c861ca86e5159e87f8615b06f750
Author: Matthias Kaehlcke <mka@chromium.org>
Date: Mon Nov 06 20:18:28 2017

power: udev: Run powerknobs rules slightly earlier

Rename the udev rule file from 99-powerknobs.rules to 98-powerknobs.rules.
This allows to run board specific rules afterwards without relying on
alphabetical ordering of the rule file names.

BUG= chromium:775486 
TEST=build and boot on squawks
  cat /sys/module/snd_hda_intel/parameters/power_save_controller
    => Y
CQ-DEPEND=CL:753979

Change-Id: I457120249eb0494dbb716c9a41f39c44bda076fc
Reviewed-on: https://chromium-review.googlesource.com/754061
Commit-Ready: Matthias Kaehlcke <mka@chromium.org>
Tested-by: Matthias Kaehlcke <mka@chromium.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
(cherry picked from commit f05cfc2628dda13a6091b2db631c3332f43644ee)
Reviewed-on: https://chromium-review.googlesource.com/755544
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
Commit-Queue: Matthias Kaehlcke <mka@chromium.org>

[rename] https://crrev.com/2598d9bf5954c861ca86e5159e87f8615b06f750/power_manager/udev/optional/98-powerknobs.rules

Project Member

Comment 53 by bugdroid1@chromium.org, Nov 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/c1c36a5198253f9f55af30dd5ce29f0d1a349a1a

commit c1c36a5198253f9f55af30dd5ce29f0d1a349a1a
Author: Matthias Kaehlcke <mka@chromium.org>
Date: Mon Nov 06 20:18:29 2017

power_manager: Run powerknobs udev rules slightly earlier

Rename powerknobs and autosuspend rules from 99-*.rules to 98-*.rules.
This allows to run board specific rules afterwards without relying on
alphabetical ordering of the rule file names.

BUG= chromium:775486 
TEST=build and boot on squawks
  cat /sys/module/snd_hda_intel/parameters/power_save_controller
    => Y
CQ-DEPEND=CL:754061

Change-Id: Id753a63f2ec63e637ecfc5e9ec21b321146c16e5
Reviewed-on: https://chromium-review.googlesource.com/753979
Commit-Ready: Matthias Kaehlcke <mka@chromium.org>
Tested-by: Matthias Kaehlcke <mka@chromium.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
(cherry picked from commit ee2a477fe8e949435fdfcba54e643544fa2bc4bf)
Reviewed-on: https://chromium-review.googlesource.com/755495
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
Commit-Queue: Matthias Kaehlcke <mka@chromium.org>

[modify] https://crrev.com/c1c36a5198253f9f55af30dd5ce29f0d1a349a1a/chromeos-base/power_manager/power_manager-9999.ebuild

Comment 54 by mka@chromium.org, Nov 6 2017

Labels: Merge-Merged
Status: Fixed (was: Assigned)
Cc: ka...@chromium.org
Labels: -Hotlist-Merge-Review
FYI, my comment in #44 turns out to be incorrect. I can hear the popping noise through HDMI audio, but it is very muted and barely audible compared to using the speaker / headphone jack.

Anyway, since the problem is marked as fixed / closed, I'll wait until the update gets pushed out to me and then report back.
Project Member

Comment 58 by sheriffbot@chromium.org, Nov 10 2017

Cc: wuchengli@chromium.org josa...@chromium.org
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-62 -Merge-Approved-63
Cc: vsu...@chromium.org itspeter@chromium.org avkodipelli@chromium.org allendam@chromium.org sontis@chromium.org hsiangc@chromium.org pgangishetty@chromium.org
 Issue 761833  has been merged into this issue.
Owner: cychiang@chromium.org
Status: Started (was: Fixed)
There is still noise after the fix: https://bugs.chromium.org/p/chromium/issues/detail?id=761833#c8

I will take a look what is wrong.
Owner: mka@chromium.org
Status: Assigned (was: Started)
I see the issue.
Setting power_save_controller to N is not enough.
We must also set power_save to 0.
They actually control power for different components. (power_save for codec side, and power_save_controller for controller side) [1]

[1]
https://cs.corp.google.com/chromeos_public/src/third_party/kernel/v3.14/Documentation/sound/alsa/powersave.txt?q=power_save_controller+3.14+package:%5Echromeos_public$&dr=C&l=38

Reassign to mka@ for the fix.
Thanks!

Comment 63 by mka@chromium.org, Nov 13 2017

I don't have a guado and could only verify on a lab device that power_save_controller is 'N', but not that the change actually fixed the noise issue. Sorry about that.

I'll submit shortly a CL that also disables power save mode on the codec side.
I have a guado device and it is still popping after update on external
speakers.

*Larry Doolittle*
<doolittle.larry@gmail.com>  <https://www.facebook.com/larry.doolittle>
<https://goo.gl/nqKfd>  <http://www.twitter.com>
I have a guado device and it is still popping after update on external
speakers.

*Larry Doolittle*
<doolittle.larry@gmail.com>  <https://www.facebook.com/larry.doolittle>
<https://goo.gl/nqKfd>  <http://www.twitter.com>



On Mon, Nov 13, 2017 at 1:02 PM, m… via monorail <monorail+v2.788687933@
chromium.org> wrote:
Project Member

Comment 66 by bugdroid1@chromium.org, Nov 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/8c51dce294f60a8e3c9154c23f1a3be7f893caf3

commit 8c51dce294f60a8e3c9154c23f1a3be7f893caf3
Author: Matthias Kaehlcke <mka@chromium.org>
Date: Wed Nov 15 02:43:54 2017

power: Use udev ATTR{xyz}=<value> syntax for audio power save mode

Using the udev ATTR syntax is cleaner and gets the job done without
the overhead of launching a shell.

BUG= chromium:775486 
TEST=build and boot on squakws
  cat /sys/module/snd_hda_intel/parameters/power_save
    => 10
  cat /sys/module/snd_hda_intel/parameters/power_save_controller
    => Y

Change-Id: I7a344ec257a991230f530380dab679b81fb81d49
Reviewed-on: https://chromium-review.googlesource.com/769160
Commit-Ready: Matthias Kaehlcke <mka@chromium.org>
Tested-by: Matthias Kaehlcke <mka@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/8c51dce294f60a8e3c9154c23f1a3be7f893caf3/power_manager/udev/optional/98-powerknobs.rules

Project Member

Comment 67 by bugdroid1@chromium.org, Nov 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/0652657710be268482c80704058aeb4e2f340114

commit 0652657710be268482c80704058aeb4e2f340114
Author: Matthias Kaehlcke <mka@chromium.org>
Date: Fri Nov 17 02:45:38 2017

baseboard-jecht: Also disable power save mode of the audio codec

CL:752324 disables power save mode of the audio controller to work around
an issue with noise due to unstable output on the ALC283 when idle. It
turns out that we also need to disable power save mode of the audio codec
to address the noise issue.

BUG= chromium:775486 
TEST=build and boot for guado
  cat /sys/module/snd_hda_intel/parameters/power_save
    => 0
  cat /sys/module/snd_hda_intel/parameters/power_save_controller
    => N
CQ-DEPEND=CL:769160

Change-Id: Ifa6b4fc94d125ec5f036c0a14c04179bfd0d1934
Reviewed-on: https://chromium-review.googlesource.com/766476
Commit-Ready: Matthias Kaehlcke <mka@chromium.org>
Tested-by: Matthias Kaehlcke <mka@chromium.org>
Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[rename] https://crrev.com/0652657710be268482c80704058aeb4e2f340114/baseboard-jecht/chromeos-base/chromeos-bsp-baseboard-jecht/chromeos-bsp-baseboard-jecht-0.0.1-r3.ebuild
[modify] https://crrev.com/0652657710be268482c80704058aeb4e2f340114/baseboard-jecht/chromeos-base/chromeos-bsp-baseboard-jecht/files/99-powerknobs-jecht.rules

Project Member

Comment 68 by bugdroid1@chromium.org, Nov 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/eb26f539cb07a9eb0f569fa652273c7a09b33fc7

commit eb26f539cb07a9eb0f569fa652273c7a09b33fc7
Author: Matthias Kaehlcke <mka@chromium.org>
Date: Fri Nov 17 18:01:46 2017

power: Use udev ATTR{xyz}=<value> syntax for audio power save mode

Using the udev ATTR syntax is cleaner and gets the job done without
the overhead of launching a shell.

BUG= chromium:775486 
TEST=build and boot on squakws
  cat /sys/module/snd_hda_intel/parameters/power_save
    => 10
  cat /sys/module/snd_hda_intel/parameters/power_save_controller
    => Y

Change-Id: I7a344ec257a991230f530380dab679b81fb81d49
Reviewed-on: https://chromium-review.googlesource.com/769160
Commit-Ready: Matthias Kaehlcke <mka@chromium.org>
Tested-by: Matthias Kaehlcke <mka@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
(cherry picked from commit 8c51dce294f60a8e3c9154c23f1a3be7f893caf3)
Reviewed-on: https://chromium-review.googlesource.com/777062
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
Commit-Queue: Matthias Kaehlcke <mka@chromium.org>

[modify] https://crrev.com/eb26f539cb07a9eb0f569fa652273c7a09b33fc7/power_manager/udev/optional/98-powerknobs.rules

Project Member

Comment 69 by bugdroid1@chromium.org, Nov 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/881f3321bf80f5cb7028e0e870591c3d5ba13d2f

commit 881f3321bf80f5cb7028e0e870591c3d5ba13d2f
Author: Matthias Kaehlcke <mka@chromium.org>
Date: Fri Nov 17 18:01:50 2017

power: Use udev ATTR{xyz}=<value> syntax for audio power save mode

Using the udev ATTR syntax is cleaner and gets the job done without
the overhead of launching a shell.

BUG= chromium:775486 
TEST=build and boot on squakws
  cat /sys/module/snd_hda_intel/parameters/power_save
    => 10
  cat /sys/module/snd_hda_intel/parameters/power_save_controller
    => Y

Change-Id: I7a344ec257a991230f530380dab679b81fb81d49
Reviewed-on: https://chromium-review.googlesource.com/769160
Commit-Ready: Matthias Kaehlcke <mka@chromium.org>
Tested-by: Matthias Kaehlcke <mka@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
(cherry picked from commit 8c51dce294f60a8e3c9154c23f1a3be7f893caf3)
Reviewed-on: https://chromium-review.googlesource.com/777061
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
Commit-Queue: Matthias Kaehlcke <mka@chromium.org>

[modify] https://crrev.com/881f3321bf80f5cb7028e0e870591c3d5ba13d2f/power_manager/udev/optional/98-powerknobs.rules

Project Member

Comment 70 by bugdroid1@chromium.org, Nov 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/138842391b3a5f4c7c5249f36420c1ec0a964b87

commit 138842391b3a5f4c7c5249f36420c1ec0a964b87
Author: Matthias Kaehlcke <mka@chromium.org>
Date: Fri Nov 17 18:04:18 2017

baseboard-jecht: Also disable power save mode of the audio codec

CL:752324 disables power save mode of the audio controller to work around
an issue with noise due to unstable output on the ALC283 when idle. It
turns out that we also need to disable power save mode of the audio codec
to address the noise issue.

BUG= chromium:775486 
TEST=build and boot for guado
  cat /sys/module/snd_hda_intel/parameters/power_save
    => 0
  cat /sys/module/snd_hda_intel/parameters/power_save_controller
    => N
CQ-DEPEND=CL:769160

Change-Id: Ifa6b4fc94d125ec5f036c0a14c04179bfd0d1934
Reviewed-on: https://chromium-review.googlesource.com/766476
Commit-Ready: Matthias Kaehlcke <mka@chromium.org>
Tested-by: Matthias Kaehlcke <mka@chromium.org>
Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
(cherry picked from commit 0652657710be268482c80704058aeb4e2f340114)
Reviewed-on: https://chromium-review.googlesource.com/777179
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
Commit-Queue: Matthias Kaehlcke <mka@chromium.org>

[rename] https://crrev.com/138842391b3a5f4c7c5249f36420c1ec0a964b87/baseboard-jecht/chromeos-base/chromeos-bsp-baseboard-jecht/chromeos-bsp-baseboard-jecht-0.0.1-r3.ebuild
[modify] https://crrev.com/138842391b3a5f4c7c5249f36420c1ec0a964b87/baseboard-jecht/chromeos-base/chromeos-bsp-baseboard-jecht/files/99-powerknobs-jecht.rules

Project Member

Comment 71 by bugdroid1@chromium.org, Nov 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/4d1c00d288d594de8851758719115b3c435414fc

commit 4d1c00d288d594de8851758719115b3c435414fc
Author: Matthias Kaehlcke <mka@chromium.org>
Date: Fri Nov 17 18:04:21 2017

baseboard-jecht: Also disable power save mode of the audio codec

CL:752324 disables power save mode of the audio controller to work around
an issue with noise due to unstable output on the ALC283 when idle. It
turns out that we also need to disable power save mode of the audio codec
to address the noise issue.

BUG= chromium:775486 
TEST=build and boot for guado
  cat /sys/module/snd_hda_intel/parameters/power_save
    => 0
  cat /sys/module/snd_hda_intel/parameters/power_save_controller
    => N
CQ-DEPEND=CL:769160

Change-Id: Ifa6b4fc94d125ec5f036c0a14c04179bfd0d1934
Reviewed-on: https://chromium-review.googlesource.com/766476
Commit-Ready: Matthias Kaehlcke <mka@chromium.org>
Tested-by: Matthias Kaehlcke <mka@chromium.org>
Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
(cherry picked from commit 0652657710be268482c80704058aeb4e2f340114)
Reviewed-on: https://chromium-review.googlesource.com/777180
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
Commit-Queue: Matthias Kaehlcke <mka@chromium.org>

[rename] https://crrev.com/4d1c00d288d594de8851758719115b3c435414fc/baseboard-jecht/chromeos-base/chromeos-bsp-baseboard-jecht/chromeos-bsp-baseboard-jecht-0.0.1-r3.ebuild
[modify] https://crrev.com/4d1c00d288d594de8851758719115b3c435414fc/baseboard-jecht/chromeos-base/chromeos-bsp-baseboard-jecht/files/99-powerknobs-jecht.rules

Comment 72 by mka@chromium.org, Nov 17 2017

Status: Fixed (was: Assigned)

Comment 73 by tri...@gmail.com, Nov 30 2017

Confirmed to be resolved in the 63.0.3239.70 (Official Build) beta (64-bit) update for me! FINALLY!
How do you get 63.0.3239.70? My Acer Chromebox CXI is running 62.0.3202.97 and when I checked for a newer version, it says it's up to date.
For now, I think you can switch to beta channel following the instructions

https://support.google.com/chromebook/answer/1086915?hl=en


When R63 is pushed to stable channel in a near future, you can switch the channel back from beta to stable.
The issue persists on R63 on the beta channel.
Cc: -derat@chromium.org
Status: Assigned (was: Fixed)
Re#76 Hi chngjoshua,
Thank you for reporting the issue. The model you are using, ASUS M004U is board panther (Haswell platform). The fix merged was for Broadwell platform.

Re-open this issue to fix beltino-based boards.

The same change should be applied on all chromebox using HDA.
We only fixed jecht-based boards. beltino-based boards should be fixed too.

Hi mka, could you please take the fix to beltino-based boards as well ?

Meanwhile, I will ping Intel in the partner issue tracker to get this root cause tracked down.

Thanks!
Still experiencing the issue on Version 63.0.3239.86 (Official Build) beta (64-bit)

Comment 80 by mka@chromium.org, Dec 13 2017

Sorry, I didn't see the latest comments earlier.

> The same change should be applied on all chromebox using HDA.

My understanding was that the issue is limited to devices with the ALC 283. Is that incorrect?

Hi mka,
Yes beltino-based boards are using ALC283 too.
Actually I can't remember if there is any codec other than ALC283 that we are using on ChromeOS.

Thank you for the fix!
re#81 I mean on ChromeOS with HDA.
Project Member

Comment 83 by bugdroid1@chromium.org, Dec 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/d81814f4c11bfc64646b281c5e7b9688087b2ce1

commit d81814f4c11bfc64646b281c5e7b9688087b2ce1
Author: Matthias Kaehlcke <mka@chromium.org>
Date: Fri Dec 15 23:52:44 2017

power: use separate rules file for Intel HDA

With CL:565448 audio power save mode is enabled statically at boot time,
independently of the power source. This exposes an issue on some Chromeboxes
with unstable output on the ALC283 audio when idle, which results in a popping
or humming noise on external speakers.

The split allows us to skip the installation of the rule that enables audio
power save mode on the affected platforms, while the problem on the audio side
is being investigated.

BUG= chromium:775486 , b:69234606
TEST=see CQ-DEPEND CL
CQ-DEPEND=CL:826568

Change-Id: Ia22de4853b759dbb55983335c8e5b726bf66627f
Reviewed-on: https://chromium-review.googlesource.com/827167
Commit-Ready: Matthias Kaehlcke <mka@chromium.org>
Tested-by: Matthias Kaehlcke <mka@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/d81814f4c11bfc64646b281c5e7b9688087b2ce1/power_manager/udev/optional/98-powerknobs.rules
[add] https://crrev.com/d81814f4c11bfc64646b281c5e7b9688087b2ce1/power_manager/udev/optional/98-powerknobs-intel-hda.rules

Project Member

Comment 84 by bugdroid1@chromium.org, Dec 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/68ab9c5efc55cad79fed15f54d067afb15521b9e

commit 68ab9c5efc55cad79fed15f54d067afb15521b9e
Author: Matthias Kaehlcke <mka@chromium.org>
Date: Fri Dec 15 23:52:43 2017

power_manager: Only enable Intel HDA powersave mode on devices with a battery

With CL:565448 audio power save mode is enabled statically at boot time,
independently of the power source. This exposes an issue on some
Chromeboxes with unstable output on the ALC283 audio when idle, which
results in a popping or humming noise on external speakers.

There is no USE flag to specifically identify Chromeboxes or devices with
ALC283 audio, as an approximation skip Intel HDA powersave mode on all
devices that are always AC powered.

BUG= chromium:775486 , b:69234606
TEST=emerge-mccloud power_manager
  ls /build/pyro/lib/udev/rules.d/98-powerknobs-intel-hda.rules
    => does not exist
  emerge-pyro power_manager
  ls /build/pyro/lib/udev/rules.d/98-powerknobs-intel-hda.rules
    => exists
CQ-DEPEND=CL:827167

Change-Id: I5b94d235cb7009dd59ffea79cce0c0b26ea15a5f
Reviewed-on: https://chromium-review.googlesource.com/826568
Commit-Ready: Matthias Kaehlcke <mka@chromium.org>
Tested-by: Matthias Kaehlcke <mka@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/68ab9c5efc55cad79fed15f54d067afb15521b9e/chromeos-base/power_manager/power_manager-9999.ebuild

The fix at #83 and #84 were merged.
However, it does not work.

On image 10225.0

There is no 98-powerknobs-intel-hda.rules
And, 98-powerknobs.rules does not enable power_save and power_save_controller

However, power_save and power_save_controller are still enabled.
Perhaps these are enabled by kernel by default, so we will need to disable them in 98-powerknobs.rules.





Comment 86 by mka@google.com, Dec 18 2017

> However, power_save and power_save_controller are still enabled.

This is odd, since the issue was supposedly introduced by enabling these settings. Unfortunately I'm OOO for the next weeks and can't investigate further before January.
Owner: cychiang@chromium.org
Status: Started (was: Assigned)
In
https://bugs.chromium.org/p/chromium/issues/detail?id=761833#c22
user also reports that chromebook having this issue. 

I think we should just disable power_save and power_save_controller on ALC 283 until https://buganizer.corp.google.com/issues/69234606 is resolved by Intel/Realtek.


auron-based boards have the same issue, but I could not find power_save_controller on it.
I will take a look at its driver that why it does not expose power_save_controller field.

https://cs.corp.google.com/chromeos_public/src/third_party/kernel/v4.4/sound/pci/hda/hda_intel.c?type=cs&q=power_save_controller+package:%5Echromeos_public$&l=191

power_save_controller has default value 1
power_save has default value CONFIG_SND_HDA_POWER_SAVE_DEFAULT, which is 15 on i386 and x86_64.

That explains why the fix in #83 and #84 are not enough.

If we want to disable power save on all boards using ALC283, we can add a flag alc283 to those boards and use that in power_manager ebuild. 

Another issue is why auron-based board does not expose power_save_controller.
On 3.14 kernel I did not find relevant change. I will take a close look.


Please ignore my comment in #88 about missing power_save_controller. It was there actually.

I plan to disable power_save and power_save_controller for all boards.
All new boards after parrot are using ALC283.
So before https://buganizer.corp.google.com/issues/69234606 is resolved, we should just disable it, no matter it is a chromebox or chromebook.
Posted the fix CLs:
https://chromium-review.googlesource.com/#/c/chromiumos/platform2/+/839480
https://chromium-review.googlesource.com/#/c/chromiumos/overlays/chromiumos-overlay/+/839481

I will verify on other boards.

I checked all the boards using Intel HDA. ALC283 is used widely on all the projects based on these boards:

slippy
jecht
beltino
auron

Some other boards on sandybridge and ivybridge use other codecs with Intel HDA, but I don't think removing power_save mode would make impact to the use since it has been disabled for a long time until R61.


Project Member

Comment 91 by bugdroid1@chromium.org, Dec 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/4b878b7966304e148c101a6d3aac6d91037763db

commit 4b878b7966304e148c101a6d3aac6d91037763db
Author: Cheng-Yi Chiang <cychiang@chromium.org>
Date: Sat Dec 23 01:47:43 2017

Revert "power_manager: Only enable Intel HDA powersave mode on devices with a battery"

This reverts commit 68ab9c5efc55cad79fed15f54d067afb15521b9e.

The pop noise also happens on Chromebooks, so we should disable
power_save mode regardless of ac_only or not.

BUG= chromium:775486 ,b:69234606
TEST=On auron_yuna, check there is no pop noise on external speaker when
there is no audio.

Change-Id: Id3dfb8c9bea18d7b35ef5738e2189dbbceac270d

[modify] https://crrev.com/4b878b7966304e148c101a6d3aac6d91037763db/chromeos-base/power_manager/power_manager-9999.ebuild

Project Member

Comment 92 by bugdroid1@chromium.org, Dec 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/8dd4e70812b7d49f5e47c0589d7d85aed652b97c

commit 8dd4e70812b7d49f5e47c0589d7d85aed652b97c
Author: Cheng-Yi Chiang <cychiang@chromium.org>
Date: Sat Dec 23 01:47:42 2017

power: Disable power save for Intel HDA

The humming noise on external speaker happens on ALC283 codec on both
Chromebooks and Chromeboxes. Power save mode should only be enabled for
selected boards after testing. Set default to false to minimize the
impact to user.

BUG= chromium:775486 , b:69234606
TEST=On auron_yuna, check there is no pop noise when there is no audio.

Change-Id: I178ac32b5c245bbf3093f54e4744678968f8a7da

[modify] https://crrev.com/8dd4e70812b7d49f5e47c0589d7d85aed652b97c/power_manager/udev/optional/98-powerknobs.rules

Labels: M64 Merge-Request-64
Verified on yuna with R65-10247.0.0 image.

Add merge request to R64 for CL in #83 and #92.

CL #91 reverted CL #84
Since CL in #84 did not merged to R64, we don't need CL #94 to be merged to R64 either.

Thanks!
Project Member

Comment 94 by sheriffbot@chromium.org, Dec 25 2017

Labels: -Merge-Request-64 Hotlist-Merge-Review Merge-Review-64
This bug requires manual review: M64 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
I admittedly didn't review all 94 comments; is this a confirmed regression for M64?  If not, why the urgency?  Appears to have been introduced in M61?
Because it caused external speakers to connect and disconnect after
playing video. This causes a major pop or thump thru the speakers.
Hi kbleicher@, the regression was introduced in M61.
In M63, the issue was fixed on some of the boards (jecht-based )
However, there are still other boards having this issue. (slippy, beltino, auron based boards)

We have seen many complaints from users in issue https://bugs.chromium.org/p/chromium/issues/detail?id=761833
It has been starred by 23 users already.
If it is not too late, I hope we can get the fix merged to R64.
Thanks!


Labels: -Merge-Review-64 Merge-Approved-64
Approving merge to M64 Chrome OS since the fix is being deployed to M63...
Project Member

Comment 99 by bugdroid1@chromium.org, Dec 29 2017

Labels: merge-merged-release-R64-10176.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/669d8e9cd6ca163977cb5d21a2533f60af2efd27

commit 669d8e9cd6ca163977cb5d21a2533f60af2efd27
Author: Matthias Kaehlcke <mka@chromium.org>
Date: Fri Dec 29 10:12:35 2017

power: use separate rules file for Intel HDA

With CL:565448 audio power save mode is enabled statically at boot time,
independently of the power source. This exposes an issue on some Chromeboxes
with unstable output on the ALC283 audio when idle, which results in a popping
or humming noise on external speakers.

The split allows us to skip the installation of the rule that enables audio
power save mode on the affected platforms, while the problem on the audio side
is being investigated.

BUG= chromium:775486 , b:69234606
TEST=use with the next CL

Change-Id: Ia22de4853b759dbb55983335c8e5b726bf66627f
Reviewed-on: https://chromium-review.googlesource.com/827167
Commit-Ready: Matthias Kaehlcke <mka@chromium.org>
Tested-by: Matthias Kaehlcke <mka@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
(cherry picked from commit d81814f4c11bfc64646b281c5e7b9688087b2ce1)
Reviewed-on: https://chromium-review.googlesource.com/846288
Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>
Commit-Queue: Cheng-Yi Chiang <cychiang@chromium.org>
Tested-by: Cheng-Yi Chiang <cychiang@chromium.org>

[modify] https://crrev.com/669d8e9cd6ca163977cb5d21a2533f60af2efd27/power_manager/udev/optional/98-powerknobs.rules
[add] https://crrev.com/669d8e9cd6ca163977cb5d21a2533f60af2efd27/power_manager/udev/optional/98-powerknobs-intel-hda.rules

Project Member

Comment 100 by bugdroid1@chromium.org, Dec 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/1ae22bf7407e1ba1cf3a37fc1878e8a90de814b3

commit 1ae22bf7407e1ba1cf3a37fc1878e8a90de814b3
Author: Cheng-Yi Chiang <cychiang@chromium.org>
Date: Fri Dec 29 10:12:37 2017

power: Disable power save for Intel HDA

The humming noise on external speaker happens on ALC283 codec on both
Chromebooks and Chromeboxes. Power save mode should only be enabled for
selected boards after testing. Set default to false to minimize the
impact to user.

BUG= chromium:775486 , b:69234606
TEST=On auron_yuna, check there is no pop noise when there is no audio.

Change-Id: I178ac32b5c245bbf3093f54e4744678968f8a7da
Reviewed-on: https://chromium-review.googlesource.com/846289
Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>
Commit-Queue: Cheng-Yi Chiang <cychiang@chromium.org>
Tested-by: Cheng-Yi Chiang <cychiang@chromium.org>

[modify] https://crrev.com/1ae22bf7407e1ba1cf3a37fc1878e8a90de814b3/power_manager/udev/optional/98-powerknobs.rules

Labels: -Merge-Approved-64
Status: Fixed (was: Started)

Comment 102 Deleted

My new CHROMEBOX-M004U has this issue. I see this is marked as "fixed". Is there an ETA on when this fix will be implemented? It's still happening for me.
Fix is in M64 beta channel and should be in subsequent M64 stable updates.
I am on "Version 64.0.3282.41 (Official Build) beta (64-bit)", and still have the same buzzing noise and pop.
For M64:

Both CLs were merged into 10176.32.0 (846288 and 846289).   Not pushed yet, however, but will be captured in the next beta push.

Version 64.0.3282.87 (Official Build) beta (64-bit)

Problem seems to be fixed. I've had my speakers on for 15 minutes - no pop, no hum and I'm not pushing any audio through the headphone jack.

THANK YOU...it's like my joy has been restored. 
As the original "reporter" of this issue, I can confirm that it is fixed as of this morning for the "offical/stable" build for a chromebox. My chromebox updated to Version 64.0.3282.144 (Official Build) (64-bit) this morning and all popping is gone.
Status: Verified (was: Fixed)
Hi rtremaine,
Thank you for the update!

Mark this as verified.
Showing comments 10 - 109 of 109 Older

Sign in to add a comment