Unwanted lines are seen after clicking on Developer mode radio icon on extensions page.
Reported by
db...@etouch.net,
Oct 17 2017
|
||||||||||||
Issue descriptionChrome Version: 62.0.3202.62 (Official Build)9da914b118cb0d10d715ccc4ad20575a0305a304-refs/branch-heads/3202@{#700}(64-bit) OS: Mac(10.12.6), Win(7,8,10) Linux(14.04 LTS). Pre-condition: Enabled 'Enable Material Design extensions' flag from chrome://flags What steps will reproduce the problem? (1) Launch chrome, navigate to chrome://extensions page. (2) Click on Developer mode radio icon and observe below search field. Actual: Unwanted lines are seen below search field after clicking on Developer mode radio icon. Expected: No such a line should seen. This is a regression issue, broken in 'M-61', below is bisect info: Good Build:61.0.3248.0 Bad Build: 61.0.3250.0 You are probably looking for a change made after 484362 (known good), but no later than 484363 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/23c426581c639f079e9f99d1595bd9a67b144c0c..a9f628ff52bffcfcae37a669c8bae5da1c560364 Suspect: https://chromium.googlesource.com/chromium/src/+/a9f628ff52bffcfcae37a669c8bae5da1c560364 @clamy: Please help me to reassign this issue if your change is not cause for it.
,
Oct 24 2017
,
Oct 27 2017
,
Oct 27 2017
Was able to reproduce this on the current canary 64.0.3251.0 on Mac. This happens when we toggle the Developer mode quickly. Think what's happening is that the toggling gets registered as a double click which causes the area between the tabbed options to get selected. So maybe we just need to prevent the propagation of the click event on toggle.
,
Oct 27 2017
Downgrading to P2 - visual artifact only, does not impact use Removing "regression" marker, since md-extensions hasn't even shipped yet.
,
Oct 27 2017
,
Oct 27 2017
This happens in a few other cases too. As #4 suggests, an accidental text selection happens if one toggles twice quickly enough.
,
Oct 27 2017
,
Oct 27 2017
,
Oct 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eb4596e265712e9d1a0f1dbf57d552c803abd588 commit eb4596e265712e9d1a0f1dbf57d552c803abd588 Author: dpapad <dpapad@chromium.org> Date: Sun Oct 29 23:05:09 2017 MD Extensions: Dev-mode, prevent spaces between buttons to be selectable. Bug: 775479 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I94f5f9d189edcf81f2087f60e5a118824874fad4 Reviewed-on: https://chromium-review.googlesource.com/742650 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#512423} [modify] https://crrev.com/eb4596e265712e9d1a0f1dbf57d552c803abd588/chrome/browser/resources/md_extensions/toolbar.html
,
Oct 30 2017
Fixed this one with "user-select: none", since in this case there is nothing useful to be selected anyway inside the toolbar buttons container. In other cases, we might have to experiment with calling preventDefault() on dblclick event.
,
Oct 31 2017
Update : Retested above issue on Windows(7,8,10), Mac(10.12.6) & Linux(14.04 LTS) OS using latest Canary #64.0.3254.0 and issue is fixed. Kindly review an attached video. Thank you
|
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by clamy@chromium.org
, Oct 18 2017