To give you more context, here is a video of the proposed change. The first part of the video shows existing functionality when a fetch fails ("Unable to get suggestions" has since been changed to "Can't get suggestions.").

Later in the video we see a fetch that is successful (the server returns a response), but provides no new suggestions and the feedback that the Snackbar could provide.

Deleted: 2017-10-10_10-55-17.mp4 15.3 MB

2017-10-10_10-55-17.mp4 15.3 MB Download

@srahim, do you approve of the string?

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5942cc1510f27e73f11f62fcbefc08fc74c1ffc5

commit 5942cc1510f27e73f11f62fcbefc08fc74c1ffc5
Author: Peter E Conn <peconn@chromium.org>
Date: Thu Oct 26 13:52:04 2017

🏡 Display Snackbar when a user triggered fetch returns no results.

Display a different Snackbar if the user triggers a fetch, it succeeds
but there are no new suggestions.

Bug: 663376, 775478
Change-Id: Ib85cb397bf612fb570046aea2e7a7e6e125d535c
Reviewed-on: https://chromium-review.googlesource.com/708754
Commit-Queue: Peter Conn <peconn@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511810}
[modify] https://crrev.com/5942cc1510f27e73f11f62fcbefc08fc74c1ffc5/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java
[modify] https://crrev.com/5942cc1510f27e73f11f62fcbefc08fc74c1ffc5/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SectionList.java
[modify] https://crrev.com/5942cc1510f27e73f11f62fcbefc08fc74c1ffc5/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java
[modify] https://crrev.com/5942cc1510f27e73f11f62fcbefc08fc74c1ffc5/chrome/android/java/src/org/chromium/chrome/browser/snackbar/Snackbar.java
[modify] https://crrev.com/5942cc1510f27e73f11f62fcbefc08fc74c1ffc5/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/5942cc1510f27e73f11f62fcbefc08fc74c1ffc5/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSectionTest.java
[modify] https://crrev.com/5942cc1510f27e73f11f62fcbefc08fc74c1ffc5/tools/metrics/histograms/enums.xml

Hey Shimi!
We have a small change to make to Zine. We can't fetch new articles after the user hits "more" (no internet connection) we show a snackbar for feedback. The current string is "Unable to get suggestions". Would you prefer for us to use something else, or does that work for now?

Cheers,
Rachel

Deleted: Screen Shot 2017-11-07 at 11.57.18 AM.png 356 KB

	Screen Shot 2017-11-07 at 11.57.18 AM.png 356 KB View Download

Hi Rachel, if the reason we can't fetch more articles is no internet connection, I'd prefer we say "No internet connection".

If we need a generic "we don't know what the error is", then how about "Can't get articles"? 

I prefer "articles" here instead of "suggestions." We may have more suggested articles lined up, we just can't show them. Contrast with when we run out of suggestions to show, we have "no more suggestions."

Also, I agree w/#1:
However, if the user initiates a fetch and it succeeds but there are no new relevant suggestions for the user, we don't show anything. We should show some distinct feedback, eg "No new suggestions".

Great, thanks Shimi! 

Pete - does this cover all the use cases we'd need here?

+dgn - nicolas, would you mind pointing us at the strings doc you prepared a while back? I'd like to make sure we're keeping consistency across our strings.

I'm not sure I understand your distinction between Articles and Suggestions, I figure:

No Internet:             Can't get suggestions
Internet, nothing new:   No new suggestions

Is a bit more consistent then

No Internet:             Can't get articles
Internet, nothing new:   No new suggestions

re #c10: Do you mean this document? https://docs.google.com/document/d/1LUHuImA04-VGArgHX6I-1rBAyQ5HDPFgcnEnZgtGDL0/

Any update here?

This was implemented on 26th Oct (making it into M64) with the strings:

Can’t get suggestions
No new suggestions

It was left open to get an OK for the string choice.

Is rachelis@ the right owner for this blocker? rachelis@ are you working on this issue? Please update.

Is there anything pending here?  Please note that M64 Stable is very soon, and this is marked a blocker.

I emailed rachelis@ and I hope to hear from them soon.

#15 is OK with me and should not block M64 Stable launch.

Based on #15 and 19