Regression : Settings page gets scrolled down when trying to enable/disable toggle button through space bar.
Reported by
avsha...@etouch.net,
Oct 17 2017
|
||||
Issue descriptionChrome version : 64.0.3242.0 (Official Build) 98a037253c9ba8c3c0fd2f927c8bc76e7ab2852f-refs/heads/master@{#509211} 32/64 bit OS : Windows(7,8,10), Linux(14.04 LTS), Mac(10.12.6) What steps will reproduce the problem? 1. Launch chrome and navigate to chrome://settings page. 2. Keep pressing 'Tab' key until focus reaches on "Show home button" toggle button. 3. Hit space bar to enable "Show home button" toggle and observe the page. Actual Result : Settings page gets scrolled down when trying to enable/disable toggle button through 'space bar'. Expected Result : Settings page shouldn't get scrolled down while enabling or disabling toggle button through 'space bar'. This is a regression issue broken in ‘M-64’ and using the per-revision bisect providing the bisect results, Good build : 64.0.3240.0 (Revision : 508893) Bad build : 64.0.3241.0 (Revision : 508934) You are probably looking for a change made after 508918 (known good), but no later than 508919 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/e0d7ed61b45554d5511a0e19d9ed69ed3717ac98..f423bc1ae49988cc5be11c16fd7fd137b84da587 Suspect : https://chromium.googlesource.com/chromium/src/+/f423bc1ae49988cc5be11c16fd7fd137b84da587 @dpapad : Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Thank you.
,
Oct 17 2017
Probably can be fixed by adding an e.preventDefault() statement at https://cs.chromium.org/chromium/src/ui/webui/resources/cr_elements/cr_toggle/cr_toggle.js?l=193. Will try it soon.
,
Oct 18 2017
,
Oct 18 2017
,
Oct 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9ebbbb260c168455eb2d8a0c5cce8cc757092ec8 commit 9ebbbb260c168455eb2d8a0c5cce8cc757092ec8 Author: Demetrios Papadopoulos <dpapad@chromium.org> Date: Fri Oct 20 06:01:36 2017 WebUI cr-toggle: Prevent scrolling when toggling with Space key. Bug: 775477 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I221204668f62c56359956327cb4e053e35e4076a Reviewed-on: https://chromium-review.googlesource.com/725500 Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#510352} [modify] https://crrev.com/9ebbbb260c168455eb2d8a0c5cce8cc757092ec8/ui/webui/resources/cr_elements/cr_toggle/cr_toggle.js
,
Oct 20 2017
,
Oct 23 2017
Update : Retested above issue on Windows(7,8,10), Mac(10.12.6) & Linux(14.04 LTS) OS using latest canary #64.0.3247.0 build and issue seems fixed hence adding TE-Verified labels. |
||||
►
Sign in to add a comment |
||||
Comment 1 by ranjitkan@chromium.org
, Oct 17 2017