MDC roll is broken |
||||||||||
Issue descriptionMDC cannot be roll to the next version 656323ca63a39eba14487a374033fec9921cf0f2 because it adds a dependency on MDFInternationalization. The dependency needs to be added to Chromium before rolling.
,
Oct 20 2017
,
Oct 20 2017
,
Oct 21 2017
Is there an estimated time of getting MDC rolled again? We're basically waiting for a bug fix of extra header shadow in MDC.
,
Oct 23 2017
Sorry, I forgot to update the bug. We are waiting for a fix in MDFInternationalization: https://github.com/material-foundation/material-internationalization-ios/pull/20 Once it is fixed, we can add it as a dependency of Chrome: https://chromium-review.googlesource.com/c/chromium/src/+/723000 (still waiting for one approval). Then we will be able to resume the MDC roll. I hope it will be over before the end of the week.
,
Oct 23 2017
Thank you for the update :)
,
Oct 24 2017
Looks like your PR has been closed... If "MDFInternationalization/..." is what has to be used then could we just pull the source code into a MDFInternationalization folder then add it as an include path?
,
Oct 25 2017
Yes, we fixed our build system to be able to build without the PR, it was expected to have it closed. I still have few gn issues to fix on my CL, then I should be able to land it.
,
Oct 25 2017
Pending CLs: https://chromium-review.googlesource.com/c/chromium/src/+/723000 https://chromium-review.googlesource.com/c/chromium/src/+/722962 These are ready to land, waiting for final LGTM.
,
Oct 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8d03446dde8241267009f8ad0671924b566d4bca commit 8d03446dde8241267009f8ad0671924b566d4bca Author: Gauthier Ambard <gambard@chromium.org> Date: Wed Oct 25 16:39:55 2017 Adds MDF Internationalization dependency The dependency is needed because the newer versions of MDC needs it. This CL also roll MDC to 656323ca63a39eba14487a374033fec9921cf0f2. Bug: 775476 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iabad6d33845d9e5e3e9ecb9ea86117abf0eb5ec9 Reviewed-on: https://chromium-review.googlesource.com/723000 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#511486} [modify] https://crrev.com/8d03446dde8241267009f8ad0671924b566d4bca/.gitignore [modify] https://crrev.com/8d03446dde8241267009f8ad0671924b566d4bca/DEPS [modify] https://crrev.com/8d03446dde8241267009f8ad0671924b566d4bca/ios/third_party/material_components_ios/BUILD.gn [modify] https://crrev.com/8d03446dde8241267009f8ad0671924b566d4bca/ios/third_party/material_components_ios/README.chromium [add] https://crrev.com/8d03446dde8241267009f8ad0671924b566d4bca/ios/third_party/material_internationalization_ios/BUILD.gn [add] https://crrev.com/8d03446dde8241267009f8ad0671924b566d4bca/ios/third_party/material_internationalization_ios/LICENSE [add] https://crrev.com/8d03446dde8241267009f8ad0671924b566d4bca/ios/third_party/material_internationalization_ios/OWNERS [add] https://crrev.com/8d03446dde8241267009f8ad0671924b566d4bca/ios/third_party/material_internationalization_ios/README.chromium
,
Oct 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c199d513a16f7a429af225628573906f277418da commit c199d513a16f7a429af225628573906f277418da Author: Gauthier Ambard <gambard@chromium.org> Date: Wed Oct 25 17:37:49 2017 Roll MDC to fe66153a064fd2faf16c4d5d4486d8b54932533c Going from 656323ca63a39eba14487a374033fec9921cf0f2 to fe66153a064fd2faf16c4d5d4486d8b54932533c needs some updates of the BUILD.gn of MDC. Bug: 775476 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I3f2b16d8442fef24d2fc3910662a29db6c8b8be6 Reviewed-on: https://chromium-review.googlesource.com/722962 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#511506} [modify] https://crrev.com/c199d513a16f7a429af225628573906f277418da/DEPS [modify] https://crrev.com/c199d513a16f7a429af225628573906f277418da/ios/third_party/material_components_ios/BUILD.gn
,
Oct 26 2017
The roll has been unblocked. The current revision is 38.0.
,
Nov 2 2017
Request to MERGE the following CLs/commits to M63 3239 branch. 733951 Add a compile_entitlements template on macOS/iOS. 2017-10-24 11:00 de9557744f6c422f9ee15242259cfc5b47c70435 733841 Support both $() and ${} substitution in plist files. 2017-10-24 13:58 0a50430601ceda22003b0e806f6e6378eaf85532 723000 Adds MDF Internationalization dependency 2017-10-25 09:39 8d03446dde8241267009f8ad0671924b566d4bca 722962 Roll MDC to fe66153a064fd2faf16c4d5d4486d8b54932533c 2017-10-25 10:37 c199d513a16f7a429af225628573906f277418da 737437 [MDC roll] Roll Material Components to 97c6738501082716b216db1bd880565815758c1b 2017-10-25 15:52 c593a205309d6418a1cd6d72887516d181736c69 739723 [MDC roll] Roll Material Components to e4ef28e6796430e550023be60ff58d6418b40a49 2017-10-26 11:33 b3e846eb671bc536328805cc50d8807fe87fa155
,
Nov 2 2017
This bug requires manual review: Less than 29 days to go before AppStore submit on M63 Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 2 2017
Also requires rolling of piper (in downstream repository). 486312 [Piper roll] Manually roll piper to 9d29c11fd (sync with p4 at 173459375). 2017-10-26 02:11 784ce9939d4838064716ae466a44d1de358cb3dc
,
Nov 2 2017
,
Nov 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/df9b3809f80838eacb4f0f816977e5d6d76bbf85 commit df9b3809f80838eacb4f0f816977e5d6d76bbf85 Author: Peter K. Lee <pkl@chromium.org> Date: Thu Nov 02 21:49:44 2017 Roll MDC to fe66153a064fd2faf16c4d5d4486d8b54932533c Going from 656323ca63a39eba14487a374033fec9921cf0f2 to fe66153a064fd2faf16c4d5d4486d8b54932533c needs some updates of the BUILD.gn of MDC. TBR=gambard@chromium.org (cherry picked from commit c199d513a16f7a429af225628573906f277418da) Bug: 775476 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I3f2b16d8442fef24d2fc3910662a29db6c8b8be6 Reviewed-on: https://chromium-review.googlesource.com/722962 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#511506} Reviewed-on: https://chromium-review.googlesource.com/752198 Reviewed-by: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#357} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/df9b3809f80838eacb4f0f816977e5d6d76bbf85/DEPS [modify] https://crrev.com/df9b3809f80838eacb4f0f816977e5d6d76bbf85/ios/third_party/material_components_ios/BUILD.gn
,
Nov 2 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/buildspec/+/4019edaaa2dd2afa596b96820f9e1c942269acd4 commit 4019edaaa2dd2afa596b96820f9e1c942269acd4 Author: Peter K. Lee <pkl@chromium.org> Date: Thu Nov 02 22:58:30 2017
,
Nov 3 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/buildspec/+/5d3ed9308f6ccf3409e1cbb88416ae232f3e02f9 commit 5d3ed9308f6ccf3409e1cbb88416ae232f3e02f9 Author: Peter K. Lee <pkl@chromium.org> Date: Fri Nov 03 23:55:02 2017
,
Nov 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6f35121e1e492c296084fe2f2fc05ca3f95f3ea4 commit 6f35121e1e492c296084fe2f2fc05ca3f95f3ea4 Author: Peter K. Lee <pkl@chromium.org> Date: Mon Nov 06 23:17:09 2017 Adds MDF Internationalization dependency The dependency is needed because the newer versions of MDC needs it. This CL also roll MDC to e4ef28e6796430e550023be60ff58d6418b40a49. TBR=gambard@chromium.org (cherry picked from commit 8d03446dde8241267009f8ad0671924b566d4bca) Bug: 775476 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iabad6d33845d9e5e3e9ecb9ea86117abf0eb5ec9 Reviewed-on: https://chromium-review.googlesource.com/723000 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Chris Palmer <palmer@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#511486} Reviewed-on: https://chromium-review.googlesource.com/752382 Reviewed-by: Peter Lee <pkl@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#399} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/6f35121e1e492c296084fe2f2fc05ca3f95f3ea4/.gitignore [modify] https://crrev.com/6f35121e1e492c296084fe2f2fc05ca3f95f3ea4/DEPS [modify] https://crrev.com/6f35121e1e492c296084fe2f2fc05ca3f95f3ea4/ios/third_party/material_components_ios/BUILD.gn [modify] https://crrev.com/6f35121e1e492c296084fe2f2fc05ca3f95f3ea4/ios/third_party/material_components_ios/README.chromium [add] https://crrev.com/6f35121e1e492c296084fe2f2fc05ca3f95f3ea4/ios/third_party/material_internationalization_ios/BUILD.gn [add] https://crrev.com/6f35121e1e492c296084fe2f2fc05ca3f95f3ea4/ios/third_party/material_internationalization_ios/LICENSE [add] https://crrev.com/6f35121e1e492c296084fe2f2fc05ca3f95f3ea4/ios/third_party/material_internationalization_ios/OWNERS [add] https://crrev.com/6f35121e1e492c296084fe2f2fc05ca3f95f3ea4/ios/third_party/material_internationalization_ios/README.chromium |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by yuweih@chromium.org
, Oct 17 2017