New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 775471 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

All media session action buttons should be shown if all action handlers are set

Project Member Reported by fbeaufort@chromium.org, Oct 17 2017

Issue description

Chrome Version       : 63.0.3222.0
Android: 5, 6, 7, and 8

What steps will reproduce the problem?
1. Go to https://googlechrome.github.io/samples/media-session/video.html
2. Check out media session notification

What is the expected result?
I should see all media session action buttons (including Skip Next and Previous Track)

What happens instead of that?
I only see pause/play and seek backwards and seek forwards buttons on Android 5 and 6 while I can see all of them in Android 7 and 8. See screenshots below.


 
Android 5.0.jpg
59.3 KB View Download
Android 6.0.jpg
64.6 KB View Download
Android 7.0.jpg
53.8 KB View Download
Android 8.0.jpg
52.0 KB View Download
Labels: Needs-triage-Mobile
Cc: sandeepkumars@chromium.org
Just to add more info about this issue.

Tested the issue using #63.0.3222.0 on Android SM-J710F Build/MMB29K, 5.0.0:; Micromax A106 Build?LRX21M and observed the same behavior as mentioned in comment #0.

Thanks!1

Status: WontFix (was: Unconfirmed)
I believe this is an OS restriction where the notifications are shown in compact view in 5.0/6.0.
Owner: mlamouri@chromium.org
Status: Assigned (was: WontFix)
I don't think it's an OS restriction. Android 5.0 and 6.0 have a different layout when there are 5 actions. At the time, it was meant to unappealing to be used. Though, I think consistency is more important.
Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac270dea6409d067be283c99fa1905a0e1f7e40f

commit ac270dea6409d067be283c99fa1905a0e1f7e40f
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Wed Nov 01 11:49:30 2017

Media Notifications: allow to use 5 actions for pre-N devices.

There was a hard coded limitation to 3 actions because the pre-N
notifications do not look great with more than 3 actions but it is
breaking consistency for websites using the Media Session API.

This is also renaming `isRunningN()` to `isRunningAtLeastN()`.

Bug:  775471 
Change-Id: I2e9289ff0daa987acf0b656a239069676b03d722
Reviewed-on: https://chromium-review.googlesource.com/747221
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513107}
[modify] https://crrev.com/ac270dea6409d067be283c99fa1905a0e1f7e40f/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java

Status: Fixed (was: Started)
Labels: M-64

Sign in to add a comment