Regression : Right click context menu is seen misplaced on PDF.
Reported by
avsha...@etouch.net,
Oct 17 2017
|
||
Issue descriptionChrome version : 64.0.3242.0 (Official Build) 98a037253c9ba8c3c0fd2f927c8bc76e7ab2852f-refs/heads/master@{#509211} 32/64 bit OS : Windows (7,8,10), Linux(14.04 LTS), Mac(10.12.6) Test URL : https://msu.edu/~urban/sme865/resources/embedded_pdf.html What steps will reproduce the problem? 1. Launch chrome and navigate to above test URL. 2. Scroll down the page and right click on PDF file, observe the context menu. Actual Result : Right click context menu is seen misplaced. Expected Result : Context menu for PDF file should not be misplaced. This is a regression issue broken in ‘M-64’ and using the per-revision bisect providing the bisect results, Good build : 64.0.3241.0 (Revision : 508935) Bad build : 64.0.3242.0 (Revision : 509211) You are probably looking for a change made after 509090 (known good), but no later than 509091 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/eb592fb15ca50171c3a3d45225405010cdb933b8..17321e34f830fb514c28d32b1b30ab6991637b0b Suspect : https://chromium.googlesource.com/chromium/src/+/17321e34f830fb514c28d32b1b30ab6991637b0b @wjmaclean : Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Thank you!
,
Oct 17 2017
,
Oct 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/82b029bc0d2be29bcb95e79b5d11ebbbf6d820cc commit 82b029bc0d2be29bcb95e79b5d11ebbbf6d820cc Author: W. James MacLean <wjmaclean@chromium.org> Date: Mon Oct 23 15:05:43 2017 Fix coordinate transformations between plugins and context menus. This CL fixes two issues. (1) Coordinates sent from PDF plugins used to need adjustment in render_view_context_menu.cc since they were not properly converted to root view coordinates before arriving there. With the addition of TransformPointToRootView() to RenderWidgetHostViewGuest this is no longer the case, so the adjustment code has been removed. (2) However, when invoking view messages to the plugin in RenderViewHostImpl, up until now the root coords were never converted, nor did they need to be since the context menu managed to send the pre-adjustment values back. But now the context menu receives the proper coords in the first place, they need to be converted back to view space coords. This required implementing TransformPointToLocalCoordSpace, and a new helper TransformRootPointToViewCoords, to RenderWidgetHostViewGuest. The helper function may also need to be implemented for RenderWidgetHostViewChildFrame at some point in the future. Bug: 775460 , 775461 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: Icfb901295484657535e76007bee79b5cd1da8be8 Reviewed-on: https://chromium-review.googlesource.com/724722 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Reviewed-by: Charlie Reis <creis@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#510794} [modify] https://crrev.com/82b029bc0d2be29bcb95e79b5d11ebbbf6d820cc/chrome/browser/pdf/pdf_extension_test.cc [modify] https://crrev.com/82b029bc0d2be29bcb95e79b5d11ebbbf6d820cc/chrome/browser/renderer_context_menu/render_view_context_menu.cc [modify] https://crrev.com/82b029bc0d2be29bcb95e79b5d11ebbbf6d820cc/chrome/browser/renderer_context_menu/render_view_context_menu.h [modify] https://crrev.com/82b029bc0d2be29bcb95e79b5d11ebbbf6d820cc/chrome/browser/ui/cocoa/renderer_context_menu/render_view_context_menu_mac.mm [modify] https://crrev.com/82b029bc0d2be29bcb95e79b5d11ebbbf6d820cc/chrome/browser/ui/views/renderer_context_menu/render_view_context_menu_views.cc [add] https://crrev.com/82b029bc0d2be29bcb95e79b5d11ebbbf6d820cc/chrome/test/data/pdf/pdf_embed.html [modify] https://crrev.com/82b029bc0d2be29bcb95e79b5d11ebbbf6d820cc/content/browser/frame_host/render_widget_host_view_guest.cc [modify] https://crrev.com/82b029bc0d2be29bcb95e79b5d11ebbbf6d820cc/content/browser/frame_host/render_widget_host_view_guest.h [modify] https://crrev.com/82b029bc0d2be29bcb95e79b5d11ebbbf6d820cc/content/browser/renderer_host/render_view_host_impl.cc [modify] https://crrev.com/82b029bc0d2be29bcb95e79b5d11ebbbf6d820cc/content/browser/renderer_host/render_widget_host_view_base.cc [modify] https://crrev.com/82b029bc0d2be29bcb95e79b5d11ebbbf6d820cc/content/browser/renderer_host/render_widget_host_view_base.h [modify] https://crrev.com/82b029bc0d2be29bcb95e79b5d11ebbbf6d820cc/content/public/browser/render_widget_host_view.h [modify] https://crrev.com/82b029bc0d2be29bcb95e79b5d11ebbbf6d820cc/content/public/test/browser_test_utils.cc [modify] https://crrev.com/82b029bc0d2be29bcb95e79b5d11ebbbf6d820cc/content/public/test/browser_test_utils.h [modify] https://crrev.com/82b029bc0d2be29bcb95e79b5d11ebbbf6d820cc/testing/buildbot/filters/mus.browser_tests.filter
,
Oct 23 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by ranjitkan@chromium.org
, Oct 17 2017