New issue
Advanced search Search tips

Issue 775448 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

chrome_public_test_apk failing with AttributeError on NoopArchivedFile

Project Member Reported by perezju@chromium.org, Oct 17 2017

Issue description

At least on:
https://luci-milo.appspot.com/buildbot/chromium.android/KitKat%20Tablet%20Tester/
https://luci-milo.appspot.com/buildbot/chromium.android/Marshmallow%20Tablet%20Tester/
https://luci-milo.appspot.com/buildbot/chromium.android/Lollipop%20Tablet%20Tester/

The chrome_public_test_apk suite appears to be failing on multiple shards with:

E  891.637s Main  Unrecognized error occurred.
Traceback (most recent call last):
  File "/b/swarming/w/ir/build/android/test_runner.py", line 1010, in main
    return RunTestsCommand(args)
  File "/b/swarming/w/ir/build/android/test_runner.py", line 735, in RunTestsCommand
    return RunTestsInPlatformMode(args)
  File "/b/swarming/w/ir/build/android/test_runner.py", line 857, in RunTestsInPlatformMode
    raw_results = test_run.RunTests()
  File "/b/swarming/w/ir/build/android/pylib/local/device/local_device_test_run.py", line 124, in RunTests
    run_tests_on_device, tc, try_results).pGet(None)
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/utils/parallelizer.py", line 263, in pMap
    r.pFinish(None)
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/utils/parallelizer.py", line 135, in pFinish
    self._objs.JoinAll()
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/utils/reraiser_thread.py", line 186, in JoinAll
    self._JoinAll(watcher, timeout)
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/utils/reraiser_thread.py", line 158, in _JoinAll
    thread.ReraiseIfException()
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/utils/reraiser_thread.py", line 81, in run
    self._ret = self._func(*self._args, **self._kwargs)
  File "/b/swarming/w/ir/build/android/pylib/local/device/local_device_environment.py", line 66, in wrapper
    return f(dev, *args, **kwargs)
  File "/b/swarming/w/ir/build/android/pylib/local/device/local_device_test_run.py", line 71, in run_tests_on_device
    device=dev)
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/android/crash_handler.py", line 32, in RetryOnSystemCrash
    return f(device)
  File "/b/swarming/w/ir/build/android/pylib/local/device/local_device_test_run.py", line 70, in <lambda>
    lambda d, t=test: self._RunTest(d, t),
  File "/b/swarming/w/ir/build/android/pylib/local/device/local_device_instrumentation_test_run.py", line 519, in _RunTest
    step()
  File "/b/swarming/w/ir/build/android/pylib/local/device/local_device_instrumentation_test_run.py", line 502, in handle_render_test_data
    device, render_tests_device_output_dir, results)
  File "/b/swarming/w/ir/build/android/pylib/local/device/local_device_instrumentation_test_run.py", line 739, in _ProcessRenderTestResults
    failure_image_host_file)
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/android/decorators.py", line 57, in timeout_retry_wrapper
    retry_if_func=retry_if_func)
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/utils/timeout_retry.py", line 157, in Run
    error_log_func=error_log_func)
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/utils/reraiser_thread.py", line 186, in JoinAll
    self._JoinAll(watcher, timeout)
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/utils/reraiser_thread.py", line 158, in _JoinAll
    thread.ReraiseIfException()
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/utils/reraiser_thread.py", line 81, in run
    self._ret = self._func(*self._args, **self._kwargs)
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/utils/timeout_retry.py", line 150, in <lambda>
    child_thread = reraiser_thread.ReraiserThread(lambda: func(*args, **kwargs),
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/android/decorators.py", line 47, in impl
    return f(*args, **kwargs)
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/android/device_utils.py", line 1704, in PullFile
    dirname = os.path.dirname(host_path)
  File "/usr/lib/python2.7/posixpath.py", line 122, in dirname
    i = p.rfind('/') + 1
AttributeError: 'NoopArchivedFile' object has no attribute 'rfind'

 
Yep, the "NoopArchivedFile" was introduced there.
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d18897dac5186f5f6b24f07e1a4afebd172713c5

commit d18897dac5186f5f6b24f07e1a4afebd172713c5
Author: Juan Antonio Navarro Pérez <perezju@chromium.org>
Date: Tue Oct 17 10:29:00 2017

Revert "[android] Add local results details pages."

This reverts commit 425294bf256cbdaf307502effde7bd4ecd7b6c8e.

Reason for revert: Broke chrome_public_test_apk

Original change's description:
> [android] Add local results details pages.
> 
> Bug:  772032 
> Change-Id: Ieca8a24e1f2d4bfbae1bef4a1a4ebb0a67365710
> Reviewed-on: https://chromium-review.googlesource.com/702682
> Commit-Queue: John Budorick <jbudorick@chromium.org>
> Reviewed-by: Zhiling Huang <hzl@chromium.org>
> Reviewed-by: Yoland Yan <yolandyan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#509116}

TBR=yolandyan@chromium.org,hzl@chromium.org,jbudorick@chromium.org

Change-Id: I9c20ed803802cae8db453282f43008019103618f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  772032 , 775448 
Reviewed-on: https://chromium-review.googlesource.com/722642
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509346}
[add] https://crrev.com/d18897dac5186f5f6b24f07e1a4afebd172713c5/build/android/pylib/android/logdog_logcat_monitor.py
[modify] https://crrev.com/d18897dac5186f5f6b24f07e1a4afebd172713c5/build/android/pylib/base/environment.py
[modify] https://crrev.com/d18897dac5186f5f6b24f07e1a4afebd172713c5/build/android/pylib/base/environment_factory.py
[delete] https://crrev.com/e228732b4a18721df9398bcd0900347b331e4420/build/android/pylib/base/output_manager.py
[delete] https://crrev.com/e228732b4a18721df9398bcd0900347b331e4420/build/android/pylib/base/output_manager_factory.py
[modify] https://crrev.com/d18897dac5186f5f6b24f07e1a4afebd172713c5/build/android/pylib/gtest/gtest_test_instance.py
[modify] https://crrev.com/d18897dac5186f5f6b24f07e1a4afebd172713c5/build/android/pylib/instrumentation/instrumentation_test_instance.py
[modify] https://crrev.com/d18897dac5186f5f6b24f07e1a4afebd172713c5/build/android/pylib/local/device/local_device_environment.py
[modify] https://crrev.com/d18897dac5186f5f6b24f07e1a4afebd172713c5/build/android/pylib/local/device/local_device_gtest_run.py
[modify] https://crrev.com/d18897dac5186f5f6b24f07e1a4afebd172713c5/build/android/pylib/local/device/local_device_instrumentation_test_run.py
[modify] https://crrev.com/d18897dac5186f5f6b24f07e1a4afebd172713c5/build/android/pylib/local/machine/local_machine_environment.py
[delete] https://crrev.com/e228732b4a18721df9398bcd0900347b331e4420/build/android/pylib/output/__init__.py
[delete] https://crrev.com/e228732b4a18721df9398bcd0900347b331e4420/build/android/pylib/output/local_output_manager.py
[delete] https://crrev.com/e228732b4a18721df9398bcd0900347b331e4420/build/android/pylib/output/noop_output_manager.py
[delete] https://crrev.com/e228732b4a18721df9398bcd0900347b331e4420/build/android/pylib/output/remote_output_manager.py
[modify] https://crrev.com/d18897dac5186f5f6b24f07e1a4afebd172713c5/build/android/pylib/results/presentation/template/main.html
[modify] https://crrev.com/d18897dac5186f5f6b24f07e1a4afebd172713c5/build/android/pylib/results/presentation/test_results_presentation.py
[modify] https://crrev.com/d18897dac5186f5f6b24f07e1a4afebd172713c5/build/android/pylib/utils/google_storage_helper.py
[modify] https://crrev.com/d18897dac5186f5f6b24f07e1a4afebd172713c5/build/android/test_runner.py
[modify] https://crrev.com/d18897dac5186f5f6b24f07e1a4afebd172713c5/build/android/test_runner.pydeps

Labels: -Pri-1 Pri-2
Owner: jbudorick@chromium.org
Status: Assigned (was: Untriaged)
Also found on another job:

Traceback (most recent call last):
  File "/b/swarming/w/ir/build/android/test_runner.py", line 1010, in main
    return RunTestsCommand(args)
  File "/b/swarming/w/ir/build/android/test_runner.py", line 735, in RunTestsCommand
    return RunTestsInPlatformMode(args)
  File "/b/swarming/w/ir/build/android/test_runner.py", line 857, in RunTestsInPlatformMode
    raw_results = test_run.RunTests()
  File "/b/swarming/w/ir/build/android/pylib/local/device/local_device_test_run.py", line 124, in RunTests
    run_tests_on_device, tc, try_results).pGet(None)
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/utils/parallelizer.py", line 263, in pMap
    r.pFinish(None)
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/utils/parallelizer.py", line 135, in pFinish
    self._objs.JoinAll()
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/utils/reraiser_thread.py", line 186, in JoinAll
    self._JoinAll(watcher, timeout)
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/utils/reraiser_thread.py", line 158, in _JoinAll
    thread.ReraiseIfException()
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/utils/reraiser_thread.py", line 81, in run
    self._ret = self._func(*self._args, **self._kwargs)
  File "/b/swarming/w/ir/build/android/pylib/local/device/local_device_environment.py", line 66, in wrapper
    return f(dev, *args, **kwargs)
  File "/b/swarming/w/ir/build/android/pylib/local/device/local_device_test_run.py", line 71, in run_tests_on_device
    device=dev)
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/android/crash_handler.py", line 32, in RetryOnSystemCrash
    return f(device)
  File "/b/swarming/w/ir/build/android/pylib/local/device/local_device_test_run.py", line 70, in <lambda>
    lambda d, t=test: self._RunTest(d, t),
  File "/b/swarming/w/ir/build/android/pylib/local/device/local_device_instrumentation_test_run.py", line 519, in _RunTest
    step()
  File "/b/swarming/w/ir/build/android/pylib/local/device/local_device_instrumentation_test_run.py", line 502, in handle_render_test_data
    device, render_tests_device_output_dir, results)
  File "/b/swarming/w/ir/build/android/pylib/local/device/local_device_instrumentation_test_run.py", line 739, in _ProcessRenderTestResults
    failure_image_host_file)
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/android/decorators.py", line 57, in timeout_retry_wrapper
    retry_if_func=retry_if_func)
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/utils/timeout_retry.py", line 157, in Run
    error_log_func=error_log_func)
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/utils/reraiser_thread.py", line 186, in JoinAll
    self._JoinAll(watcher, timeout)
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/utils/reraiser_thread.py", line 158, in _JoinAll
    thread.ReraiseIfException()
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/utils/reraiser_thread.py", line 81, in run
    self._ret = self._func(*self._args, **self._kwargs)
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/utils/timeout_retry.py", line 150, in <lambda>
    child_thread = reraiser_thread.ReraiserThread(lambda: func(*args, **kwargs),
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/android/decorators.py", line 47, in impl
    return f(*args, **kwargs)
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/android/device_utils.py", line 1704, in PullFile
    dirname = os.path.dirname(host_path)
  File "/usr/lib/python2.7/posixpath.py", line 122, in dirname
    i = p.rfind('/') + 1
AttributeError: 'GoogleStorageArchivedFile' object has no attribute 'rfind'
https://chromium-swarm.appspot.com/task?id=39429e4eac82a710&refresh=10&show_raw=1
Odd that this didn't pop up on the trybots...
Yeah, sounds like some tests for this are also missing.
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/611646dc1b2211c58095b11c263864fedbd40fe9

commit 611646dc1b2211c58095b11c263864fedbd40fe9
Author: John Budorick <jbudorick@chromium.org>
Date: Tue Oct 17 20:39:46 2017

[android] Add local results details pages. (RELAND)

Bug:  772032 , 775448 
Change-Id: I784723c37a3d4e2c4adeec407170e5d0094c439a
Reviewed-on: https://chromium-review.googlesource.com/723659
Reviewed-by: Zhiling Huang <hzl@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509511}
[modify] https://crrev.com/611646dc1b2211c58095b11c263864fedbd40fe9/build/android/PRESUBMIT.py
[delete] https://crrev.com/b7915657bdb0890748dd74c55743f9c3bbde6ecc/build/android/pylib/android/logdog_logcat_monitor.py
[modify] https://crrev.com/611646dc1b2211c58095b11c263864fedbd40fe9/build/android/pylib/base/environment.py
[modify] https://crrev.com/611646dc1b2211c58095b11c263864fedbd40fe9/build/android/pylib/base/environment_factory.py
[add] https://crrev.com/611646dc1b2211c58095b11c263864fedbd40fe9/build/android/pylib/base/output_manager.py
[add] https://crrev.com/611646dc1b2211c58095b11c263864fedbd40fe9/build/android/pylib/base/output_manager_factory.py
[add] https://crrev.com/611646dc1b2211c58095b11c263864fedbd40fe9/build/android/pylib/base/output_manager_test_case.py
[modify] https://crrev.com/611646dc1b2211c58095b11c263864fedbd40fe9/build/android/pylib/gtest/gtest_test_instance.py
[modify] https://crrev.com/611646dc1b2211c58095b11c263864fedbd40fe9/build/android/pylib/instrumentation/instrumentation_test_instance.py
[modify] https://crrev.com/611646dc1b2211c58095b11c263864fedbd40fe9/build/android/pylib/local/device/local_device_environment.py
[modify] https://crrev.com/611646dc1b2211c58095b11c263864fedbd40fe9/build/android/pylib/local/device/local_device_gtest_run.py
[modify] https://crrev.com/611646dc1b2211c58095b11c263864fedbd40fe9/build/android/pylib/local/device/local_device_instrumentation_test_run.py
[modify] https://crrev.com/611646dc1b2211c58095b11c263864fedbd40fe9/build/android/pylib/local/machine/local_machine_environment.py
[add] https://crrev.com/611646dc1b2211c58095b11c263864fedbd40fe9/build/android/pylib/output/__init__.py
[add] https://crrev.com/611646dc1b2211c58095b11c263864fedbd40fe9/build/android/pylib/output/local_output_manager.py
[add] https://crrev.com/611646dc1b2211c58095b11c263864fedbd40fe9/build/android/pylib/output/local_output_manager_test.py
[add] https://crrev.com/611646dc1b2211c58095b11c263864fedbd40fe9/build/android/pylib/output/noop_output_manager.py
[add] https://crrev.com/611646dc1b2211c58095b11c263864fedbd40fe9/build/android/pylib/output/noop_output_manager_test.py
[add] https://crrev.com/611646dc1b2211c58095b11c263864fedbd40fe9/build/android/pylib/output/remote_output_manager.py
[add] https://crrev.com/611646dc1b2211c58095b11c263864fedbd40fe9/build/android/pylib/output/remote_output_manager_test.py
[modify] https://crrev.com/611646dc1b2211c58095b11c263864fedbd40fe9/build/android/pylib/results/presentation/template/main.html
[modify] https://crrev.com/611646dc1b2211c58095b11c263864fedbd40fe9/build/android/pylib/results/presentation/test_results_presentation.py
[modify] https://crrev.com/611646dc1b2211c58095b11c263864fedbd40fe9/build/android/pylib/utils/google_storage_helper.py
[modify] https://crrev.com/611646dc1b2211c58095b11c263864fedbd40fe9/build/android/test_runner.py
[modify] https://crrev.com/611646dc1b2211c58095b11c263864fedbd40fe9/build/android/test_runner.pydeps

Comment 9 by pasko@google.com, Oct 19 2017

Status: Fixed (was: Assigned)
seems fixed ..

Sign in to add a comment