New issue
Advanced search Search tips

Issue 775444 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 7
Cc:
Components:
EstimatedDays: ----
NextAction: 2017-11-20
OS: Chrome
Pri: 2
Type: Feature
M64



Sign in to add a comment

Enable TPM firmware update feature by default

Project Member Reported by mnissler@chromium.org, Oct 17 2017

Issue description

Unless we find significant evidence of TPM firmware updates systematically failing in the field, we should switch the default to enabled just before M64 branches. The finch experiment will remain in place to serve as a remote kill switch.

Setting NextAction as a reminder to do this a couple days before the anticipated M64 branch point.
 
DUN DUN DUNNN. This should be exciting.
Actually, it shouldn't change behavior at all - just preparing for a world where we no longer rely on finch to enable the feature.
From a user perspective it doesn't, indeed, but it's pretty meaningful for us given the concerns about the update process.
The NextAction date has arrived: 2017-11-20
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd4d3ed593b1071d3f91865f64cd7ebf32ab9cec

commit cd4d3ed593b1071d3f91865f64cd7ebf32ab9cec
Author: Mattias Nissler <mnissler@chromium.org>
Date: Thu Nov 23 11:59:21 2017

Enable TPMFirmwareUpdate feature by default.

BUG= chromium:775444 
TEST=TPM firmware update offered in powerwash dialog even without finch config.

Change-Id: I39137545c7c940c39c3e0be86cb0707213336a86
Reviewed-on: https://chromium-review.googlesource.com/779101
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Commit-Queue: Mattias Nissler <mnissler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518894}
[modify] https://crrev.com/cd4d3ed593b1071d3f91865f64cd7ebf32ab9cec/chrome/common/chrome_features.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Nov 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/280ef0144f9f2490e7c29c12325e649a7aef17cd

commit 280ef0144f9f2490e7c29c12325e649a7aef17cd
Author: Mattias Nissler <mnissler@chromium.org>
Date: Fri Nov 24 08:44:26 2017

Revert "Enable TPMFirmwareUpdate feature by default."

This reverts commit cd4d3ed593b1071d3f91865f64cd7ebf32ab9cec.

Reason for revert: We're not ready to flip the default as long as the update failures on link are still present.

Original change's description:
> Enable TPMFirmwareUpdate feature by default.
> 
> BUG= chromium:775444 
> TEST=TPM firmware update offered in powerwash dialog even without finch config.
> 
> Change-Id: I39137545c7c940c39c3e0be86cb0707213336a86
> Reviewed-on: https://chromium-review.googlesource.com/779101
> Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
> Commit-Queue: Mattias Nissler <mnissler@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#518894}

TBR=jorgelo@chromium.org,mnissler@chromium.org

Change-Id: Idb056e8aa92031badd7a8faef40e5f2abd81bb43
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  chromium:775444 
Reviewed-on: https://chromium-review.googlesource.com/788353
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Commit-Queue: Mattias Nissler <mnissler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519070}
[modify] https://crrev.com/280ef0144f9f2490e7c29c12325e649a7aef17cd/chrome/common/chrome_features.cc

Components: OS>Systems>Security
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86ed264efb4c7efbbc0bcc4d5164f7cc36873a09

commit 86ed264efb4c7efbbc0bcc4d5164f7cc36873a09
Author: Mattias Nissler <mnissler@chromium.org>
Date: Tue Nov 06 12:21:22 2018

Enable TPMFirmwareUpdate feature by default.

BUG= chromium:775444 
TEST=TPM firmware update offered in powerwash dialog even without finch config.

Change-Id: I533afd2306c6e5f8af943f81f4f15542cf7ba116
Reviewed-on: https://chromium-review.googlesource.com/c/1317896
Reviewed-by: Rahul Chaturvedi <rkc@chromium.org>
Commit-Queue: Mattias Nissler <mnissler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605658}
[modify] https://crrev.com/86ed264efb4c7efbbc0bcc4d5164f7cc36873a09/chrome/common/chrome_features.cc

Status: Fixed (was: Assigned)

Sign in to add a comment