It seems that this code is actually never used from the renderer, and thus we don't need a core/common directory. It should probably be merged back into core/browser.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2a5a0d8e3bec22edfa275a32264613fc28430ca4 commit 2a5a0d8e3bec22edfa275a32264613fc28430ca4 Author: David Roger <droger@chromium.org> Date: Wed Oct 18 14:04:09 2017 [signin] Remove dependency from chrome/common on components/signin TBR: jochen Bug: 775422 Change-Id: I54e51a886933b722515f027aa4078572ff3f07b5 Reviewed-on: https://chromium-review.googlesource.com/725423 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#509762} [modify] https://crrev.com/2a5a0d8e3bec22edfa275a32264613fc28430ca4/chrome/browser/ui/webui/signin_internals_ui.cc [modify] https://crrev.com/2a5a0d8e3bec22edfa275a32264613fc28430ca4/chrome/common/BUILD.gn [modify] https://crrev.com/2a5a0d8e3bec22edfa275a32264613fc28430ca4/chrome/common/DEPS [modify] https://crrev.com/2a5a0d8e3bec22edfa275a32264613fc28430ca4/chrome/common/url_constants.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a6c8812a4bcc49d77d62989f6aff6327bd30310c commit a6c8812a4bcc49d77d62989f6aff6327bd30310c Author: David Roger <droger@chromium.org> Date: Wed Oct 25 13:02:46 2017 Move components/signin/core/common into components/signin/core/browser This CL moves all files from components/signin/core/common to components/signin/core/browser. A lot of files are affected because the include paths have to be updated. TBR=jochen Bug: 775422 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I0b6a917515e2a084f18ce2b8b6476516110bb130 Reviewed-on: https://chromium-review.googlesource.com/735147 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#511429} [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/BUILD.gn [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/about_flags.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/android/preferences/pref_service_bridge.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/android/signin/signin_manager_android.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/browser_process_impl.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/chrome_browser_main.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/chromeos/login/kiosk_browsertest.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/chromeos/login/signin/device_id_browsertest.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/extensions/api/identity/identity_apitest.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/extensions/api/identity/identity_get_accounts_function.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/extensions/api/identity/identity_get_auth_token_function.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/loader/chrome_resource_dispatcher_host_delegate_browsertest.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/policy/configuration_policy_handler_list_factory.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/prefs/browser_prefs.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/prefs/chrome_pref_service_factory.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/printing/print_dialog_cloud.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/profiles/avatar_menu.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/profiles/gaia_info_update_service.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/profiles/gaia_info_update_service_unittest.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/profiles/host_zoom_map_browsertest.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/profiles/profile_impl.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/profiles/profile_info_cache.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/profiles/profile_info_cache_unittest.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/profiles/profile_io_data.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/profiles/profile_list_desktop.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/profiles/profile_list_desktop_unittest.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/profiles/profile_manager.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/profiles/profile_manager_unittest.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/profiles/profile_window.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/profiles/profile_window_browsertest.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/profiles/profiles_state.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/signin/account_reconcilor_unittest.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/signin/chrome_signin_client.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/signin/chrome_signin_helper.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/signin/chrome_signin_helper_unittest.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/signin/dice_browsertest.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/signin/dice_response_handler.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/signin/dice_response_handler_unittest.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/signin/mutable_profile_oauth2_token_service_delegate.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/signin/mutable_profile_oauth2_token_service_delegate_unittest.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/signin/process_dice_header_observer_impl.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/signin/signin_global_error.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/signin/signin_manager_unittest.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/signin/signin_promo.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/signin/signin_tracker_factory.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/signin/signin_ui_util.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/supervised_user/child_accounts/child_account_service.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/supervised_user/supervised_user_pref_store.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/supervised_user/supervised_user_service.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/ui/browser_command_controller.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/ui/browser_command_controller_browsertest.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/ui/browser_command_controller_unittest.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/ui/cocoa/browser_window_controller.mm [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/ui/cocoa/profiles/avatar_button_controller.mm [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/ui/cocoa/profiles/avatar_button_controller_unittest.mm [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/ui/cocoa/profiles/avatar_icon_controller_unittest.mm [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/ui/cocoa/profiles/profile_menu_controller.mm [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/ui/sync/one_click_signin_sync_starter.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/ui/toolbar/app_menu_model.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/ui/views/frame/browser_view.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout_unittest.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/ui/views/profiles/profile_chooser_view.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/ui/webui/print_preview/print_preview_handler.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/ui/webui/profile_info_watcher.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/ui/webui/settings/people_handler.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/ui/webui/settings/settings_manage_profile_handler.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/ui/webui/signin/inline_login_handler.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/ui/webui/signin/inline_login_ui.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/ui/webui/signin/login_ui_service.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/ui/webui/signin/user_manager_screen_handler.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/ui/webui/signin/user_manager_ui_browsertest.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/ui/webui/signin_internals_ui.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/browser/ui/zoom/zoom_controller_browsertest.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/renderer/DEPS [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/renderer/chrome_content_renderer_client.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/chrome/test/BUILD.gn [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/components/autofill/core/browser/BUILD.gn [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/components/autofill/core/browser/autofill_metrics_unittest.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/components/autofill/core/browser/autofill_test_utils.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/components/autofill/core/browser/personal_data_manager.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/components/autofill/core/browser/personal_data_manager_unittest.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/components/browser_sync/BUILD.gn [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/components/browser_sync/DEPS [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/components/browser_sync/profile_sync_service.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/components/browser_sync/profile_sync_service_startup_unittest.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/components/ntp_snippets/BUILD.gn [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/components/ntp_snippets/remote/remote_suggestions_status_service_impl_unittest.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/components/ntp_snippets/remote/test_utils.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/components/password_manager/sync/browser/BUILD.gn [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/components/password_manager/sync/browser/sync_username_test_base.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/components/signin/core/browser/BUILD.gn [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/components/signin/core/browser/about_signin_internals.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/components/signin/core/browser/account_fetcher_service.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/components/signin/core/browser/account_investigator.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/components/signin/core/browser/account_investigator_unittest.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/components/signin/core/browser/account_reconcilor.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/components/signin/core/browser/account_tracker_service.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/components/signin/core/browser/account_tracker_service_unittest.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/components/signin/core/browser/chrome_connected_header_helper.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/components/signin/core/browser/dice_header_helper.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/components/signin/core/browser/gaia_cookie_manager_service_unittest.cc [rename] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/components/signin/core/browser/profile_management_switches.cc [rename] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/components/signin/core/browser/profile_management_switches.h [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/components/signin/core/browser/profile_management_switches_unittest.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/components/signin/core/browser/profile_oauth2_token_service.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/components/signin/core/browser/refresh_token_annotation_request.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/components/signin/core/browser/refresh_token_annotation_request_unittest.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/components/signin/core/browser/scoped_account_consistency.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/components/signin/core/browser/scoped_account_consistency.h [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/components/signin/core/browser/signin_client.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/components/signin/core/browser/signin_header_helper.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/components/signin/core/browser/signin_header_helper.h [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/components/signin/core/browser/signin_header_helper_unittest.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/components/signin/core/browser/signin_investigator.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/components/signin/core/browser/signin_investigator_unittest.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/components/signin/core/browser/signin_manager.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/components/signin/core/browser/signin_manager_base.cc [rename] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/components/signin/core/browser/signin_pref_names.cc [rename] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/components/signin/core/browser/signin_pref_names.h [rename] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/components/signin/core/browser/signin_switches.cc [rename] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/components/signin/core/browser/signin_switches.h [delete] https://crrev.com/cd32fdf5709b0ec9aa71502dfec1e84f8f3567c3/components/signin/core/common/BUILD.gn [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/components/signin/ios/browser/BUILD.gn [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/components/signin/ios/browser/account_consistency_service_unittest.mm [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/components/signin/ios/browser/profile_oauth2_token_service_ios_delegate.mm [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/components/signin/ios/browser/profile_oauth2_token_service_ios_delegate_unittest.mm [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/ios/chrome/browser/DEPS [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/ios/chrome/browser/about_flags.mm [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/ios/chrome/browser/browser_state/BUILD.gn [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/ios/chrome/browser/browser_state/chrome_browser_state_io_data.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/ios/chrome/browser/experimental_flags.mm [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/ios/chrome/browser/prefs/BUILD.gn [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/ios/chrome/browser/prefs/browser_prefs.mm [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/ios/chrome/browser/signin/BUILD.gn [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/ios/chrome/browser/signin/authentication_service_unittest.mm [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/ios/chrome/browser/signin/browser_state_data_remover.mm [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/ios/chrome/browser/signin/signin_manager_factory.cc [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/ios/chrome/browser/ui/authentication/BUILD.gn [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/ios/chrome/browser/ui/authentication/authentication_flow_performer.mm [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/ios/chrome/browser/ui/settings/BUILD.gn [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/ios/chrome/browser/ui/settings/settings_collection_view_controller.mm [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/ios/chrome/browser/ui/signin_interaction/BUILD.gn [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/ios/chrome/browser/ui/signin_interaction/signin_interaction_controller.mm [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/ios/chrome/test/DEPS [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/ios/chrome/test/app/signin_test_util.mm [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/ios/chrome/test/earl_grey/BUILD.gn [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/ios/chrome/test/earl_grey/chrome_test_case.mm [modify] https://crrev.com/a6c8812a4bcc49d77d62989f6aff6327bd30310c/ios/web_view/internal/signin/web_view_signin_manager_factory.cc
Comment 1 by bugdroid1@chromium.org
, Oct 18 2017