Chromium roll into WebRTC blocked on third_party/opus compile errors. |
||||||
Issue description
The Chromium roll into WebRTC [1] fails on the compile step with the following error (full logs at [2]):
../../third_party/opus/src/silk/fixed/arm/warped_autocorrelation_FIX_neon_intr.c:43:37: error: incompatible pointer types assigning to 'const long *' from 'long long *' [-Werror,-Wincompatible-pointer-types]
corr_QC_s64x2[ 0 ] = vld1q_s64( corr_QC + offset + 0 );
^~~~~~~~~~~~~~~~~~~~
../../third_party/llvm-build/Release+Asserts/lib/clang/6.0.0/include/arm_neon.h:7628:46: note: expanded from macro 'vld1q_s64'
__ret = (int64x2_t) __builtin_neon_vld1q_v(__p0, 35); \
^~~~
../../third_party/opus/src/silk/fixed/arm/warped_autocorrelation_FIX_neon_intr.c:44:37: error: incompatible pointer types assigning to 'const long *' from 'long long *' [-Werror,-Wincompatible-pointer-types]
corr_QC_s64x2[ 1 ] = vld1q_s64( corr_QC + offset + 2 );
^~~~~~~~~~~~~~~~~~~~
../../third_party/llvm-build/Release+Asserts/lib/clang/6.0.0/include/arm_neon.h:7628:46: note: expanded from macro 'vld1q_s64'
__ret = (int64x2_t) __builtin_neon_vld1q_v(__p0, 35); \
^~~~
../../third_party/opus/src/silk/fixed/arm/warped_autocorrelation_FIX_neon_intr.c:49:16: error: incompatible pointer types assigning to 'long *' from 'long long *' [-Werror,-Wincompatible-pointer-types]
vst1q_s64( corr_QC + offset + 0, corr_QC_s64x2[ 0 ] );
^~~~~~~~~~~~~~~~~~~~
../../third_party/llvm-build/Release+Asserts/lib/clang/6.0.0/include/arm_neon.h:25122:26: note: expanded from macro 'vst1q_s64'
__builtin_neon_vst1q_v(__p0, (int8x16_t)__s1, 35); \
^~~~
../../third_party/opus/src/silk/fixed/arm/warped_autocorrelation_FIX_neon_intr.c:50:16: error: incompatible pointer types assigning to 'long *' from 'long long *' [-Werror,-Wincompatible-pointer-types]
vst1q_s64( corr_QC + offset + 2, corr_QC_s64x2[ 1 ] );
^~~~~~~~~~~~~~~~~~~~
../../third_party/llvm-build/Release+Asserts/lib/clang/6.0.0/include/arm_neon.h:25122:26: note: expanded from macro 'vst1q_s64'
__builtin_neon_vst1q_v(__p0, (int8x16_t)__s1, 35); \
^~~~
../../third_party/opus/src/silk/fixed/arm/warped_autocorrelation_FIX_neon_intr.c:230:41: error: incompatible pointer types assigning to 'const long *' from 'long long *' [-Werror,-Wincompatible-pointer-types]
corr_QC0_s64x2 = vld1q_s64( corr_QCT + i );
^~~~~~~~~~~~
../../third_party/llvm-build/Release+Asserts/lib/clang/6.0.0/include/arm_neon.h:7628:46: note: expanded from macro 'vld1q_s64'
__ret = (int64x2_t) __builtin_neon_vld1q_v(__p0, 35); \
^~~~
../../third_party/opus/src/silk/fixed/arm/warped_autocorrelation_FIX_neon_intr.c:231:41: error: incompatible pointer types assigning to 'const long *' from 'long long *' [-Werror,-Wincompatible-pointer-types]
corr_QC1_s64x2 = vld1q_s64( corr_QCT + i + 2 );
^~~~~~~~~~~~~~~~
../../third_party/llvm-build/Release+Asserts/lib/clang/6.0.0/include/arm_neon.h:7628:46: note: expanded from macro 'vld1q_s64'
__ret = (int64x2_t) __builtin_neon_vld1q_v(__p0, 35); \
^~~~
6 errors generated.
[1] https://webrtc-review.googlesource.com/c/src/+/11500
[2] https://build.chromium.org/p/tryserver.webrtc/builders/linux_arm64_rel/builds/5645/steps/compile/logs/stdio
,
Oct 17 2017
,
Oct 17 2017
+flim in case she can help out.
,
Oct 17 2017
Same issue when Chromium roll into Chromecast, failing on Linux arm64 platforms only.
,
Oct 17 2017
,
Oct 18 2017
This is due to https://chromium-review.googlesource.com/c/chromium/src/+/681703. I will upload a CL to fix it.
,
Oct 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/77e8f280a8500507002a41e1761c52f167a8eca0 commit 77e8f280a8500507002a41e1761c52f167a8eca0 Author: Kári Tristan Helgason <kthelgason@chromium.org> Date: Wed Oct 18 10:58:25 2017 Only enable opus neon opts on arm64 iOS. I will enable other platforms when I have the opportunity to test on them. Bug: 775413 Change-Id: I38fd1308ba3a3e7dcedc8802c813814d737f4fe6 Reviewed-on: https://chromium-review.googlesource.com/725379 Commit-Queue: Kári Tristan Helgason <kthelgason@chromium.org> Reviewed-by: Henrik Andreasson <henrika@chromium.org> Cr-Commit-Position: refs/heads/master@{#509737} [modify] https://crrev.com/77e8f280a8500507002a41e1761c52f167a8eca0/third_party/opus/BUILD.gn
,
Oct 18 2017
ehmaldonado@: Can you verify that this fixed the chromium roll?
,
Oct 18 2017
Yes. It is still blocked, but because other reasons. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by ehmaldonado@chromium.org
, Oct 17 2017Status: Assigned (was: Untriaged)