Add runs/minute to Speedometer results |
|||
Issue descriptionCurrently the key metric we use from Telemetry is the total time of the benchmark run, but the UI reports runs/minute. The total time is subject to the number of iterations the benchmark runs and can present false performance changes. We'd like to extract the runs/minute number from the UI and store that in chromeperf too.
,
Oct 18 2017
Awesome, thanks for doing that. We probably also need the same thing for Speedometer 2.
,
Oct 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5356c29c2baeffbc8684541feead29e9ef1d555a commit 5356c29c2baeffbc8684541feead29e9ef1d555a Author: Ben Cheng <bccheng@google.com> Date: Thu Oct 19 01:38:28 2017 Extract and report runs/minute for Speedometer BUG=chromium:775410 Change-Id: I1d7596cc21435dd77d5034bcdbba1469a0c5fe0d Reviewed-on: https://chromium-review.googlesource.com/724760 Reviewed-by: Ned Nguyen <nednguyen@google.com> Reviewed-by: Michael Hablich <hablich@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Ben Cheng <bccheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#509966} [modify] https://crrev.com/5356c29c2baeffbc8684541feead29e9ef1d555a/tools/perf/benchmarks/speedometer.py
,
Oct 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a6ba03d35d8e187799e9e3b63c98eff490018b71 commit a6ba03d35d8e187799e9e3b63c98eff490018b71 Author: Ben Cheng <bccheng@google.com> Date: Wed Oct 25 15:38:34 2017 Report RunsPerMinute for speedometer The slash in the original string "Runs/Minute" is used as an escape character for subtests. BUG=chromium:775410 Change-Id: I073f4b8beed6401de33ad8e078e4f53d6eae911e Reviewed-on: https://chromium-review.googlesource.com/737229 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Ben Cheng <bccheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#511471} [modify] https://crrev.com/a6ba03d35d8e187799e9e3b63c98eff490018b71/tools/perf/benchmarks/speedometer.py
,
Oct 3
Anything remaining to do for this bug? Looks like this is done after Ben's CLs. |
|||
►
Sign in to add a comment |
|||
Comment 1 by nedngu...@google.com
, Oct 17 2017