New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 775389 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Migrate WebRTC masters to LogDog

Project Member Reported by kjellander@chromium.org, Oct 17 2017

Issue description

We've had LogDog enabled for these masters for a long time:
    'client.webrtc': {},
    'client.webrtc.branches': {},
    'client.webrtc.fyi': {},
    'client.webrtc.perf': {},
    'tryserver.webrtc': {},
(snippet from the config; https://cs.chromium.org/chromium/build/scripts/slave/logdog-params.pyl?rcl=e53e846adcfbea9fb57f2ff74278aa33e19b100a&l=226)

This produces the [stdout] link next to the regular Buildbot stdio link to the output of the step.
In order to reduce confusion among our users and to reduce the I/O load on the masters, we should make our bots be LogDog only. This is done by adding a dict like this inside each entry above:
'*': {
  'logdog_only': True,
},

I believe no master restart is needed for this to take effect.
 
Owner: phoglund@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/cd9c261249a119a41c3f3b2e14d47018fb55cfe7

commit cd9c261249a119a41c3f3b2e14d47018fb55cfe7
Author: Patrik Höglund <phoglund@chromium.org>
Date: Tue Oct 17 13:57:13 2017

Make WebRTC masters logdog only.

This reduces I/O load on the masters since they don't have to process
the logs coming from the slaves.

Bug:775389
Change-Id: I6251fde8c71290cb1fc16f385786f46ae85ed443
Reviewed-on: https://chromium-review.googlesource.com/721549
Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>

[modify] https://crrev.com/cd9c261249a119a41c3f3b2e14d47018fb55cfe7/scripts/slave/logdog-params.pyl

Status: Fixed (was: Assigned)
I spot-checked some bots and it looks like it's working fine!
What was that, spot bonus?? Oh, spot checked. Right.

;)

Sign in to add a comment