New issue
Advanced search Search tips

Issue 775381 link

Starred by 1 user
Status: Fixed
Owner:
tetsui@chromium.org
Closed: Oct 2017
Cc:
peter@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Sync error notification layout is broken.

Project Member Reported by tetsui@chromium.org, Oct 17 2017 
What steps will reproduce the problem?
(1) Log in to a Google accout with sync passphrase.

What is the expected result?
The sync error notification should be shown with the same style as the sign-in error notification.

What happens instead?
See the screenshot.
unnamed.png
204 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93c331c2b5119398908649e2473e1c2307513b1b

commit 93c331c2b5119398908649e2473e1c2307513b1b
Author: Tetsui Ohkubo <tetsui@chromium.org>
Date: Wed Oct 18 05:12:12 2017

Apply system style to sync error notification.

In new-style notification, system notification has different style from
other notifications such as web notifications.

This CL fixes sync error notification:
* The context header shows the title "Sign In".
* The context header has an accent color.
* "Update sync passphrase" button is removed.
* New MD icon is used.

If chrome://flags#enable-message-center-new-style-notification is
disabled, this CL has no effect.

Before: http://screen/kTTXQujdxao
After: http://screen/WoRuaLE732T

TEST=manually tested on chell device
BUG= 775381 

Change-Id: I8c030131a5a9241223b6b02601fabe4035e9b866
Reviewed-on: https://chromium-review.googlesource.com/722545
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509689}
[modify] https://crrev.com/93c331c2b5119398908649e2473e1c2307513b1b/chrome/browser/sync/sync_error_notifier_ash.cc
[modify] https://crrev.com/93c331c2b5119398908649e2473e1c2307513b1b/chrome/browser/sync/sync_error_notifier_ash_unittest.cc

Comment 2 by tetsui@chromium.org, Oct 18 2017

Status: Fixed (was: Started)
►

Sign in to add a comment