New issue
Advanced search Search tips

Issue 775367 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

crosvm: minijail changes to support minijail_fork

Project Member Reported by smbar...@chromium.org, Oct 17 2017

Issue description

crosvm should use minijail fork to eliminate terrible, no-good direct calls to clone.

TODO items:
1) We currently exceed the fd limit for minijail's preservable fds. This should be increased.
2) libminijail unconditionally sets pgid for the parent process to itself. Which is fine if we call crosvm directly, but fails when using vm_launcher:

vm_launcher (process group leader)
   |--- crosvm main process (calls minijail_fork)
            | ---- crosvm jailed device process

crosvm setting its own pgid removes it from the process group with vm_launcher, which means we end up with isatty(stdio) == true, but we can no longer read, write, or set the terminal to raw mode.
 
Status: Fixed (was: Untriaged)

Comment 2 by dchan@chromium.org, Jan 22 2018

Status: archived (was: Fixed)

Comment 3 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment