Logic from CSSComputedStyleDeclaration::IsLayoutDependent should be moved to property APIs & deleted from CSSComputedStyleDeclaration
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dc3ee1fdffc7fd640f54bbbe114e84c928de2103 commit dc3ee1fdffc7fd640f54bbbe114e84c928de2103 Author: Renee Wright <rjwright@chromium.org> Date: Fri Oct 20 04:50:51 2017 [Ribbon] Split up IsLayoutDependent and replace some IDs with APIs Ribbonized CSSComputedStyleDeclaration::IsLayoutDependent Changed CSSComputedStyleDeclaration::GetPropertyCSSValue to take an API instead of an ID. This change could be propagated out to some of the callers of GetPropertyCSSValue, but I avoided doing so in this CL because I wanted to keep it small. Bug: 775363 Change-Id: I93d92d9ce7c30fcfa6efdb450382f9a18681bf18 Reviewed-on: https://chromium-review.googlesource.com/727602 Commit-Queue: Renée Wright <rjwright@chromium.org> Reviewed-by: meade_UTC10 <meade@chromium.org> Cr-Commit-Position: refs/heads/master@{#510339} [modify] https://crrev.com/dc3ee1fdffc7fd640f54bbbe114e84c928de2103/third_party/WebKit/Source/build/scripts/core/css/properties/templates/CSSPropertyAPI.h.tmpl [modify] https://crrev.com/dc3ee1fdffc7fd640f54bbbe114e84c928de2103/third_party/WebKit/Source/build/scripts/core/css/properties/templates/CSSPropertyAPISubclass.h.tmpl [modify] https://crrev.com/dc3ee1fdffc7fd640f54bbbe114e84c928de2103/third_party/WebKit/Source/core/BUILD.gn [modify] https://crrev.com/dc3ee1fdffc7fd640f54bbbe114e84c928de2103/third_party/WebKit/Source/core/css/BUILD.gn [modify] https://crrev.com/dc3ee1fdffc7fd640f54bbbe114e84c928de2103/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp [modify] https://crrev.com/dc3ee1fdffc7fd640f54bbbe114e84c928de2103/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.h [modify] https://crrev.com/dc3ee1fdffc7fd640f54bbbe114e84c928de2103/third_party/WebKit/Source/core/css/CSSProperties.json5 [modify] https://crrev.com/dc3ee1fdffc7fd640f54bbbe114e84c928de2103/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIMethods.json5 [modify] https://crrev.com/dc3ee1fdffc7fd640f54bbbe114e84c928de2103/third_party/WebKit/Source/core/css/properties/longhands/CSSPropertyAPIGridTemplateLine.cpp [delete] https://crrev.com/35d697ee2286c3856fd5c9f09d01a4e182102fb5/third_party/WebKit/Source/core/css/properties/longhands/CSSPropertyAPIMargin.cpp [add] https://crrev.com/dc3ee1fdffc7fd640f54bbbe114e84c928de2103/third_party/WebKit/Source/core/css/properties/longhands/CSSPropertyAPIMarginBottom.cpp [add] https://crrev.com/dc3ee1fdffc7fd640f54bbbe114e84c928de2103/third_party/WebKit/Source/core/css/properties/longhands/CSSPropertyAPIMarginLeft.cpp [add] https://crrev.com/dc3ee1fdffc7fd640f54bbbe114e84c928de2103/third_party/WebKit/Source/core/css/properties/longhands/CSSPropertyAPIMarginRight.cpp [add] https://crrev.com/dc3ee1fdffc7fd640f54bbbe114e84c928de2103/third_party/WebKit/Source/core/css/properties/longhands/CSSPropertyAPIMarginTop.cpp [modify] https://crrev.com/dc3ee1fdffc7fd640f54bbbe114e84c928de2103/third_party/WebKit/Source/core/css/properties/longhands/CSSPropertyAPIOffset.cpp [delete] https://crrev.com/35d697ee2286c3856fd5c9f09d01a4e182102fb5/third_party/WebKit/Source/core/css/properties/longhands/CSSPropertyAPIPadding.cpp [add] https://crrev.com/dc3ee1fdffc7fd640f54bbbe114e84c928de2103/third_party/WebKit/Source/core/css/properties/longhands/CSSPropertyAPIPaddingBottom.cpp [add] https://crrev.com/dc3ee1fdffc7fd640f54bbbe114e84c928de2103/third_party/WebKit/Source/core/css/properties/longhands/CSSPropertyAPIPaddingLeft.cpp [add] https://crrev.com/dc3ee1fdffc7fd640f54bbbe114e84c928de2103/third_party/WebKit/Source/core/css/properties/longhands/CSSPropertyAPIPaddingRight.cpp [add] https://crrev.com/dc3ee1fdffc7fd640f54bbbe114e84c928de2103/third_party/WebKit/Source/core/css/properties/longhands/CSSPropertyAPIPaddingTop.cpp [modify] https://crrev.com/dc3ee1fdffc7fd640f54bbbe114e84c928de2103/third_party/WebKit/Source/core/css/properties/longhands/CSSPropertyAPIPerspectiveOrigin.cpp [modify] https://crrev.com/dc3ee1fdffc7fd640f54bbbe114e84c928de2103/third_party/WebKit/Source/core/css/properties/longhands/CSSPropertyAPITransform.cpp [modify] https://crrev.com/dc3ee1fdffc7fd640f54bbbe114e84c928de2103/third_party/WebKit/Source/core/css/properties/longhands/CSSPropertyAPITransformOrigin.cpp [modify] https://crrev.com/dc3ee1fdffc7fd640f54bbbe114e84c928de2103/third_party/WebKit/Source/core/css/properties/longhands/CSSPropertyAPITranslate.cpp [modify] https://crrev.com/dc3ee1fdffc7fd640f54bbbe114e84c928de2103/third_party/WebKit/Source/core/css/properties/longhands/CSSPropertyAPIWidthOrHeight.cpp [modify] https://crrev.com/dc3ee1fdffc7fd640f54bbbe114e84c928de2103/third_party/WebKit/Source/core/css/properties/shorthands/CSSShorthandPropertyAPIGrid.cpp [modify] https://crrev.com/dc3ee1fdffc7fd640f54bbbe114e84c928de2103/third_party/WebKit/Source/core/css/properties/shorthands/CSSShorthandPropertyAPIGridTemplate.cpp [modify] https://crrev.com/dc3ee1fdffc7fd640f54bbbe114e84c928de2103/third_party/WebKit/Source/core/css/properties/shorthands/CSSShorthandPropertyAPIMargin.cpp [modify] https://crrev.com/dc3ee1fdffc7fd640f54bbbe114e84c928de2103/third_party/WebKit/Source/core/css/properties/shorthands/CSSShorthandPropertyAPIPadding.cpp [modify] https://crrev.com/dc3ee1fdffc7fd640f54bbbe114e84c928de2103/third_party/WebKit/Source/core/editing/EditingStyle.cpp [modify] https://crrev.com/dc3ee1fdffc7fd640f54bbbe114e84c928de2103/third_party/WebKit/Source/core/editing/EditingStyleUtilities.cpp [modify] https://crrev.com/dc3ee1fdffc7fd640f54bbbe114e84c928de2103/third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp [modify] https://crrev.com/dc3ee1fdffc7fd640f54bbbe114e84c928de2103/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp [modify] https://crrev.com/dc3ee1fdffc7fd640f54bbbe114e84c928de2103/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp
Comment 1 by rjwright@chromium.org
, Oct 17 2017