New issue
Advanced search Search tips

Issue 775328 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 775171



Sign in to add a comment

Need -Wunused-variable cleanup after clang r315811

Project Member Reported by r...@chromium.org, Oct 17 2017

Issue description

I'm finding that there are many new instances of this warning as I get through building Chrome. We may wish to temporarily disable the warning to green our waterfall.
 

Comment 1 by r...@chromium.org, Oct 17 2017

Blocking: 775171

Comment 2 by r...@chromium.org, Oct 17 2017

Owner: r...@chromium.org
This mostly affects gfx::Rect/Size and a few other gfx types. I started a CL and this is what I've had to touch so far:

$ git status
On branch wunused
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

        modified:   cc/ipc/cc_param_traits_unittest.cc
        modified:   cc/ipc/cc_serialization_perftest.cc
        modified:   cc/layers/nine_patch_layer_unittest.cc
        modified:   cc/layers/picture_layer_impl_unittest.cc
        modified:   cc/layers/scrollbar_layer_unittest.cc
        modified:   cc/layers/video_layer_impl_unittest.cc
        modified:   cc/resources/resource_provider_unittest.cc
        modified:   cc/tiles/picture_layer_tiling_unittest.cc
        modified:   cc/trees/layer_tree_host_common_unittest.cc
        modified:   cc/trees/layer_tree_host_impl_unittest.cc
        modified:   cc/trees/layer_tree_impl_unittest.cc
        modified:   components/viz/common/gl_helper_unittest.cc
        modified:   components/viz/common/quads/draw_quad_unittest.cc
        modified:   components/viz/service/display/overlay_unittest.cc
        modified:   services/viz/public/cpp/compositing/struct_traits_unittest.cc

Not too bad, assuming it's OK to delete all of these.

Comment 3 by h...@chromium.org, Oct 17 2017

rnk landed one fix yesterday:
https://chromium-review.googlesource.com/c/chromium/src/+/721889

and the files mentioned in #2 is addressed by in-progress patch
https://chromium-review.googlesource.com/c/chromium/src/+/722443


I'm currently building to see if there's any more that need fixing.

Comment 4 by h...@chromium.org, Oct 17 2017

rnk also already landed https://chromium-review.googlesource.com/722282

Comment 5 by h...@chromium.org, Oct 17 2017

Cc: inglorion@chromium.org
Status: Started (was: Untriaged)
+inglorion who's sheriff this week

This is why the bots are red. We're waiting for rnk's patch to land.
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa2c0e3b0a5bb8556922515531e0e48e094a8ab6

commit aa2c0e3b0a5bb8556922515531e0e48e094a8ab6
Author: Reid Kleckner <rnk@google.com>
Date: Tue Oct 17 19:52:45 2017

Remove various unused variables in Chromium

This mostly affects types like gfx::Rect and gfx::Size, which have
simple constructors that clang can see have no side effects.

R=danakj@chromium.org,vollick@chromium.org,sky@chromium.org,piman@chromium.org,hans@chromium.org,thakis@chromium.org

TBR=hans

Bug:  775328 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Id932168336290aa6c5885d95d235f1d3e7c4c253
Reviewed-on: https://chromium-review.googlesource.com/722443
Reviewed-by: Hans Wennborg <hans@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509492}
[modify] https://crrev.com/aa2c0e3b0a5bb8556922515531e0e48e094a8ab6/cc/ipc/cc_param_traits_unittest.cc
[modify] https://crrev.com/aa2c0e3b0a5bb8556922515531e0e48e094a8ab6/cc/ipc/cc_serialization_perftest.cc
[modify] https://crrev.com/aa2c0e3b0a5bb8556922515531e0e48e094a8ab6/cc/layers/nine_patch_layer_unittest.cc
[modify] https://crrev.com/aa2c0e3b0a5bb8556922515531e0e48e094a8ab6/cc/layers/picture_layer_impl_unittest.cc
[modify] https://crrev.com/aa2c0e3b0a5bb8556922515531e0e48e094a8ab6/cc/layers/scrollbar_layer_unittest.cc
[modify] https://crrev.com/aa2c0e3b0a5bb8556922515531e0e48e094a8ab6/cc/layers/video_layer_impl_unittest.cc
[modify] https://crrev.com/aa2c0e3b0a5bb8556922515531e0e48e094a8ab6/cc/resources/resource_provider_unittest.cc
[modify] https://crrev.com/aa2c0e3b0a5bb8556922515531e0e48e094a8ab6/cc/tiles/picture_layer_tiling_unittest.cc
[modify] https://crrev.com/aa2c0e3b0a5bb8556922515531e0e48e094a8ab6/cc/trees/layer_tree_host_common_unittest.cc
[modify] https://crrev.com/aa2c0e3b0a5bb8556922515531e0e48e094a8ab6/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/aa2c0e3b0a5bb8556922515531e0e48e094a8ab6/cc/trees/layer_tree_impl_unittest.cc
[modify] https://crrev.com/aa2c0e3b0a5bb8556922515531e0e48e094a8ab6/chrome/browser/ui/passwords/manage_passwords_view_utils_unittest.cc
[modify] https://crrev.com/aa2c0e3b0a5bb8556922515531e0e48e094a8ab6/chrome/browser/ui/window_sizer/window_sizer_common_unittest.cc
[modify] https://crrev.com/aa2c0e3b0a5bb8556922515531e0e48e094a8ab6/components/viz/common/gl_helper_unittest.cc
[modify] https://crrev.com/aa2c0e3b0a5bb8556922515531e0e48e094a8ab6/components/viz/common/quads/draw_quad_unittest.cc
[modify] https://crrev.com/aa2c0e3b0a5bb8556922515531e0e48e094a8ab6/components/viz/service/display/overlay_unittest.cc
[modify] https://crrev.com/aa2c0e3b0a5bb8556922515531e0e48e094a8ab6/services/ui/ws/test_utils.cc
[modify] https://crrev.com/aa2c0e3b0a5bb8556922515531e0e48e094a8ab6/services/viz/public/cpp/compositing/struct_traits_unittest.cc
[modify] https://crrev.com/aa2c0e3b0a5bb8556922515531e0e48e094a8ab6/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.cc
[modify] https://crrev.com/aa2c0e3b0a5bb8556922515531e0e48e094a8ab6/ui/compositor/layer_animator_unittest.cc

Comment 7 by thakis@chromium.org, Oct 18 2017

Looks like linux is done.

Mac still red: https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.clang%2FToTMac%2F127%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout

(Windows currently red due to some assert; looks like it was green)

I'll make a CL for that Mac error, but I'm not set up for local mac builds atm, so it's possible there will be more.
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/de88bcfe43db3dd1e6f5892c706633be252e9312

commit de88bcfe43db3dd1e6f5892c706633be252e9312
Author: Nico Weber <thakis@chromium.org>
Date: Wed Oct 18 23:13:01 2017

Remove an unused variable.

Bug:  775328 
Change-Id: I96c860f729c58d3dff9893255978f72eb2bb448b
Reviewed-on: https://chromium-review.googlesource.com/727039
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509917}
[modify] https://crrev.com/de88bcfe43db3dd1e6f5892c706633be252e9312/media/base/mac/video_frame_mac_unittests.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Oct 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb5f5e95fc2951f2f00bb3813806303f10a024d2

commit bb5f5e95fc2951f2f00bb3813806303f10a024d2
Author: Hans Wennborg <hans@chromium.org>
Date: Mon Oct 23 10:41:27 2017

Remove unused variable

TBR=jochen

Bug:  775328 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I4ed8635a82c0d65505281ad44b45b09beefbecf5
Reviewed-on: https://chromium-review.googlesource.com/732958
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510759}
[modify] https://crrev.com/bb5f5e95fc2951f2f00bb3813806303f10a024d2/content/browser/frame_host/render_widget_host_view_guest.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Nov 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2d7bb85bbd16caa7bb1a063d85ab6b1e1d74ebd

commit a2d7bb85bbd16caa7bb1a063d85ab6b1e1d74ebd
Author: Hans Wennborg <hans@chromium.org>
Date: Thu Nov 02 23:35:47 2017

Remove unused variable

TBR=malaykeshav

Bug:  775328 
Change-Id: I81f3bdc825d7bdd648b76aed48d8d89e0b9ede98
Reviewed-on: https://chromium-review.googlesource.com/752571
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513625}
[modify] https://crrev.com/a2d7bb85bbd16caa7bb1a063d85ab6b1e1d74ebd/ui/display/manager/chromeos/touch_transform_controller_unittest.cc

Comment 12 by h...@chromium.org, Nov 3 2017

Status: Fixed (was: Started)

Sign in to add a comment