New issue
Advanced search Search tips

Issue 775323 link

Starred by 2 users
Status: Fixed
Owner:
eroman@chromium.org
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

HTTPSCRLSetTest.* fails depending on the order tests are run

Project Member Reported by eroman@chromium.org, Oct 17 2017 
Reduced repro case:

net_unittests --gtest_filter="HTTPSCRLSetTest.ExpiredCRLSet:HTTPSCRLSetTest.CRLSetRevoked"

When run in this order, CRLSetRevoked will fail.

I believe the problem is these tests set the global CRLSet using SSLConfigService::SetCRLSetIfNewer.

However the sequence number of the test CRLSets is always 0 (so not "newer" by that function's definition).

Comment 1 by eroman@chromium.org, Oct 17 2017

Status: Started (was: Untriaged)
Also it will crash if you run the tests in an order like:

HTTPSEVCRLSetTest.ExpiredCRLSet
HTTPSEVCRLSetTest.MissingCRLSetAndRevokedOCSP
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2243cc605630596e96a9ac748d434bccad2fe48

commit e2243cc605630596e96a9ac748d434bccad2fe48
Author: Eric Roman <eroman@chromium.org>
Date: Tue Oct 17 03:59:13 2017

Fix use of SSLConfigService::SetCRLSetIfNewer() in test code.

This way the order that HTTPSCRLSetTest.* and HTTPSEVCRLSetTest.* are run does not affect their outcome.

Bug:  775323 
Change-Id: I83691d98385811f6091bd38da3ec0ad4f0d33330
Reviewed-on: https://chromium-review.googlesource.com/722353
Commit-Queue: Eric Roman <eroman@chromium.org>
Reviewed-by: Matt Mueller <mattm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509275}
[modify] https://crrev.com/e2243cc605630596e96a9ac748d434bccad2fe48/net/ssl/ssl_config_service.cc
[modify] https://crrev.com/e2243cc605630596e96a9ac748d434bccad2fe48/net/ssl/ssl_config_service.h
[modify] https://crrev.com/e2243cc605630596e96a9ac748d434bccad2fe48/net/url_request/url_request_unittest.cc

Comment 4 by eroman@chromium.org, Oct 18 2017

Status: Fixed (was: Started)
►

Sign in to add a comment