New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 775309 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

3.6%-5.9% regression in media.desktop at 508764:508925

Project Member Reported by hubbe@chromium.org, Oct 17 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Oct 17 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=775309

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=acc22d0d7349e61f7ac6f7c59d222579ae48168b4fbc0d4f62fe3468bb4d4dbf


Bot(s) for this bug's original alert(s):

chromium-rel-mac-retina
chromium-rel-mac11
chromium-rel-mac11-air
chromium-rel-mac11-pro
chromium-rel-mac12
chromium-rel-mac12-mini-8gb
Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, Oct 17 2017

馃搷 Pinpoint job started.
https://pinpoint-dot-chromeperf.appspot.com/job/1285882b780000
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Oct 17 2017

Cc: ishell@chromium.org sande...@chromium.org sreten.k...@imgtec.com verwa...@chromium.org jkummerow@chromium.org ftirelo@chromium.org machenb...@chromium.org jarin@chromium.org cbruni@chromium.org leszeks@chromium.org bmeu...@chromium.org u...@chromium.org dalecur...@chromium.org adamk@chromium.org mathias@chromium.org ivica.bo...@imgtec.com csharp@chromium.org mslekova@google.com
Owner: dalecur...@chromium.org
馃搷 Found significant differences after each of 9 commits.
https://pinpoint-dot-chromeperf.appspot.com/job/1285882b780000

Enable the new Cleaner prompt by default
By ftirelo@chromium.org 路 Fri Oct 13 22:56:03 2017
chromium @ 0cc3fa5dd07df13f6a3c5806a86806a469811b76

<b>[bigint] Support BigInts in <<,>>,>>>,&,|,^ binary ops</b>
By jkummerow@chromium.org 路 Wed Oct 11 17:36:53 2017
v8 @ 1560988249c97c5cc1763aa364a0423f9e318c13

Reland "Add fast path to ObjectGetOwnPropertyDescriptor"
By mslekova@google.com 路 Thu Oct 12 10:52:18 2017
v8 @ b5acda73ff21a96eaef3bef1ab58945c6499ad5a

MIPS[64]: Skip regress-752764 test
By sreten.kovacevic@imgtec.com 路 Fri Oct 13 08:23:27 2017
v8 @ ad38a4e32391784333e893018f8b723a84e7bb49

[test] Improve printing for investigating hung tests
By machenbach@chromium.org 路 Fri Oct 13 08:24:36 2017
v8 @ c1f7694b5d784aa3d33d77bf04e6d4d4e50a6508

Reland "[runtime] Make JSFunction::prototype_or_initial_map field optional."
By ishell@chromium.org 路 Fri Oct 13 09:09:28 2017
v8 @ 36860509fbc5c63f5351aa45e66418a79fa26758

[cleanup] Remove leftover tail-call check.
By bmeurer@chromium.org 路 Fri Oct 13 09:28:27 2017
v8 @ e8f6d0c176c84176b171c2cd5dcf2d8ff6722ca9

[macro-assembler] Delete unused SmiTest
By verwaest@chromium.org 路 Fri Oct 13 09:36:47 2017
v8 @ cfce134a64cd28d96cbd6f26a97d2de6b3a2dbd2

Add support for discarding video frames post-decode.
By dalecurtis@chromium.org 路 Sat Oct 14 01:01:26 2017
chromium @ 5341599c0b2b5a74f62a7734d592d7faae9983c8

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Seems fixed? https://chromeperf.appspot.com/report?sid=797c80ccbbe01ffa70ff1ae333f712dd292f19b570126591745c6c16344acd39&rev=508925

No clear revert in that listing.

It might be the same as  issue 775299  which is timing related, but maybe my change helped and another of these was the initial regression?

Any of the other cc'd folk see anything?

Comment 5 by cbruni@chromium.org, Oct 17 2017

Owner: ishell@chromium.org
Woah, pinpoint is awesome! :) 

This is a regression on the v8 heap (old space objects).

Regression: https://chromium.googlesource.com/v8/v8/+log/094a7c93..b7d76640?n=10000
Reland "[runtime] Make JSFunction::prototype_or_initial_map field optional."

Improvement: https://chromium.googlesource.com/v8/v8/+log/b83707f4..f4579b90?n=10000
f7b09b3 Reland "[snapshot] Ship lazy TFJ builtins" by Jakob Gruber 路 26 hours ago 

So the fix is most probably unrelated. 


Igor, from what I'd expect your CL should not cause any memory regressions, no?
Labels: Performance-Media
Components: Internals>Media

Sign in to add a comment