Move code for script elements and related scripting code to core/scripts (mainly from core/dom). Design doc: https://docs.google.com/presentation/d/1H-1U9LmCghOmviw0nYE_SP_r49-bU42SkViBn539-vg/edit?usp=sharing This is initiated as a part of core/dom clean up (Issue 738794) and a related discussion is found in https://groups.google.com/a/chromium.org/forum/#!topic/loading-dev/GYPCLAsvpo4.
The actual movement is planned later (e.g. the end of 2017), because currently the files to be placed under core/script are under active development for module scripts support.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d3fa3986ac1fde109edbefd44e11198ccf3f5beb commit d3fa3986ac1fde109edbefd44e11198ccf3f5beb Author: Hiroshige Hayashizaki <hiroshige@chromium.org> Date: Fri Oct 20 02:49:19 2017 Introduce XMLParserScriptRunner Like HTMLParserScriptRunner, this CL moves script-related part of XMLDocumentParser into a new class XMLParserScriptRunner. This CL also removes |has_view_|, and instead sets |XMLDocumentParser::script_runner_| to nullptr if |has_view_| was false. This CL also removes outdated comments. Bug: 775305 Change-Id: Ic47f2907ae8e79b9a0e5ef0c964061951f27c6dd Reviewed-on: https://chromium-review.googlesource.com/695833 Reviewed-by: Jeremy Roman <jbroman@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#510308} [modify] https://crrev.com/d3fa3986ac1fde109edbefd44e11198ccf3f5beb/third_party/WebKit/Source/core/xml/BUILD.gn [modify] https://crrev.com/d3fa3986ac1fde109edbefd44e11198ccf3f5beb/third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp [modify] https://crrev.com/d3fa3986ac1fde109edbefd44e11198ccf3f5beb/third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.h [add] https://crrev.com/d3fa3986ac1fde109edbefd44e11198ccf3f5beb/third_party/WebKit/Source/core/xml/parser/XMLParserScriptRunner.cpp [add] https://crrev.com/d3fa3986ac1fde109edbefd44e11198ccf3f5beb/third_party/WebKit/Source/core/xml/parser/XMLParserScriptRunner.h [add] https://crrev.com/d3fa3986ac1fde109edbefd44e11198ccf3f5beb/third_party/WebKit/Source/core/xml/parser/XMLParserScriptRunnerHost.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/72327c8248ae16dddf0355054c8f82016e94163f commit 72327c8248ae16dddf0355054c8f82016e94163f Author: Hiroshige Hayashizaki <hiroshige@chromium.org> Date: Fri Dec 08 19:20:41 2017 Style fix in script-related files This CL fixes existing style errors in the files to be moved to core/script. Preparation for https://chromium-review.googlesource.com/808750. Bug: 775305 Change-Id: Id4dcdcbd843b10eead61fefbc6a44b2f68fed49c Reviewed-on: https://chromium-review.googlesource.com/808749 Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#522837} [modify] https://crrev.com/72327c8248ae16dddf0355054c8f82016e94163f/third_party/WebKit/Source/core/dom/ScriptLoader.cpp [modify] https://crrev.com/72327c8248ae16dddf0355054c8f82016e94163f/third_party/WebKit/Source/core/dom/ScriptRunner.cpp [modify] https://crrev.com/72327c8248ae16dddf0355054c8f82016e94163f/third_party/WebKit/Source/core/dom/ScriptRunnerTest.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/54bdaedb99ae392cc497820d20e0e7cdc04c1f43 commit 54bdaedb99ae392cc497820d20e0e7cdc04c1f43 Author: Hiroshige Hayashizaki <hiroshige@chromium.org> Date: Wed Dec 20 23:54:03 2017 Introduce core/script Design doc: https://docs.google.com/presentation/d/1H-1U9LmCghOmviw0nYE_SP_r49-bU42SkViBn539-vg/edit?usp=sharing Mostly mechanical: Files are moved, and include paths and BUILD.gn files are modified. Manual changes not necessarily needed for build is split out to a subsequent CL: https://chromium-review.googlesource.com/809366 Bug: 775305 , 738794 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I3c50e73cab34362a40e85e6c95456ebfdcafd995 Reviewed-on: https://chromium-review.googlesource.com/808750 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Reviewed-by: Takayoshi Kochi <kochi@chromium.org> Cr-Commit-Position: refs/heads/master@{#525518} [modify] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.cpp [modify] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/bindings/core/v8/ScriptModule.cpp [modify] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/bindings/core/v8/ScriptModuleTest.cpp [modify] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp [modify] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/bindings/core/v8/ScriptStreamerTest.cpp [modify] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp [modify] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/BUILD.gn [modify] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/dom/BUILD.gn [modify] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/dom/Document.cpp [modify] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp [modify] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/html/HTMLScriptElement.cpp [modify] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/html/HTMLScriptElement.h [modify] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/html/parser/BUILD.gn [modify] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.cpp [modify] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp [modify] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.h [modify] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp [modify] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/html/parser/PreloadRequest.cpp [modify] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/html/parser/PreloadRequest.h [modify] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/loader/LinkLoader.cpp [modify] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/loader/LinkLoader.h [modify] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/loader/modulescript/DocumentModuleScriptFetcher.h [modify] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/loader/modulescript/ModuleScriptLoader.cpp [modify] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/loader/modulescript/ModuleScriptLoaderTest.cpp [modify] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/loader/modulescript/ModuleTreeLinker.cpp [modify] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/loader/modulescript/ModuleTreeLinker.h [modify] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/loader/modulescript/ModuleTreeLinkerTest.cpp [add] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/script/BUILD.gn [rename] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/script/ClassicPendingScript.cpp [rename] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/script/ClassicPendingScript.h [rename] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/script/ClassicScript.cpp [rename] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/script/ClassicScript.h [rename] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/script/DocumentModulatorImpl.cpp [rename] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/script/DocumentModulatorImpl.h [rename] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/script/DocumentWriteIntervention.cpp [rename] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/script/DocumentWriteIntervention.h [rename] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/script/DynamicModuleResolver.cpp [rename] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/script/DynamicModuleResolver.h [rename] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/script/DynamicModuleResolverTest.cpp [rename] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/script/HTMLParserScriptRunner.cpp [rename] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/script/HTMLParserScriptRunner.h [rename] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/script/HTMLParserScriptRunnerHost.h [rename] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/script/IgnoreDestructiveWriteCountIncrementer.h [rename] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/script/MockScriptElementBase.h [rename] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/script/Modulator.cpp [rename] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/script/Modulator.h [rename] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/script/ModulatorImplBase.cpp [rename] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/script/ModulatorImplBase.h [rename] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/script/ModulatorTest.cpp [rename] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/script/ModuleImportMeta.h [rename] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/script/ModuleMap.cpp [rename] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/script/ModuleMap.h [rename] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/script/ModuleMapTest.cpp [rename] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/script/ModulePendingScript.cpp [rename] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/script/ModulePendingScript.h [rename] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/script/ModuleScript.cpp [rename] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/script/ModuleScript.h [rename] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/script/PendingScript.cpp [rename] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/script/PendingScript.h [rename] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/script/Script.h [rename] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/script/ScriptElementBase.cpp [rename] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/script/ScriptElementBase.h [rename] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/script/ScriptLoader.cpp [rename] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/script/ScriptLoader.h [rename] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/script/ScriptModuleResolver.h [rename] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/script/ScriptModuleResolverImpl.cpp [rename] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/script/ScriptModuleResolverImpl.h [rename] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/script/ScriptModuleResolverImplTest.cpp [rename] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/script/ScriptRunner.cpp [rename] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/script/ScriptRunner.h [rename] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/script/ScriptRunnerTest.cpp [rename] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/script/WorkerModulatorImpl.cpp [rename] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/script/WorkerModulatorImpl.h [rename] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/script/WorkletModulatorImpl.cpp [rename] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/script/WorkletModulatorImpl.h [rename] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/script/XMLParserScriptRunner.cpp [rename] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/script/XMLParserScriptRunner.h [rename] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/script/XMLParserScriptRunnerHost.h [modify] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/svg/SVGScriptElement.cpp [modify] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/svg/SVGScriptElement.h [modify] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/testing/DummyModulator.cpp [modify] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/testing/DummyModulator.h [modify] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.cpp [modify] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/workers/WorkletGlobalScope.cpp [modify] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/workers/WorkletModuleTreeClient.cpp [modify] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/workers/WorkletModuleTreeClient.h [modify] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/xml/BUILD.gn [modify] https://crrev.com/54bdaedb99ae392cc497820d20e0e7cdc04c1f43/third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/04f905d2278a2eca908cae315ca8fec06db41705 commit 04f905d2278a2eca908cae315ca8fec06db41705 Author: Hiroshige Hayashizaki <hiroshige@chromium.org> Date: Sat Dec 23 00:20:36 2017 Add OWNERS/README.md to core/script Bug: 775305 Change-Id: I0a3cbef725c1d5364a8043004c11c0d9c0a8fdee Reviewed-on: https://chromium-review.googlesource.com/809366 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#526103} [add] https://crrev.com/04f905d2278a2eca908cae315ca8fec06db41705/third_party/WebKit/Source/core/script/OWNERS [add] https://crrev.com/04f905d2278a2eca908cae315ca8fec06db41705/third_party/WebKit/Source/core/script/README.md
Done!
Comment 1 by hirosh...@chromium.org
, Oct 17 2017