New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 775281 link

Starred by 2 users
Status: Fixed
Owner:
█ shrike@chromium.org
Last visit > 30 days ago
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

[Mac] Default browser confirmation window is sometimes hidden

Project Member Reported by shrike@chromium.org, Oct 16 2017 
What steps will reproduce the problem?

(1) Use System Preferences to set Safari as the default browser
(2) Launch Chrome
(3) Use Chrome preferences to set Chrome as the default browser

What is the expected result?
A dialog appears asking me to confirm my choice of Chrome as my default browser.

What happens instead?
Sometimes this dialog is ordered onscreen but under the Chrome window, so that it is effectively not visible. Without confirmation, macOS will not change the default browser.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8605ed9d403450b551faa9680c7393f107b2170

commit d8605ed9d403450b551faa9680c7393f107b2170
Author: Jayson Adams <shrike@chromium.org>
Date: Tue Oct 17 23:07:02 2017

[Mac] Force macOS confirm window to front after default browser change.

When you use Chrome's infobar or Settings page to make Chrome your
default browser, macOS presents a confirmation dialog. Sometimes macOS
orders the dialog onscreen but behind the browser window, where it is
effectively invisible. Without confirmation via this dialog, macOS will
not change your default browser.

This cl forces the UI element responsible for the dialog to become
active after setting the default browser, bringing the confirmation
dialog to the foreground, in front of all windows.

Bug:  775281 
Change-Id: I5376d57c088ea6b564d84cb3d35442a4330f954b
Reviewed-on: https://chromium-review.googlesource.com/722221
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Jayson Adams <shrike@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509581}
[modify] https://crrev.com/d8605ed9d403450b551faa9680c7393f107b2170/chrome/browser/shell_integration_mac.mm

Comment 2 by shrike@chromium.org, Oct 17 2017

Status: Fixed (was: Started)

Comment 3 by susanjuniab@chromium.org, Oct 18 2017

Labels: TE-Verified-M64 TE-Verified-64.0.3243.0
shrike@ Re-Tested this issue again on Mac OS 10.12.6 on 64.0.3243.0 by following the steps mentioned in the original comment and can observe the dialogue box asking to use Safari or Use Chrome.

Hence adding TE Verified labels .

Thanks...
►

Sign in to add a comment