New issue
Advanced search Search tips

Issue 775276 link

Starred by 1 user
Status: Fixed
Owner:
vadimsh@chromium.org
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 712444



Sign in to add a comment

Add 'defaults' section to token server's service_accounts.cfg file

Project Member Reported by vadimsh@chromium.org, Oct 16 2017 
It will contain list of scopes we grant by default to all service accounts, e.g

defaults {
  allowed_scope: "https://www.googleapis.com/auth/cloud-platform"
  allowed_scope: "https://www.googleapis.com/auth/gerritcodereview"
  allowed_scope: "https://www.googleapis.com/auth/userinfo.email"
}

Will somewhat reduce copy-pasta in this file.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/24e9a3b55012e28423e31a38103a2c1ba6821e61

commit 24e9a3b55012e28423e31a38103a2c1ba6821e61
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Tue Oct 17 18:42:45 2017

token-server: Add 'defaults' section to service account rules config.

R=tandrii@chromium.org
BUG= 775276 

Change-Id: I1a76ca728e0f141776d129a40a75438b266067bc
Reviewed-on: https://chromium-review.googlesource.com/722204
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/24e9a3b55012e28423e31a38103a2c1ba6821e61/tokenserver/api/admin/v1/admin.pb.go
[modify] https://crrev.com/24e9a3b55012e28423e31a38103a2c1ba6821e61/tokenserver/api/admin/v1/config.pb.go
[modify] https://crrev.com/24e9a3b55012e28423e31a38103a2c1ba6821e61/tokenserver/api/admin/v1/config.proto
[modify] https://crrev.com/24e9a3b55012e28423e31a38103a2c1ba6821e61/tokenserver/api/admin/v1/pb.discovery.go
[modify] https://crrev.com/24e9a3b55012e28423e31a38103a2c1ba6821e61/tokenserver/appengine/impl/serviceaccounts/config.go
[modify] https://crrev.com/24e9a3b55012e28423e31a38103a2c1ba6821e61/tokenserver/appengine/impl/serviceaccounts/config_test.go
[modify] https://crrev.com/24e9a3b55012e28423e31a38103a2c1ba6821e61/tokenserver/appengine/impl/serviceaccounts/config_validation.go
[modify] https://crrev.com/24e9a3b55012e28423e31a38103a2c1ba6821e61/tokenserver/appengine/impl/serviceaccounts/config_validation_test.go
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 17 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/408315a4e721f2d1118b8e25d089322dfa3433cb

commit 408315a4e721f2d1118b8e25d089322dfa3433cb
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Tue Oct 17 20:20:51 2017
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 17 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/aedd82af2a2e7f7a517eb4720c85ad0b3ab57000

commit aedd82af2a2e7f7a517eb4720c85ad0b3ab57000
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Tue Oct 17 22:01:40 2017

Comment 4 by vadimsh@chromium.org, Oct 18 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment