New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 775272 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 3
Type: Bug



Sign in to add a comment

compile failure in arm64 fuchsia

Project Member Reported by scottmg@chromium.org, Oct 16 2017

Issue description

good at 4840cb96f11c8a472c19a1f75027f8ac1800a6df
bad at 1bf4f34b088b

[972->1665/2802 ~166] CC obj/third_party/opus/opus/warped_autocorrelation_FIX_neon_intr.o
FAILED: obj/third_party/opus/opus/warped_autocorrelation_FIX_neon_intr.o 
/usr/local/google/home/scottmg/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang -MMD -MF obj/third_party/opus/opus/warped_autocorrelation_FIX_neon_intr.o.d -DOPUS_BUILD -DOPUS_EXPORT= -DHAVE_LRINT -DHAVE_LRINTF -DVAR_ARRAYS -DFIXED_POINT -DOPUS_ARM_MAY_HAVE_NEON -DOPUS_ARM_MAY_HAVE_NEON_INTR -DV8_DEPRECATION_WARNINGS -DDCHECK_ALWAYS_ON=1 -DUSE_AURA=1 -DUSE_OZONE=1 -DNO_TCMALLOC -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DFUCHSIA_SDK_VERSION=bb7a8c4be8001868468ba0a76389ce4ee111620c -DCR_CLANG_REVISION=\"315613-1\" -D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS -D_LIBCXXABI_DISABLE_VISIBILITY_ANNOTATIONS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DOPUS_FIXED_POINT -I../../third_party/opus/src -I../../third_party/opus/src/celt -I../../third_party/opus/src/silk -I../../third_party/opus/src/silk/fixed -I../.. -Igen -I../../third_party/opus/src/include -Wno-\#pragma-messages -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -funwind-tables -fPIC -pipe -fcolor-diagnostics -no-canonical-prefixes --target=aarch64-fuchsia -fomit-frame-pointer -g1 -fvisibility=hidden -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-auto-raw-pointer -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Werror -Wall -Wno-unused-variable -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -Wno-unused-lambda-capture -Wno-user-defined-warnings -Wno-enum-compare-switch -Wno-tautological-unsigned-zero-compare -Wno-null-pointer-arithmetic -Wno-tautological-unsigned-enum-zero-compare -O3 -fno-ident -fdata-sections -ffunction-sections -std=c11 -isystem../../buildtools/third_party/libunwind/trunk/include --sysroot=../../third_party/fuchsia-sdk/sysroot/aarch64-fuchsia -c ../../third_party/opus/src/silk/fixed/arm/warped_autocorrelation_FIX_neon_intr.c -o obj/third_party/opus/opus/warped_autocorrelation_FIX_neon_intr.o
../../third_party/opus/src/silk/fixed/arm/warped_autocorrelation_FIX_neon_intr.c:43:37: error: incompatible pointer types assigning to 'const long *' from 'long long *' [-Werror,-Wincompatible-pointer-types]
    corr_QC_s64x2[ 0 ] = vld1q_s64( corr_QC + offset + 0 );
                                    ^~~~~~~~~~~~~~~~~~~~
../../third_party/llvm-build/Release+Asserts/lib/clang/6.0.0/include/arm_neon.h:7628:46: note: expanded from macro 'vld1q_s64'
  __ret = (int64x2_t) __builtin_neon_vld1q_v(__p0, 35); \
                                             ^~~~
../../third_party/opus/src/silk/fixed/arm/warped_autocorrelation_FIX_neon_intr.c:44:37: error: incompatible pointer types assigning to 'const long *' from 'long long *' [-Werror,-Wincompatible-pointer-types]
    corr_QC_s64x2[ 1 ] = vld1q_s64( corr_QC + offset + 2 );
                                    ^~~~~~~~~~~~~~~~~~~~
../../third_party/llvm-build/Release+Asserts/lib/clang/6.0.0/include/arm_neon.h:7628:46: note: expanded from macro 'vld1q_s64'
  __ret = (int64x2_t) __builtin_neon_vld1q_v(__p0, 35); \
                                             ^~~~
../../third_party/opus/src/silk/fixed/arm/warped_autocorrelation_FIX_neon_intr.c:49:16: error: incompatible pointer types assigning to 'long *' from 'long long *' [-Werror,-Wincompatible-pointer-types]
    vst1q_s64( corr_QC + offset + 0, corr_QC_s64x2[ 0 ] );
               ^~~~~~~~~~~~~~~~~~~~
../../third_party/llvm-build/Release+Asserts/lib/clang/6.0.0/include/arm_neon.h:25122:26: note: expanded from macro 'vst1q_s64'
  __builtin_neon_vst1q_v(__p0, (int8x16_t)__s1, 35); \
                         ^~~~
../../third_party/opus/src/silk/fixed/arm/warped_autocorrelation_FIX_neon_intr.c:50:16: error: incompatible pointer types assigning to 'long *' from 'long long *' [-Werror,-Wincompatible-pointer-types]
    vst1q_s64( corr_QC + offset + 2, corr_QC_s64x2[ 1 ] );
               ^~~~~~~~~~~~~~~~~~~~
../../third_party/llvm-build/Release+Asserts/lib/clang/6.0.0/include/arm_neon.h:25122:26: note: expanded from macro 'vst1q_s64'
  __builtin_neon_vst1q_v(__p0, (int8x16_t)__s1, 35); \
                         ^~~~
../../third_party/opus/src/silk/fixed/arm/warped_autocorrelation_FIX_neon_intr.c:230:41: error: incompatible pointer types assigning to 'const long *' from 'long long *' [-Werror,-Wincompatible-pointer-types]
            corr_QC0_s64x2 = vld1q_s64( corr_QCT + i );
                                        ^~~~~~~~~~~~
../../third_party/llvm-build/Release+Asserts/lib/clang/6.0.0/include/arm_neon.h:7628:46: note: expanded from macro 'vld1q_s64'
  __ret = (int64x2_t) __builtin_neon_vld1q_v(__p0, 35); \
                                             ^~~~
../../third_party/opus/src/silk/fixed/arm/warped_autocorrelation_FIX_neon_intr.c:231:41: error: incompatible pointer types assigning to 'const long *' from 'long long *' [-Werror,-Wincompatible-pointer-types]
            corr_QC1_s64x2 = vld1q_s64( corr_QCT + i + 2 );
                                        ^~~~~~~~~~~~~~~~
../../third_party/llvm-build/Release+Asserts/lib/clang/6.0.0/include/arm_neon.h:7628:46: note: expanded from macro 'vld1q_s64'
  __ret = (int64x2_t) __builtin_neon_vld1q_v(__p0, 35); \
                                             ^~~~
6 errors generated.



 
Cc: w...@chromium.org kthelgason@chromium.org
Not surprisingly, started here. So mostly we just need CQ bots for this config. :)

9d1eff2dfed69690c4a6f312d54cb92c15e516f7 is the first bad commit
commit 9d1eff2dfed69690c4a6f312d54cb92c15e516f7
Author: Kári Tristan Helgason <kthelgason@chromium.org>
Date:   Mon Oct 16 15:56:32 2017 +0000

    Compile opus w/ neon intrinsics on arm64.
    
    This results in significant speedups on those devices.
    
    Bug:  768411 
    Change-Id: I9ece6f14803489b854f6551d0136b407bb006ee7
    Reviewed-on: https://chromium-review.googlesource.com/681703
    Reviewed-by: Henrik Andreasson <henrika@chromium.org>
    Commit-Queue: Kári Tristan Helgason <kthelgason@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#509063}

:040000 040000 cc79bb2bae9debefcb9c96ce851ea731c2beb48f 859a29df14cafbe7afec0ab23ef24858c0585b84 M	third_party

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6598a63c48a1f203dee48d6a351b112add90fa1

commit e6598a63c48a1f203dee48d6a351b112add90fa1
Author: Scott Graham <scottmg@chromium.org>
Date: Tue Oct 17 21:29:47 2017

fuchsia: Exclude fuchsia from ARM optimizations for now

Currently fails to compile when using neon opts on Fuchsia. Disable for
now, since the ARM64 port is just trying to get to the linking/prototype
stage.

Bug:  768411 ,  775272 
Change-Id: I7adfa8dd97badb1f20ba38b36b5e438e9a7b1ede
Reviewed-on: https://chromium-review.googlesource.com/722262
Reviewed-by: Henrik Andreasson <henrika@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509541}
[modify] https://crrev.com/e6598a63c48a1f203dee48d6a351b112add90fa1/third_party/opus/BUILD.gn

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8543c6d7f6d3e6b5110b2a03c7effe094f1478b2

commit 8543c6d7f6d3e6b5110b2a03c7effe094f1478b2
Author: Wez <wez@chromium.org>
Date: Tue Oct 17 21:49:43 2017

Add targets to the Fuchsia ARM64 builder.

The builder was brought up with just base_unittests, but we now have
most of our current set of targets compiling for ARM64 as well.

headless_shell, content_unittests, media_unittests and skia_unittests
are not yet built, due to a dependency on third_party/opus, which is
currently broken.

Bug:  772031 ,  775272 
Change-Id: I67996585207793243e1bcc900ad89ae4014d5385
Reviewed-on: https://chromium-review.googlesource.com/723582
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509550}
[modify] https://crrev.com/8543c6d7f6d3e6b5110b2a03c7effe094f1478b2/testing/buildbot/chromium.fyi.json

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2a6495ad84a298a611b4a832722a8a3115fce91

commit e2a6495ad84a298a611b4a832722a8a3115fce91
Author: Wez <wez@chromium.org>
Date: Tue Oct 17 22:34:11 2017

Enable content_,media_,skia_ unittests and headless_shell on ARM64 bot.

These targets depend on third_party/opus, which did not build for
Fuchsia-ARM64.

Bug:  772031 ,  775272 
Change-Id: I0ec4bcadc63b5e250b0b2363b7efdcfb52762382
Reviewed-on: https://chromium-review.googlesource.com/723853
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509573}
[modify] https://crrev.com/e2a6495ad84a298a611b4a832722a8a3115fce91/testing/buildbot/chromium.fyi.json

Cc: -kthelgason@chromium.org scottmg@chromium.org
Owner: kthelgason@chromium.org
Status: Assigned (was: Started)
This failed to compile due to a type-mismatch in Opus. A patch has been submitted to them and when it lands upstream and eventually finds it's way into chromium we can re-enable this. 

I can follow the process and close the bug when done.
Thanks Kári!

Comment 7 by w...@chromium.org, Dec 8 2017

Status: Fixed (was: Assigned)

Sign in to add a comment