Make media_metric work for multiple media playbacks in a single trace |
||
Issue descriptionhttps://cs.chromium.org/chromium/src/third_party/catapult/tracing/tracing/metrics/media_metric.html?q=media_metric.html&sq=package:chromium&dr&l=61 Only reports a single time_to_play even when there are multiple playbacks in a single trace. There are two ways that we could have multiple playbacks in a single trace: (1). Back to back playbacks: If you play a video, the video ends, and then you play another video. (2). Simultaneous playbacks Either you can have two videos running on a single page at the same time, or you could have two videos going in separate tabs at the same time. It would be good to at least support (1). Supporting (2) might be rather difficult. Low hanging fruit: This line https://cs.chromium.org/chromium/src/third_party/catapult/tracing/tracing/metrics/media_metric.html?q=media_metric.html&sq=package:chromium&dr&l=61 rendererHelper.process.findAtMostOneThreadNamed('AudioOutputDevice'); has an assumption that only one audio output device exists. When that assumption is false, the code simply fails. That assumption is false for multiple audio playbacks. This blocks MSE cases merge to TBMv2 work because MSE cases requires to be able to play back-to-back videos so that we can get statistically-significant results. John has offered to start looking into this, but he may assign back to me.
,
Nov 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/5b827c45019ed01e2a673520c122e729532f7e83 commit 5b827c45019ed01e2a673520c122e729532f7e83 Author: John Chen <johnchen@chromium.org> Date: Thu Nov 02 05:25:27 2017 Update media metric to support multiple media in a trace Make use of the media ID that has been added to media trace events, to support multiple media playbacks in a single trace. Bug: chromium:775264 Change-Id: I0e5c89304179bb1e1c38bd15c1f964506326cd64 Reviewed-on: https://chromium-review.googlesource.com/740870 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by: Ben Hayden <benjhayden@chromium.org> [modify] https://crrev.com/5b827c45019ed01e2a673520c122e729532f7e83/tracing/tracing/metrics/media_metric.html [modify] https://crrev.com/5b827c45019ed01e2a673520c122e729532f7e83/tracing/tracing/metrics/media_metric_test.html
,
Nov 2 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Nov 1 2017