New issue
Advanced search Search tips

Issue 775261 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Headless chrome doesn't save or restore cookies from disk.

Project Member Reported by einbinder@chromium.org, Oct 16 2017 
localstorage is written into the user-data-dir, but cookies are not. This makes restoring state from disk difficult.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/841320ae52ada38ec868d1a824bdb2bbe8754ccf

commit 841320ae52ada38ec868d1a824bdb2bbe8754ccf
Author: Joel Einbinder <einbinder@chromium.org>
Date: Tue Oct 17 10:31:01 2017

Headless: Use persistent cookie storage

Bug:  775261 
Change-Id: Ia0af1a184a5780c214be7607fdbd40a5a914d295
Reviewed-on: https://chromium-review.googlesource.com/719612
Reviewed-by: David Vallet <dvallet@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509347}
[modify] https://crrev.com/841320ae52ada38ec868d1a824bdb2bbe8754ccf/headless/lib/browser/headless_url_request_context_getter.cc

Comment 2 by einbinder@chromium.org, Oct 18 2017

Status: Fixed (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b2a41840dfeb57f521e7638b3c05c663f0ba7d9

commit 2b2a41840dfeb57f521e7638b3c05c663f0ba7d9
Author: Joel Einbinder <einbinder@chromium.org>
Date: Mon Oct 30 00:51:26 2017

Headless: Lock before using browser context to set up cookies

Bug:  775261 
Change-Id: I33e5131e8b922868881d44da864931ae80b4700f
Reviewed-on: https://chromium-review.googlesource.com/727019
Reviewed-by: David Vallet <dvallet@chromium.org>
Commit-Queue: David Vallet <dvallet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512426}
[modify] https://crrev.com/2b2a41840dfeb57f521e7638b3c05c663f0ba7d9/headless/lib/browser/headless_url_request_context_getter.cc
►

Sign in to add a comment