New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 775244 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

[Media Router] Casting to Youtube stops more often with in-browser Cast discovery enabled

Project Member Reported by zhaobin@chromium.org, Oct 16 2017

Issue description

Cast a long video (30 mins) on Youtube with in-browser Cast discovery enabled. When network is unstable, casting stops 2-3 times while playing. Without in-browser Cast discovery, casting never stops.
 
Hmmm, I am not aware of anything different in in-browser discovery that would cause the app on the receiver to be terminated.

Comment 2 by w...@chromium.org, Oct 17 2017

Is there anything that would cause the CastChannel to be torn-down or reset
in response to discovery events? e.g. if in-browser discovery is causing
more "device discovered" notifications, and that's causing the browser to
repeatedly re-connect to the device, might that cause the active
CastChannel to be dropped by the device?
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56a2b88da4ed8ab7bee6aab7d8e2e7f1397bf862

commit 56a2b88da4ed8ab7bee6aab7d8e2e7f1397bf862
Author: Bin Zhao <zhaobin@chromium.org>
Date: Wed Oct 18 17:21:38 2017

[Media Router] Remove sink from current_sinks_map_ only when all retry attempts fail

In existing code we remove a sink from |current_sinks_map_| when an open
channel request (single retry attempt) fails. It removes sinks and routes
from extension side, which may terminate Youtube session too early.
Changed it to remove sink only when all retry attempts fail.

Bug:  775244 
Change-Id: I7a881fdb15122a71a0963d9aee6c04744239828a
Reviewed-on: https://chromium-review.googlesource.com/722127
Commit-Queue: Bin Zhao <zhaobin@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509800}
[modify] https://crrev.com/56a2b88da4ed8ab7bee6aab7d8e2e7f1397bf862/chrome/browser/media/router/discovery/mdns/cast_media_sink_service_impl.cc
[modify] https://crrev.com/56a2b88da4ed8ab7bee6aab7d8e2e7f1397bf862/chrome/browser/media/router/discovery/mdns/cast_media_sink_service_impl_unittest.cc

Labels: Merge-Request-63
Labels: M-63
Status: Assigned (was: Untriaged)
Please add appropriate OSs.
Labels: OS-Chrome OS-Linux OS-Mac OS-Windows
Project Member

Comment 7 by sheriffbot@chromium.org, Oct 20 2017

Labels: -Merge-Request-63 Hotlist-Merge-Approved Merge-Approved-63
Your change meets the bar and is auto-approved for M63. Please go ahead and merge the CL to branch 3239 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 8 by gov...@chromium.org, Oct 20 2017

Please merge your change to M63 branch 3239 before 4:00 PM PT today if possible, so we can take it in for next week last M63 dev release. Thank you.
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 20 2017

Labels: -merge-approved-63 merge-merged-3239
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbb4ca5bb96f39717d1f23870554c31b24daa5c1

commit cbb4ca5bb96f39717d1f23870554c31b24daa5c1
Author: Bin Zhao <zhaobin@chromium.org>
Date: Fri Oct 20 17:57:10 2017

[Media Router] Remove sink from current_sinks_map_ only when all retry attempts fail

In existing code we remove a sink from |current_sinks_map_| when an open
channel request (single retry attempt) fails. It removes sinks and routes
from extension side, which may terminate Youtube session too early.
Changed it to remove sink only when all retry attempts fail.

TBR=zhaobin@chromium.org

(cherry picked from commit 56a2b88da4ed8ab7bee6aab7d8e2e7f1397bf862)

Bug:  775244 
Change-Id: I7a881fdb15122a71a0963d9aee6c04744239828a
Reviewed-on: https://chromium-review.googlesource.com/722127
Commit-Queue: Bin Zhao <zhaobin@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#509800}
Reviewed-on: https://chromium-review.googlesource.com/730419
Reviewed-by: Bin Zhao <zhaobin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#113}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[modify] https://crrev.com/cbb4ca5bb96f39717d1f23870554c31b24daa5c1/chrome/browser/media/router/discovery/mdns/cast_media_sink_service_impl.cc
[modify] https://crrev.com/cbb4ca5bb96f39717d1f23870554c31b24daa5c1/chrome/browser/media/router/discovery/mdns/cast_media_sink_service_impl_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment